Re: [Mingw-w64-public] [PATCH] winpthreads: Add missing `__stdcall` on lazy-binding function pointers

2024-09-23 Thread LIU Hao
在 2024-09-24 02:34, Jacek Caban 写道: Looks good to me. Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.

Re: [Mingw-w64-public] [PATCH] winpthreads: Add missing `__stdcall` on lazy-binding function pointers

2024-09-23 Thread Jacek Caban
Looks good to me. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 2/2] crt: Add (void(*)(void)) casts to silence warnings about function pointer casts

2024-09-23 Thread Julian Waters
I don't think it's a good idea to just patch how a warning works like that, at least not without a controlling option. But more importantly, if my experience with gcc-patches is anything to go by, expect to be ignored for weeks or months before someone even notices your patch best regards, Julian

Re: [Mingw-w64-public] [PATCH 2/2] crt: Add (void(*)(void)) casts to silence warnings about function pointer casts

2024-09-23 Thread LIU Hao
在 2024-09-23 19:18, Hannes Domani via Mingw-w64-public 写道: Note that it's also possible to patch gcc to ignore function casts involving FARPROC types, that's what I did in my gcc build: From: Hannes Domani Date: Sun, 28 Mar 2021 14:35:56 +0200 Subject: [PATCH] Don't warn for function casts inv

Re: [Mingw-w64-public] [PATCH 2/2] crt: Add (void(*)(void)) casts to silence warnings about function pointer casts

2024-09-23 Thread Hannes Domani via Mingw-w64-public
Am Montag, 23. September 2024 um 13:10:23 MESZ hat LIU Hao Folgendes geschrieben: > 在 2024-09-23 18:48, Martin Storsjö 写道: > > Well, as Liu Hao showed, using (void*) casts can get warned about, if we > > compile it with all > > available warning flags. But we don't build mingw-w64-crt that way

Re: [Mingw-w64-public] [PATCH 2/2] crt: Add (void(*)(void)) casts to silence warnings about function pointer casts

2024-09-23 Thread LIU Hao
在 2024-09-23 18:48, Martin Storsjö 写道: Well, as Liu Hao showed, using (void*) casts can get warned about, if we compile it with all available warning flags. But we don't build mingw-w64-crt that way. Anyway, Liu Hao, you mentioned that you wanted to try to touch up this patch in some way (movin

Re: [Mingw-w64-public] [PATCH 2/2] crt: Add (void(*)(void)) casts to silence warnings about function pointer casts

2024-09-23 Thread Martin Storsjö
On Wed, 18 Sep 2024, Jacek Caban wrote: On 18.09.2024 16:16, LIU Hao wrote: Maybe, but in practice it's pretty well defined behavior. Yes; my suggestion about casting via `intptr_t` also just happens to work in practice. So far there are two compilers

Re: [Mingw-w64-public] [PATCH 2/2] crt: Add (void(*)(void)) casts to silence warnings about function pointer casts

2024-09-23 Thread Martin Storsjö
On Wed, 18 Sep 2024, LIU Hao wrote: 在 2024-09-18 21:02, Martin Storsjö 写道: Hmm, can you give a godbolt example or similar, for where the compilers diverge about warnings here? With Clang, I don't seem to be able to get any warnings for either casts via (void(*)(void)) or (void*), with either

Re: [Mingw-w64-public] [PATCH 1/2] crt: Mark _wassert with __MINGW_ATTRIB_NORETURN

2024-09-23 Thread Martin Storsjö
On Wed, 18 Sep 2024, Jacek Caban wrote: On 18.09.2024 14:06, Martin Storsjö wrote: This avoids warnings from Clang, pointing out that this function could be marked noreturn. --- mingw-w64-crt/misc/wassert.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mingw-w64-crt/misc/wassert.c b/mi

[Mingw-w64-public] [PATCH] winpthreads: Add missing `__stdcall` on lazy-binding function pointers

2024-09-23 Thread LIU Hao
-- Best regards, LIU Hao From c919cf160b5658b96ce808020dc08bc3905a78e1 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Mon, 23 Sep 2024 16:32:55 +0800 Subject: [PATCH] winpthreads: Add missing `__stdcall` on lazy-binding function pointers Signed-off-by: LIU Hao --- mingw-w64-libraries/winpthre

Re: [Mingw-w64-public] License of MinGW-w64 DLLs that comes with Cygwin installed mingw package?

2024-09-23 Thread Michele Locati
Thank you, Hao! I spent half an hour looking for that file, and it was right under my nose! I don't know if this is the right place for this request, but I think it'd be useful to include that file in the cygwin packages, Thank you again, Michele Il giorno lun 23 set 2024 alle ore 03:48 LIU Hao