Re: [Mingw-w64-public] [PATCH 1/4] headers: Fix compile warning: FACILITY_VISUALCPP redefined

2024-07-30 Thread Pali Rohár
On Wednesday 31 July 2024 11:19:40 LIU Hao wrote: > 在 2024-07-31 00:37, Pali Rohár 写道: > > Well, I do not know. I have just looked at different versions of > > delayimp.h and winerror.h header files available on internet and always > > they were present in some SDK folder. So I though that are part

Re: [Mingw-w64-public] [PATCH 1/4] headers: Fix compile warning: FACILITY_VISUALCPP redefined

2024-07-30 Thread LIU Hao
在 2024-07-31 00:37, Pali Rohár 写道: Well, I do not know. I have just looked at different versions of delayimp.h and winerror.h header files available on internet and always they were present in some SDK folder. So I though that are part of SDK. Normally people install all headers files which comes

Re: [Mingw-w64-public] [PATCH 1/4] headers: Fix compile warning: FACILITY_VISUALCPP redefined

2024-07-30 Thread Pali Rohár
On Tuesday 30 July 2024 23:53:47 LIU Hao wrote: > 在 2024-07-29 02:58, Pali Rohár 写道: > > Warning is: > > > > In file included from misc/delay-f.c:11: > > mingw-w64-headers/include/delayimp.h:64: warning: "FACILITY_VISUALCPP" > > redefined > > #define FACILITY_VISUALCPP ((LONG)0x6d

Re: [Mingw-w64-public] [PATCH 0/4] Fix compile warnings

2024-07-30 Thread LIU Hao
在 2024-07-29 02:58, Pali Rohár 写道: In file included from libsrc/wspiapi/WspiapiLoad.c:7: libsrc/wspiapi/WspiapiLoad.c: In function ‘WspiapiLoad’: mingw-w64-headers/include/wspiapi.h:50:20: warning: cast between incompatible function types from ‘void (__attribute__((stdcall)) *)(struct addrinfo *

Re: [Mingw-w64-public] [PATCH 1/4] headers: Fix compile warning: FACILITY_VISUALCPP redefined

2024-07-30 Thread LIU Hao
在 2024-07-29 02:58, Pali Rohár 写道: Warning is: In file included from misc/delay-f.c:11: mingw-w64-headers/include/delayimp.h:64: warning: "FACILITY_VISUALCPP" redefined #define FACILITY_VISUALCPP ((LONG)0x6d) In file included from mingw-w64-headers/include/winbase.h:2817,

Re: [Mingw-w64-public] Small mistake I spotted, incorrect usage of _WIN32_WINNT

2024-07-30 Thread LIU Hao
在 2024-07-23 04:11, Paul Jackson 写道: File: minwinbase.h Line: 161 Code: #if _WIN32_WINNT >= 0x0A02 FileDispositionInfoEx, FileRenameInfoEx, #endif _WIN32_WINNT max value is 0x0A00, it surely meant to be NTDDI_VERSION. It was fixed in 837c48d49611f78878fe2cfd1daf8ab0bf73ba16 two

Re: [Mingw-w64-public] [PATCH 8/8] crt: Move strnlen from libmingwex.a to individual CRT import libraries

2024-07-30 Thread Martin Storsjö
On Sat, 27 Jul 2024, Pali Rohár wrote: POSIX strnlen symbol is natively available since msvcr80 and also in all ARM versions of msvcrt.dll. --- mingw-w64-crt/Makefile.am | 10 +- .../lib-common/api-ms-win-crt-string-l1-1-0.def| 2 +- mingw-w64-crt/lib-