Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-03-03 Thread Martin Storsjö
On Sun, 3 Mar 2024, Pali Rohár wrote: On Sunday 03 March 2024 23:38:57 Martin Storsjö wrote: On Sun, 3 Mar 2024, Pali Rohár wrote: Ok, do you need me to resend this patch? Or would you fix this one missing semicolon during applying patch? I can fix the missing semicolon. And... I do not k

Re: [Mingw-w64-public] [PATCH] Use rand_s in mkstemp function

2024-03-03 Thread Martin Storsjö
Hi, On Mon, 4 Mar 2024, Mateusz Mikuła wrote: rand is not random enough and may lead to clashing temporary directories with multiple parallel link processes as it was observed on Rust's CI. It can be reproduced with these commands (run them all in without long pauses): for n in {1..15000}; d

Re: [Mingw-w64-public] [PATCH] Use rand_s in mkstemp function

2024-03-03 Thread LIU Hao
在 2024-03-04 08:04, Mateusz Mikuła 写道: -template_name[j] = letters[rand () % 62]; +if (rand_s (&r)) return -1; +template_name[j] = letters[r % 62]; Does it make sense that if `rand_s()` fails, use `rand()` as a fallback? We have a custom implementation of `r

[Mingw-w64-public] [PATCH] Use rand_s in mkstemp function

2024-03-03 Thread Mateusz Mikuła
rand is not random enough and may lead to clashing temporary directories with multiple parallel link processes as it was observed on Rust's CI. It can be reproduced with these commands (run them all in without long pauses): for n in {1..15000}; do rm -f lib/libLLVMAVRAsmParser.a && \ ar qc lib/l

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-03-03 Thread Pali Rohár
On Sunday 03 March 2024 23:38:57 Martin Storsjö wrote: > On Sun, 3 Mar 2024, Pali Rohár wrote: > > > Ok, do you need me to resend this patch? Or would you fix this one > > missing semicolon during applying patch? > > I can fix the missing semicolon. > > > And... I do not know how to better write

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-03-03 Thread Martin Storsjö
On Sun, 3 Mar 2024, Pali Rohár wrote: Ok, do you need me to resend this patch? Or would you fix this one missing semicolon during applying patch? I can fix the missing semicolon. And... I do not know how to better write the commit message, so I would be happy if give me example of how to rep

Re: [Mingw-w64-public] [PATCH] crt: Fix comments in msvcrt-common.def.in

2024-03-03 Thread Pali Rohár
On Thursday 29 February 2024 10:16:47 Martin Storsjö wrote: > On Thu, 29 Feb 2024, Pali Rohár wrote: > > > On Wednesday 28 February 2024 23:24:25 Martin Storsjö wrote: > > > On Wed, 28 Feb 2024, Pali Rohár wrote: > > > > > > > All commented lines refers to non-underscore aliases for underscored >