Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/onecore_apiset.mri | 1 +
mingw-w64-crt/lib-common/wpprecorderum.def | 8
mingw-w64-crt/lib32/wpprecorderum.def | 8
4 files changed, 18 insertions(+)
create mod
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/windowscoreheadless_apiset.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 766c37b99..e87d44a32 100644
--
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am| 1 +
mingw-w64-crt/lib-common/onecore.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index e87d44a32..eed7bac1b 100644
--- a/mingw-w64-crt/Makefile.am
+++ b/mi
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/onecore_apiset.mri | 1 +
mingw-w64-crt/lib-common/profapi.def| 21 +
mingw-w64-crt/lib32/profapi.def | 21 +
4 files changed
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am| 1 +
mingw-w64-crt/lib-common/onecore.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 6b1d5b2b7..78bc8fde1 100644
--- a/mingw-w64-crt/Makefile.am
+++ b/mi
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/windowscoreheadless_apiset.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index c87724cf5..6b1d5b2b7 100644
--
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/{libarm32 => lib-common}/windows.networking.def | 1 -
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/windows.networking.def| 3 +++
mingw-w64-crt/lib64/Makefile.am
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/windowscoreheadless_apiset.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 4b2ba4c0c..34c3cde43 100644
--
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 3 ++-
mingw-w64-crt/lib-common/windowsapp.mri | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index fb3c96918..4b2ba4c0c 100644
--- a/mingw-w64-c
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/{libarm32 => lib-common}/windows.data.pdf.def | 0
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/windows.data.pdf.def| 3 +++
mingw-w64-crt/lib64/Makefile.am |
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/windowscoreheadless_apiset.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 564496545..fb3c96918 100644
--
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 3 ++-
mingw-w64-crt/lib-common/windowsapp.mri | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index f740f072b..564496545 100644
--- a/mingw-w64-c
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/{libarm32 => lib-common}/rometadata.def | 0
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/rometadata.def| 3 +++
mingw-w64-crt/lib64/Makefile.am | 1 +
mingw-w64-crt/libar
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/windowscoreheadless_apiset.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index f2fb0864a..f740f072b 100644
--
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/windowsapp.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index d14e12258..f2fb0864a 100644
--- a/mingw-w64-crt/Makefile.am
++
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 3 ++-
mingw-w64-crt/lib-common/windowsapp.mri | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 9a914e16a..f233cde6d 100644
--- a/mingw-w64-c
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/windows.ai.machinelearning.def | 5 +
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/windows.ai.machinelearning.def | 5 +
mingw-w64-crt/lib64/Makefile.am | 1 +
min
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/windowscoreheadless_apiset.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index f233cde6d..d14e12258 100644
--
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/inkobjcore.def | 34 +
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/inkobjcore.def | 34 +
mingw-w64-crt/lib64/Makefile.am | 1 +
mingw-w64-crt/libarm32/
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am | 1 +
mingw-w64-crt/lib-common/windowscoreheadless_apiset.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index 07c386197..9a914e16a 100644
--
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/hrtfapo.def | 9 +
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/hrtfapo.def | 9 +
mingw-w64-crt/lib64/Makefile.am | 1 +
mingw-w64-crt/libarm32/Makefile.am | 1 +
mingw-w64-crt/libarm64/Make
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/dxcore.def | 5 +
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/dxcore.def | 5 +
mingw-w64-crt/lib64/Makefile.am | 1 +
mingw-w64-crt/libarm32/Makefile.am | 1 +
mingw-w64-crt/libarm64/Makefile.am | 1
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/dnsperf.def | 7 +++
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/dnsperf.def | 7 +++
mingw-w64-crt/lib64/Makefile.am | 1 +
mingw-w64-crt/libarm32/Makefile.am | 1 +
mingw-w64-crt/libarm64/Makefile
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/Makefile.am| 1 +
mingw-w64-crt/lib-common/nanosrv.mri | 1 +
2 files changed, 2 insertions(+)
diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
index b50eac77b..07c386197 100644
--- a/mingw-w64-crt/Makefile.am
+++ b/mi
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/directml.def | 6 ++
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib32/directml.def | 6 ++
mingw-w64-crt/lib64/Makefile.am | 1 +
mingw-w64-crt/libarm32/Makefile.am| 1 +
mingw-w64-crt/libarm64/Makef
On 4/12/23 13:13, Martin Storsjö wrote:
When I browsed through the diff of symbols vs MSVC, I noted that
api-ms-win-core-windowserrorreporting-l1-1-0 differs a lot for onecore; we
don't have a single one of the symbols for this DLL that MSVC's onecore has,
and conversely, none of the symbols t
On Mon, 4 Dec 2023, Antonin Décimo wrote:
Binutils' windres uses the C preprocessor and gets MinGW pre-defined
macros, whereas te Microsoft tool RC [1] implements its own C
preprocessor and doesn't call MSVC, so it defines a subset of the
macros.
[1]: https://learn.microsoft.com/en-us/windows/w
On Mon, 4 Dec 2023, Antonin Décimo wrote:
- Force a reference to _tls_used to make the linker create the TLS
directory if it's not already there. (e.g. if __declspec(thread) is
not used).
- Force a reference to __xl_f to prevent whole program optimization
from discarding the variable.
- On x
On Mon, 4 Dec 2023, Antonin Décimo wrote:
Second version of the patch series improving support for MSVC, fixing
little bugs and compiler warnings.
Thanks to all the reviewers of the first version, let me know if
there's anything I can improve.
Thanks! The updated patchset looks mostly good to
Microsoft considers POSIX function names to be deprecated, and
provides alternative names starting with an underscore. A deprecation
warning is raised if the old names are used, which can be disabled
with the _CRT_NONSTDC_NO_WARNINGS macro.
https://learn.microsoft.com/en-us/cpp/error-messages/comp
Retain the old name for backwards compatibility.
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/include/pthread.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mingw-w64-libraries/winpthreads/include/pthread.h
b/mingw-w64-libraries/winpthreads/include/
https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#tls-callback-functions
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/src/thread.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/mingw-w64-libraries/winpthreads/src/thread.c
b/mingw-w
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/src/clock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mingw-w64-libraries/winpthreads/src/clock.c
b/mingw-w64-libraries/winpthreads/src/clock.c
index 322b7e5c4..db8b34ea5 100644
--- a/mingw-w64-librar
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/configure | 117 ++
1 file changed, 11 insertions(+), 106 deletions(-)
diff --git a/mingw-w64-libraries/winpthreads/configure
b/mingw-w64-libraries/winpthreads/configure
index 22b955cd4..da002e7cb 100755
--- a
As DWORD is a typedef for unsigned long, we can use the %lu format
specifier. The %p format specifier requires (void *) pointers.
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/src/cond.c | 6 +++---
mingw-w64-libraries/winpthreads/src/rwlock.c | 6 +++---
mingw-w64-librar
This particular snippet raises an annoying MSVC warning, C4706.
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4706?view=msvc-170
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/src/barrier.c | 6 +++---
mingw-w64-libraries/win
- remove superflous semicolons;
- avoid dead code warnings;
- avoid function redeclaration with an added 'dllexport' attribute.
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/src/sem.c| 4 ++--
mingw-w64-libraries/winpthreads/src/thread.c | 5 +++--
mingw-w64-libraries/win
Interestingly, pthread_cleanup_push/pop are allowed by POSIX to be
implemented as macros opening and closing an lexical scope. By using
the well-known trick of do { ... } while (0) [1], we prevent potential
scoping issues in surrounding code when the macro is expanded.
Removing the comma operator
Binutils' windres uses the C preprocessor and gets MinGW pre-defined
macros, whereas te Microsoft tool RC [1] implements its own C
preprocessor and doesn't call MSVC, so it defines a subset of the
macros.
[1]: https://learn.microsoft.com/en-us/windows/win32/menurc/resource-compiler
Signed-off-by:
MSVC warns [1] against relative path in include directives, and
semaphore.h is already in the include path.
warning C4464: relative include path contains '..'
[1]:
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4464?view=msvc-170
windows.h i
https://learn.microsoft.com/en-us/cpp/intrinsics/assume?view=msvc-170
Signed-off-by: Antonin Décimo
---
Compared to v1, this patch introduces an UNREACHABLE() macro that
expands to builtins for GCC, clang(-cl), and MSVC.
mingw-w64-libraries/winpthreads/src/misc.h | 6 ++
mingw-w64-librari
A classic idiom preventing all kinds of bad interactions with
surrounding code when the macro is expanded. Newer compilers may also
warn against empty statements of the form
{ expressions... };
where the ending ; is actually an empty statement.
https://gcc.gnu.org/onlinedocs/cpp/Swallowing-t
Signed-off-by: Antonin Décimo
---
Compared to v1, the regenerated configure script was taken out of the
patch, and changes to version.rc moved to a separate patch.
.../winpthreads/build-aux/windres-rc | 158 ++
mingw-w64-libraries/winpthreads/configure.ac | 8 +-
2 f
Previous code was too complex and hard to understand, and snprintf
fits the job nicely.
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/src/thread.c | 21
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/mingw-w64-libraries/winpthreads/src/thr
Fixes a warning from libtoolize: 'AC_PROG_RANLIB' is rendered obsolete
by 'LT_INIT'.
Signed-off-by: Antonin Décimo
---
Compared to v1, the regenerated configure script was taken out of the
patch.
mingw-w64-libraries/winpthreads/configure.ac | 1 -
1 file changed, 1 deletion(-)
diff --git a/mi
Prevents a warning of `r` being shadowed, and makes the code clearer.
Signed-off-by: Antonin Décimo
---
mingw-w64-libraries/winpthreads/src/rwlock.c | 6 +-
mingw-w64-libraries/winpthreads/src/rwlock.h | 3 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/mingw-w64-librarie
Signed-off-by: Antonin Décimo
---
Compared to v1, this patch doesn't provide a definition of
likely/unlikely for compilers other that GCC, clang(-cl), or MSVC.
mingw-w64-libraries/winpthreads/src/misc.h | 8
mingw-w64-libraries/winpthreads/src/mutex.c| 3 ---
mingw-w64-librarie
Signed-off-by: Antonin Décimo
---
Compared to v1, this patch now ignores more Autotools-generated files.
.gitignore | 4
1 file changed, 4 insertions(+)
diff --git a/.gitignore b/.gitignore
index 4cd47565a..3d1022348 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,13 +12,17 @@
*.lo
*.la
Second version of the patch series improving support for MSVC, fixing
little bugs and compiler warnings.
Thanks to all the reviewers of the first version, let me know if
there's anything I can improve.
Antonin Décimo (20):
winpthreads: Ignore MSVC object files and Autotools generated files
wi
- Force a reference to _tls_used to make the linker create the TLS
directory if it's not already there. (e.g. if __declspec(thread) is
not used).
- Force a reference to __xl_f to prevent whole program optimization
from discarding the variable.
- On x86, symbols are prefixed with an underscor
On Sun, 26 Nov 2023, Mark Harmstone wrote:
Note that the DLL name is chakra.dll, but unusually the library name is
chakrart.
Signed-off-by: Mark Harmstone
---
mingw-w64-crt/lib-common/chakrart.def | 124 ++
mingw-w64-crt/lib32/Makefile.am | 1 +
mingw-w64-crt/lib3
On Mon, 4 Dec 2023, Martin Storsjö wrote:
On Thu, 23 Nov 2023, Mark Harmstone wrote:
Note that this isn't yet exhaustive. Notably the official versions of
onecore, onecoreuap, and windowscoreheadless all include cut-down
versions of user32 etc., which I'm going to handle with a later patch.
S
On Mon, 4 Dec 2023, LIU Hao wrote:
在 2023/12/4 21:14, Martin Storsjö 写道:
Signed-off-by: Martin Storsjö
---
.../{lib64 => lib-common}/dhcpcsvc6.def | 0
mingw-w64-crt/libarm32/dhcpcsvc6.def | 29 ---
mingw-w64-crt/libarm64/Makefile.am| 1 +
3 fi
在 2023/12/4 21:14, Martin Storsjö 写道:
Signed-off-by: Martin Storsjö
---
.../{lib64 => lib-common}/dhcpcsvc6.def | 0
mingw-w64-crt/libarm32/dhcpcsvc6.def | 29 ---
mingw-w64-crt/libarm64/Makefile.am| 1 +
3 files changed, 1 insertion(+), 29 delet
在 2023/12/4 21:14, Martin Storsjö 写道:
Signed-off-by: Martin Storsjö
---
.../{lib64 => lib-common}/dhcpcsvc6.def | 0
mingw-w64-crt/libarm32/dhcpcsvc6.def | 29 ---
mingw-w64-crt/libarm64/Makefile.am| 1 +
3 files changed, 1 insertion(+), 29 delet
Signed-off-by: Martin Storsjö
---
.../{lib64 => lib-common}/dhcpcsvc6.def | 0
mingw-w64-crt/libarm32/dhcpcsvc6.def | 29 ---
mingw-w64-crt/libarm64/Makefile.am| 1 +
3 files changed, 1 insertion(+), 29 deletions(-)
rename mingw-w64-crt/{lib64 => lib-
On Thu, 23 Nov 2023, Mark Harmstone wrote:
Note that this isn't yet exhaustive. Notably the official versions of
onecore, onecoreuap, and windowscoreheadless all include cut-down
versions of user32 etc., which I'm going to handle with a later patch.
Signed-off-by: Mark Harmstone
---
mingw-w64-
On Mon, 4 Dec 2023, Antonin Décimo wrote:
I'm almost ready to submit v2 of this patch series. Should I add
Reviewed-by tags for patches that were discussed on the list? or links
to email threads?
I don't think it's necessary with links to previous discussions (this is a
rather low-volume mai
I'm almost ready to submit v2 of this patch series. Should I add
Reviewed-by tags for patches that were discussed on the list? or links
to email threads?
Thanks.
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sour
59 matches
Mail list logo
