Re: [Mingw-w64-public] [PATCH] crt: Implement __gets_chk

2023-02-13 Thread Martin Storsjö
On Mon, 13 Feb 2023, LIU Hao wrote: 在 2023-02-13 06:13, Martin Storsjö 写道: When a subset of ssp functions were implemented in 7478c20848f60e6238547db63d1a5bc450d468cc, only functions that were referenced with _FORTIFY_SOURCE were added. This set of functions accidentally missed __gets_chk, whic

Re: [Mingw-w64-public] [PATCH] headers: _FORTIFY_SOURCE: Add [v]s[n]printf() for UCRT

2023-02-13 Thread Martin Storsjö
On Sun, 12 Feb 2023, Christian Franke wrote: Still missing after this patch: [v]s[n]wprintf() for UCRT and MSVCRT. -- +#ifdef __MINGW_FORTIFY_VA_ARG This bit should be #if, not #ifdef. Other than that, the patch seemed fine to me, so I pushed it, with that issue fixed. Thanks! // Marti

Re: [Mingw-w64-public] [PATCH] crt: Implement __gets_chk

2023-02-13 Thread Christian Franke
LIU Hao wrote: Side note: I am a bit curious how this function is supposed to be useful. Generally speaking `get()` should never be used. __gets_chk() may (only) be useful to fortify very old code. From the C/C++ standards point of view, the gets() prototype should be disabled if C11 or C++

Re: [Mingw-w64-public] [PATCH] crt: Implement __gets_chk

2023-02-13 Thread LIU Hao
在 2023-02-13 06:13, Martin Storsjö 写道: When a subset of ssp functions were implemented in 7478c20848f60e6238547db63d1a5bc450d468cc, only functions that were referenced with _FORTIFY_SOURCE were added. This set of functions accidentally missed __gets_chk, which we do reference if fortification is

Re: [Mingw-w64-public] [PATCH] headers: Fix ambigous declaration of the LeaseObtained and LeaseExpires fields of the IP_ADAPTER_INFO structure in iptypes.h

2023-02-13 Thread LIU Hao
在 2023-02-12 22:13, Mateusz Wajchęprzełóż 写道: The LeaseObtained and LeaseExpires fields of the IP_ADAPTER_INFO structure are declared as time_t, which on 32-bit target can be either 32-bit or 64-bit, but the 32-bit version of the GetAdaptersInfo function requires these fields to be 32-bit. MSDN