Re: [Mingw-w64-public] [PATCH] crt: Use only __ImageBase symbol in mingw-w64 code

2022-11-19 Thread Pali Rohár
On Saturday 19 November 2022 11:53:28 Pali Rohár wrote: > On Saturday 19 November 2022 17:12:12 LIU Hao wrote: > > 在 2022-11-18 23:40, Pali Rohár 写道: > > > GNU LD provides __ImageBase symbol since 2.19. This is standard windows > > > symbol and should be used instead of custom gnu _image_base__ sym

Re: [Mingw-w64-public] [PATCH] crt: Use only __ImageBase symbol in mingw-w64 code

2022-11-19 Thread Mateusz Mikuła
On Sat., 19 Nov 2022 11:54 Pali Rohár wrote: > On Saturday 19 November 2022 17:12:12 LIU Hao wrote: > > 在 2022-11-18 23:40, Pali Rohár 写道: > > > GNU LD provides __ImageBase symbol since 2.19. This is standard windows > > > symbol and should be used instead of custom gnu _image_base__ symbol. > >

Re: [Mingw-w64-public] [PATCH] crt: Use only __ImageBase symbol in mingw-w64 code

2022-11-19 Thread Pali Rohár
On Saturday 19 November 2022 17:12:12 LIU Hao wrote: > 在 2022-11-18 23:40, Pali Rohár 写道: > > GNU LD provides __ImageBase symbol since 2.19. This is standard windows > > symbol and should be used instead of custom gnu _image_base__ symbol. > > > > For compatibility with older GNU LD versions, defi

Re: [Mingw-w64-public] [PATCH] crt: Use only __ImageBase symbol in mingw-w64 code

2022-11-19 Thread LIU Hao
在 2022-11-18 23:40, Pali Rohár 写道: GNU LD provides __ImageBase symbol since 2.19. This is standard windows symbol and should be used instead of custom gnu _image_base__ symbol. For compatibility with older GNU LD versions, define __ImageBase as weak alias to _image_base__ symbol. This allows to

Re: [Mingw-w64-public] [PATCH] headers: Add missing marco in synchapi.h

2022-11-19 Thread LIU Hao
在 2022-11-19 03:14, Biswapriyo Nath 写道: I think there should not be any #if condition to mimic the behavior of WinSDK. As _NT_TARGET_VERSION_WIN10_RS4 is not defined, CREATE_WAITABLE_TIMER_HIGH_RESOLUTION exists for all Windows versions. Yeah this is also fair enough. Thanks for the patch. Push

Re: [Mingw-w64-public] [PATCH] crt: Remove unused __ImageBase from crt_handler.c

2022-11-19 Thread LIU Hao
在 2022-11-18 23:38, Pali Rohár 写道: --- mingw-w64-crt/crt/crt_handler.c | 10 -- 1 file changed, 10 deletions(-) Thanks for the patch. Looks good to me. Pushed. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature _