Re: [Mingw-w64-public] [PATCH] winpthreads: provide an import opt-out for downstream dlls

2022-04-29 Thread LIU Hao
在 2022-04-30 01:41, li...@coryfields.com 写道: By defining WINPTHREADS_STATIC, the downstream's dll exports will (correctly) not be affected by pthreads. Signed-off-by: Cory Fields --- mingw-w64-libraries/winpthreads/include/pthread.h | 2 +- mingw-w64-libraries/winpthreads/include/sched.h

[Mingw-w64-public] [PATCH] winpthreads: provide an import opt-out for downstream dlls

2022-04-29 Thread lists
From: Cory Fields When building a libtool lib, libtool automatically defines "-EXPORT_DLL" for objects intended to be linked into a shared library. Applications are then intended to also define "EXPORT_DLL", which has the effect of importing the functions from the exported dll. However, this go

Re: [Mingw-w64-public] [PATCH] headers: Import winrt headers from wine

2022-04-29 Thread LIU Hao
在 2022-04-29 22:24, Biswapriyo Nath 写道: + include/windows.foundation.numerics.idl \ + include/windows.gaming.input.idl \ + include/windows.gaming.input.custom.idl \ + include/windows.gaming.input.forcefeedback This line seems to have been truncated. It doesn't matter however, I can fix it

[Mingw-w64-public] [PATCH] headers: Import winrt headers from wine

2022-04-29 Thread Biswapriyo Nath
From abf175ab1693ca6c6d8c2b6222d49c6287bfee19 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Fri, 29 Apr 2022 19:53:20 +0530 Subject: [PATCH] headers: Import winrt headers from wine Required for SDL2 Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/Makefile.am| 12

Re: [Mingw-w64-public] [PATCH v2] crt: Remove duplicate entries from DEF files

2022-04-29 Thread LIU Hao
在 2022-04-29 22:20, Biswapriyo Nath 写道: Is it possible to add that srcipt in mingw-w64\mingw-w64-headers\testcases folder (or something similar)? Well it would be fine if everyone knew how to use it: https://github.com/lhmouse/asteria -- Best regards, LIU Hao OpenPGP_signature Descript

Re: [Mingw-w64-public] [PATCH v2] crt: Remove duplicate entries from DEF files

2022-04-29 Thread LIU Hao
在 2022-04-29 22:15, LIU Hao 写道: This patch was generated automatically by this script: This script has also detected a duplicate `EnterUmsSchedulingMode` of a conditional one in kernel32.def.in, introduced by 24842d45e025db0d38fa2bbd932b95a83282efa2. -- Best regards, LIU Hao OpenPGP_sig

Re: [Mingw-w64-public] [PATCH v2] crt: Remove duplicate entries from DEF files

2022-04-29 Thread Biswapriyo Nath
Is it possible to add that srcipt in mingw-w64\mingw-w64-headers\testcases folder (or something similar)? ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH v2] crt: Remove duplicate entries from DEF files

2022-04-29 Thread LIU Hao
This patch was generated automatically by this script: ``` #!/usr/bin/env asteria for(var k = 0; k != __varg(); ++k) { var path = __varg(k); std.io.putfln("processing: $1", path); var text = std.filesystem.file_read(path); var old_lines = std.string.explode(text, "\n");

Re: [Mingw-w64-public] [PATCH] crt: Remove duplicate entries from DEF files

2022-04-29 Thread LIU Hao
在 2022-04-29 21:54, LIU Hao 写道: This patch was generated automatically by this script: This patch mistakenly removes some ARM-specific functions. I'll propose a new one. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___

[Mingw-w64-public] [PATCH] crt: Remove duplicate entries from DEF files

2022-04-29 Thread LIU Hao
This patch was generated automatically by this script: ``` #!/usr/bin/env asteria for(var k = 0; k != __varg(); ++k) { var path = __varg(k); std.io.putfln("processing: $1", path); var text = std.filesystem.file_read(path); var old_lines = std.string.explode(text, "\n");

Re: [Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread LIU Hao
在 2022-04-29 20:52, Biswapriyo Nath 写道: 0001 patch also need to be commented instead of removing. I think duplicates may better be removed, as they don't add information, and deleting them doesn't remove information either. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP

Re: [Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread LIU Hao
在 2022-04-29 20:11, Christian Franke 写道: LIU Hao wrote: These patches address the issue mentioned earlier. Regarding patch 0001-...: Attached is a possibly complete list of duplicates within each def file from lib-common: Thank you. I can propose a separate patch for these ones. I am ab

Re: [Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread LIU Hao
在 2022-04-29 20:07, Martin Storsjö 写道: Thank you very much, LGTM! Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net http

Re: [Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread Biswapriyo Nath
0001 patch also need to be commented instead of removing. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread Christian Franke
LIU Hao wrote: These patches address the issue mentioned earlier. Regarding patch 0001-...: Attached is a possibly complete list of duplicates within each def file from lib-common: Generated with: for f in *.def*; do   sed 's,;.*$,,;/^$/d;/^#/d;' "$f" | sort | uniq -d | sed "s,^,$f: ," do

Re: [Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread Martin Storsjö
On Fri, 29 Apr 2022, LIU Hao wrote: 在 2022-04-29 19:51, Martin Storsjö 写道: On Fri, 29 Apr 2022, LIU Hao wrote: These patches address the issue mentioned earlier. LGTM in general. For patch 2/2, can you keep the comment for OpenThreadToken where it was originally (but with your extended com

Re: [Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread LIU Hao
在 2022-04-29 19:51, Martin Storsjö 写道: On Fri, 29 Apr 2022, LIU Hao wrote: These patches address the issue mentioned earlier. LGTM in general. For patch 2/2, can you keep the comment for OpenThreadToken where it was originally (but with your extended comment message) so that it's even cleare

Re: [Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread Martin Storsjö
On Fri, 29 Apr 2022, LIU Hao wrote: These patches address the issue mentioned earlier. LGTM in general. For patch 2/2, can you keep the comment for OpenThreadToken where it was originally (but with your extended comment message) so that it's even clearer, if someone would accidentally try to

[Mingw-w64-public] [PATCH 1/2] crt: Remove duplicate entries from DEF

2022-04-29 Thread LIU Hao
These patches address the issue mentioned earlier. -- Best regards, LIU Hao From c7b56927d22562bc49733bec3748b7fb5d6b4541 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Fri, 29 Apr 2022 18:47:39 +0800 Subject: [PATCH 1/2] crt: Remove duplicate entries from DEF Signed-off-by: LIU Hao --- mingw-

Re: [Mingw-w64-public] Default library order breaks backward compatibility with older versions of Windows

2022-04-29 Thread Christian Franke
LIU Hao wrote: 在 2022-04-28 23:55, Corinna Vinschen 写道: But then again, this seems to be a bug in the w32api import libs, rather than a problem with the toolchain, no? Yes; and similar issues did happen some times before, such as in these commits:   * 68d0e7d551d2e2a5b8a15bdca3f8d15fc097