Re: [Mingw-w64-public] [PATCH] vsbackup.idl: set default value for InitializeForBackup() bstrXML

2022-02-17 Thread Marc-André Lureau
Hi Biswapriyo On Fri, Feb 18, 2022 at 10:15 AM Biswapriyo Nath wrote: > > Opps! I have been caught for my `sed` cheats :) I may have missed many > of those default values. Can I add those defaultvalue() in one patch? > That would be great! thanks __

Re: [Mingw-w64-public] [PATCH] vsbackup.idl: set default value for InitializeForBackup() bstrXML

2022-02-17 Thread Biswapriyo Nath
Opps! I have been caught for my `sed` cheats :) I may have missed many of those default values. Can I add those defaultvalue() in one patch? ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/lis

Re: [Mingw-w64-public] [PATCH] winpthreads: Add a missing (void) in the parameters for pthread_getevent

2022-02-17 Thread LIU Hao
在 2/18/22 00:23, NightStrike 写道: Adding unnecessary spam because of yet another poor choice of clang is not something we should be catering towards. Users can compile with -Wno-strict-prototypes if it bothers them that much. No this is not 'unnecessary'. In C the declaration `void* pthread_

Re: [Mingw-w64-public] [PATCH] winpthreads: Add a missing (void) in the parameters for pthread_getevent

2022-02-17 Thread Ozkan Sezer
On 2/17/22, Martin Storsjö wrote: > On Thu, 17 Feb 2022, NightStrike wrote: > >> On Thu, Feb 17, 2022 at 8:27 AM Martin Storsjö wrote: >>> >>> This avoids warnings if building code including it, with >>> -Wstrict-prototypes. (Latest Clang defaults to enabling this warning >>> by default.) >>> >>>

Re: [Mingw-w64-public] [PATCH] winpthreads: Add a missing (void) in the parameters for pthread_getevent

2022-02-17 Thread Martin Storsjö
On Thu, 17 Feb 2022, NightStrike wrote: On Thu, Feb 17, 2022 at 8:27 AM Martin Storsjö wrote: This avoids warnings if building code including it, with -Wstrict-prototypes. (Latest Clang defaults to enabling this warning by default.) Signed-off-by: Martin Storsjö --- mingw-w64-libraries/win

Re: [Mingw-w64-public] [PATCH] winpthreads: Add a missing (void) in the parameters for pthread_getevent

2022-02-17 Thread Martin Storsjö
On Thu, 17 Feb 2022, NightStrike wrote: On Thu, Feb 17, 2022 at 8:27 AM Martin Storsjö wrote: This avoids warnings if building code including it, with -Wstrict-prototypes. (Latest Clang defaults to enabling this warning by default.) Signed-off-by: Martin Storsjö --- mingw-w64-libraries/win

Re: [Mingw-w64-public] [PATCH] winpthreads: Add a missing (void) in the parameters for pthread_getevent

2022-02-17 Thread NightStrike
On Thu, Feb 17, 2022 at 8:27 AM Martin Storsjö wrote: > > This avoids warnings if building code including it, with > -Wstrict-prototypes. (Latest Clang defaults to enabling this warning > by default.) > > Signed-off-by: Martin Storsjö > --- > mingw-w64-libraries/winpthreads/include/pthread.h | 2

[Mingw-w64-public] [PATCH] winpthreads: Add a missing (void) in the parameters for pthread_getevent

2022-02-17 Thread Martin Storsjö
This avoids warnings if building code including it, with -Wstrict-prototypes. (Latest Clang defaults to enabling this warning by default.) Signed-off-by: Martin Storsjö --- mingw-w64-libraries/winpthreads/include/pthread.h | 2 +- mingw-w64-libraries/winpthreads/src/thread.c | 2 +- 2 files

[Mingw-w64-public] [PATCH] vsbackup.idl: set default value for InitializeForBackup() bstrXML

2022-02-17 Thread marcandre . lureau
From: Marc-André Lureau This fixes the compilation against the QEMU Guest Agent. Signed-off-by: Marc-André Lureau --- mingw-w64-headers/include/vsbackup.h | 2 +- mingw-w64-headers/include/vsbackup.idl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mingw-w64-headers/i

Re: [Mingw-w64-public] [PATCH] crt: Check the return value from MultiByteToWideChar in btowc

2022-02-17 Thread Martin Storsjö
On Thu, 17 Feb 2022, LIU Hao wrote: 在 2/16/22 06:09, Martin Storsjö 写道: If MultiByteToWideChar failed, it could still have overwritten the output variable. Signed-off-by: Martin Storsjö --- mingw-w64-crt/misc/btowc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) LGTM. Tha