Re: [Mingw-w64-public] [PATCH] crt/misc: Make `_{get, set}_errno()` return `EINVAL` in case of errors

2022-01-24 Thread LIU Hao
在 2022-01-25 04:57, Martin Storsjö 写道: LGTM, thanks! Thanks. Pushed now. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.so

Re: [Mingw-w64-public] [PATCH] crt/misc: Make `_{get, set}_errno()` return `EINVAL` in case of errors

2022-01-24 Thread Martin Storsjö
On Mon, 24 Jan 2022, LIU Hao wrote: These shall work in compliance with [1] and [2]. [1] https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/get-errno?view=msvc-170 [2] https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/set-errno?view=msvc-170 Signed-off-by: LIU H

Re: [Mingw-w64-public] [PATCH] crt: Move misc/seterrno.c from src_libmingwex into src_msvcrt32 and src_msvcrt64

2022-01-24 Thread LIU Hao
在 2022-01-24 19:45, Martin Storsjö 写道: Yes, that's probably true - do you feel like you can pick up fixing that? OK. Patch sent. -- Best regards, LIU Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list

[Mingw-w64-public] [PATCH] crt/misc: Make `_{get, set}_errno()` return `EINVAL` in case of errors

2022-01-24 Thread LIU Hao
These shall work in compliance with [1] and [2]. [1] https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/get-errno?view=msvc-170 [2] https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/set-errno?view=msvc-170 Signed-off-by: LIU Hao --- mingw-w64-crt/misc/seterrno.c

Re: [Mingw-w64-public] [PATCH] crt: Remove the x86_64 version of libcrtdll.a

2022-01-24 Thread LIU Hao
在 2022-01-24 19:49, Martin Storsjö 写道: There is no crtdll.dll in x86_64 Windows, and the def file indicates that it's been generated from msvcrt.dll, not crtdll.dll. Signed-off-by: Martin Storsjö --- mingw-w64-crt/Makefile.am | 4 - mingw-w64-crt/lib64/crtdll.def | 853 ---

[Mingw-w64-public] [PATCH] crt: Remove the x86_64 version of libcrtdll.a

2022-01-24 Thread Martin Storsjö
There is no crtdll.dll in x86_64 Windows, and the def file indicates that it's been generated from msvcrt.dll, not crtdll.dll. Signed-off-by: Martin Storsjö --- mingw-w64-crt/Makefile.am | 4 - mingw-w64-crt/lib64/crtdll.def | 853 - 2 files changed, 857 de

Re: [Mingw-w64-public] [PATCH] crt: Move misc/seterrno.c from src_libmingwex into src_msvcrt32 and src_msvcrt64

2022-01-24 Thread Martin Storsjö
On Sat, 22 Jan 2022, LIU Hao wrote: 在 2022-01-21 22:53, Martin Storsjö 写道: The _set_errno function is defined in arm versions of msvcrt.dll, and in all the newer numbered versions of msvcr*.dll, and UCRT. This avoids issues with the recently added _vscprintf in libmsvcrt.a which depends on _se

Re: [Mingw-w64-public] [PATCH] crt: Fix v*scanf functions

2022-01-24 Thread Martin Storsjö
On Sun, 16 Jan 2022, Pali Rohár wrote: Currently v*scanf functions are broken and crash when are called with more than 30 arguments in va_list. This is because va_list v*scanf functions are redirected to variadic *scanf functions and this redirect implemented in scanf.S file has fixed limit for