Re: [Mingw-w64-public] UCRT access() function issue

2021-10-23 Thread Liviu Ionescu
> On 24 Oct 2021, at 01:38, Martin Storsjö wrote: > > ... it's quite uncommon, and GCC sets the define for the workaround itself. These days I got bitten by this issue while rebuilding the arm-none-eabi-gcc 10.3, after upgrading my build environment to GCC 11 & mingw 9 with UCRT. It took me

Re: [Mingw-w64-public] UCRT access() function issue

2021-10-23 Thread Martin Storsjö
On Sat, 23 Oct 2021, Jeremy Drake wrote: On Sat, 23 Oct 2021, Martin Storsjö wrote: On Thu, 8 Apr 2021, Martin Storsjö wrote: I guess the least risky solution would be to enable the "__USE_MINGW_ACCESS" codepath unconditionally if using UCRT - what do you think? (One could also consider to

Re: [Mingw-w64-public] UCRT access() function issue

2021-10-23 Thread Jeremy Drake via Mingw-w64-public
On Sat, 23 Oct 2021, Martin Storsjö wrote: > On Thu, 8 Apr 2021, Martin Storsjö wrote: > > > I guess the least risky solution would be to enable the "__USE_MINGW_ACCESS" > > codepath unconditionally if using UCRT - what do you think? > > > > (One could also consider to change the implementation of

Re: [Mingw-w64-public] UCRT access() function issue

2021-10-23 Thread Martin Storsjö
On Thu, 8 Apr 2021, Martin Storsjö wrote: This used to be an issue with msvcrt.dll too, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33281. However, when I try out your test snippet (extended to test the directory both with and without a trailing slash, and with a regular file) I can't rep

Re: [Mingw-w64-public] [PATCH] crt: duplicate query.def in ntquery.def

2021-10-23 Thread Martin Storsjö
On Sat, 23 Oct 2021, Jeremy Drake via Mingw-w64-public wrote: The attempt to use ntquery.def.in to #include query.def didn't work correctly for lib32. For consistency, duplicate the version in lib-common too. Signed-off-by: Jeremy Drake --- Thanks, pushed. // Martin

[Mingw-w64-public] [PATCH] crt: duplicate query.def in ntquery.def

2021-10-23 Thread Jeremy Drake via Mingw-w64-public
The attempt to use ntquery.def.in to #include query.def didn't work correctly for lib32. For consistency, duplicate the version in lib-common too. Signed-off-by: Jeremy Drake --- mingw-w64-crt/lib-common/ntquery.def| 17 + mingw-w64-crt/lib-common/ntquery.def.in | 1 - ming

Re: [Mingw-w64-public] [PATCH] crt: add libntquery.a import library

2021-10-23 Thread Jeremy Drake via Mingw-w64-public
On Sat, 23 Oct 2021, Martin Storsjö wrote: > On Fri, 22 Oct 2021, Jeremy Drake wrote: > > Comparing libquery.a to libntquery.a shows the latter is missing the > > stdcall decorations. Perhaps the #include trick didn't go so well, and > > it'd be better to just copy the def file (at least for lib3

[Mingw-w64-public] About -mthreads

2021-10-23 Thread Óscar Fuentes
The gcc documentation for -mthreads says: -mthreads Support thread-safe exception handling on MinGW. Programs that rely on thread-safe exception handling must compile and link all code with the -mthreads option. When compiling, -mthreads defines -D_MT;

Re: [Mingw-w64-public] [PATCH] crt: add libntquery.a import library

2021-10-23 Thread Martin Storsjö
On Fri, 22 Oct 2021, Jeremy Drake wrote: On Fri, 22 Oct 2021, Martin Storsjö wrote: On Thu, 21 Oct 2021, Jeremy Drake via Mingw-w64-public wrote: There was a version already present as libquery.a for a couple of arches, but the Windows SDK provides identical libquery.a and libntquery.a, and

Re: [Mingw-w64-public] [PATCH] headers: Import wmsecure.idl from wine

2021-10-23 Thread Biswapriyo Nath
Forgot to add the entry in Makefile.am. Here is the fixed one. From ef1df3e7f3cb28e98f9f93f13e9c7f214eccfde7 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Sat, 23 Oct 2021 11:37:07 +0530 Subject: [PATCH] headers: Import wmsecure.idl from wine Signed-off-by: Biswapriyo Nath --- mingw-w64-