Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-06 Thread Martin Storsjö
On Mon, 6 Sep 2021, Patrick Northon wrote: Yes the indentation is funky because the original has one level with a tab character and spaces for the rest in some parts. I see you have submitted a patch to fix this. Yes - hopefully someone will approve it soon, and I'd land it, then you can reap

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-06 Thread Patrick Northon via Mingw-w64-public
On lundi 6 septembre 2021 06 h 59 min 40 s EDT Martin Storsj? wrote: > But I feel a little uneasy about the patch - why would we unconditionally > do a "value.__pformat_fpreg_exponent -= 3;" at the start of > __pformat_emit_xfloat? I don't see the corresponding adjustment in > __pformat_xldouble fo

Re: [Mingw-w64-public] contributions

2021-09-06 Thread Zach Bacon
I'm pretty sure mingw-w64 is going for more with windows compatibility than POSIX compatibility, so having functions like that wouldn't be in line with the project where as cygwin is the project that allows you to use full POSIX implementation within windows in a specific environment, things like p

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-06 Thread Patrick Northon via Mingw-w64-public
On lundi 6 septembre 2021 06 h 59 min 40 s EDT Martin Storsj? wrote: > On Sun, 5 Sep 2021, Patrick Northon via Mingw-w64-public wrote: > > Hi, here's a patch to fix another problem with formatting long doubles in > > > hexadecimal. I found a failing case with a denormalized value: > Thanks for the

Re: [Mingw-w64-public] contributions

2021-09-06 Thread Glenn Burkhardt
"Use Cygwin if you need symlink support" Really, why would I be interested in using Cygwin when I have my own implementations of these functions for MinGW? On 9/5/2021, 9:53 PM, JonY wrote: Use Cygwin if you need symlink support, mingw-w64 isn't the place to introduce new API implementations

Re: [Mingw-w64-public] contributions

2021-09-06 Thread Glenn Burkhardt
"mingw-w64 isn't the place to introduce new API implementations." symlink, realpath, readlink, lstat, link are all POSIX.1-2001 functions.  Why do you say "new API implementations"?  They are missing from MinGW-w64, and, I believe, should be made available. And I'd also like to see clock_nano

Re: [Mingw-w64-public] [PATCH] Fix exponent when formatting long double in hexadecimal.

2021-09-06 Thread Martin Storsjö
On Sun, 5 Sep 2021, Patrick Northon via Mingw-w64-public wrote: Hi, here's a patch to fix another problem with formatting long doubles in hexadecimal. I found a failing case with a denormalized value: Thanks for the patch and testcase! Git didn't manage to automatically apply your patch and n

[Mingw-w64-public] [PATCH] crt: Expand mixed tabs/space indentation in mingw_pformat.c to plain spaces

2021-09-06 Thread Martin Storsjö
This makes it easier to edit the file across varying editors etc. Signed-off-by: Martin Storsjö --- mingw-w64-crt/stdio/mingw_pformat.c | 1614 +-- 1 file changed, 807 insertions(+), 807 deletions(-) diff --git a/mingw-w64-crt/stdio/mingw_pformat.c b/mingw-w64-crt/stdio