Re: [Mingw-w64-public] [PATCH] wtypes.h: replace #include <...> with #include "..." for rpc

2021-08-30 Thread Jonathan Marler
Ping. The issue that this fixes is easy to reproduce. Just try to compile any project with the mingw headers and add a file named "rpc.h" to one of your local include directories and you'll get a bunch of errors related to missing definitions. The 2-line patch attached to my previous message sho

Re: [Mingw-w64-public] [PATCH] headers: Add headers for host compute system APIs

2021-08-30 Thread LIU Hao
在 2021-08-31 00:07, NightStrike 写道: I only mentioned function parameters Yes; there is no need to uglify them, because they are unreferenced by standard headers. Keeping them the same with Windows SDK should be reasonably fine. -- Best regards, LIU Hao OpenPGP_signature Description: Op

Re: [Mingw-w64-public] [PATCH] headers: Add headers for host compute system APIs

2021-08-30 Thread NightStrike
On Mon, Aug 30, 2021 at 8:59 AM LIU Hao wrote: > > 在 8/30/21 2:42 PM, NightStrike 写道: > > > > All of those function parameters need to be uglified or removed. I > > personally prefer removing them when they provide no additional > > context. Example: > > > > struct timespec * ts << "ts" is redun

Re: [Mingw-w64-public] [PATCH] headers: Add headers for host compute system APIs

2021-08-30 Thread LIU Hao
在 8/30/21 2:42 PM, NightStrike 写道: All of those function parameters need to be uglified or removed. I personally prefer removing them when they provide no additional context. Example: struct timespec * ts << "ts" is redundant here int timespec << assuming it is such a thing, here, the variabl

Re: [Mingw-w64-public] [PATCH] headers: Add headers for host compute system APIs

2021-08-30 Thread NightStrike
It's required by the language standard. On Sun, Aug 29, 2021, 23:03 Biswapriyo Nath wrote: > IMHO, I don't see any proper reason to "uglify" every header file. Some > issues: > 1. If parameters are removed the function declarations will look cryptic. > 2. If I want to see a function prototype qu

Re: [Mingw-w64-public] [PATCH] headers: Add headers for host compute system APIs

2021-08-30 Thread Biswapriyo Nath
IMHO, I don't see any proper reason to "uglify" every header file. Some issues: 1. If parameters are removed the function declarations will look cryptic. 2. If I want to see a function prototype quickly without opening a web browser header files are handy at that time. 3. If there is any wrong in c