Re: [Mingw-w64-public] [PATCH] genpeimg: fix mistaken section header size.

2021-08-17 Thread Martin Storsjö
On Tue, 17 Aug 2021, Jeremy Drake via Mingw-w64-public wrote: On Tue, 17 Aug 2021, Martin Storsjö wrote: LGTM. Am I understanding correctly that the difference here isn't visible in the current use of the tool (i.e. there's no buggy behaviour to be observed yet, and there's no other bug that c

Re: [Mingw-w64-public] [PATCH] genpeimg: fix mistaken section header size.

2021-08-17 Thread Jeremy Drake via Mingw-w64-public
On Tue, 17 Aug 2021, Martin Storsjö wrote: > LGTM. Am I understanding correctly that the difference here isn't visible in > the current use of the tool (i.e. there's no buggy behaviour to be observed > yet, and there's no other bug that could be piled on top of this, relying on > the incorrect val

Re: [Mingw-w64-public] [PATCH] crt: Remove a duplicate crt0_w.o from libmingw32.a

2021-08-17 Thread Martin Storsjö
On Mon, 16 Aug 2021, Jonathan Yong wrote: On 8/16/21 12:56 PM, Martin Storsjö wrote: Signed-off-by: Martin Storsjö --- mingw-w64-crt/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index 2d33e1a09..78d9a0a

Re: [Mingw-w64-public] [PATCH] crt: Pass --temp-prefix to dlltool, if supported

2021-08-17 Thread Martin Storsjö
On Mon, 16 Aug 2021, JonY via Mingw-w64-public wrote: On 8/16/21 12:42 PM, Martin Storsjö wrote: When GNU dlltool generates import libraries, it picks a semi-random prefix string for its file names based on the pid of the process. Normally, the prefix doesn't matter much, but when we merge mult

Re: [Mingw-w64-public] [PATCH] genpeimg: fix mistaken section header size.

2021-08-17 Thread Martin Storsjö
On Mon, 16 Aug 2021, Jeremy Drake via Mingw-w64-public wrote: According to Microsoft docs and observation of real images, section headers are 40 bytes, not 36. Signed-off-by: Jeremy Drake --- mingw-w64-tools/genpeimg/src/img.h| 2 +- mingw-w64-tools/genpeimg/src/img_pe.c | 2 +- 2 files chan