Re: [Mingw-w64-public] [PATCH 2/2] include/process: Declare `quick_exit()` here too

2021-05-21 Thread Liu Hao
在 5/22/21 1:41 PM, Martin Storsjö 写道: Both patches look good to me, thanks! Thanks. Pushed to master. -- Best regards, Liu Hao OpenPGP_signature Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sou

Re: [Mingw-w64-public] [PATCH 2/2] include/process: Declare `quick_exit()` here too

2021-05-21 Thread Martin Storsjö
On Sat, 22 May 2021, Liu Hao wrote: -- Best regards, Liu Hao Both patches look good to me, thanks! // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] crt/stdlib: Add `quick_exit()` and `at_quick_exit()` for UCRT

2021-05-21 Thread Liu Hao
在 2021-05-22 00:30, Christoph Reiter 写道: It compiles and runs fine, but gcc still fails to build with current master with the same error. Both on CI and locally. Ah, I see. It's because either or is included before . I have sent two additional patches to address this issue. -- Best regard

[Mingw-w64-public] [PATCH 2/2] include/process: Declare `quick_exit()` here too

2021-05-21 Thread Liu Hao
-- Best regards, Liu Hao From 35f9808eca5b0ff76b9decc1ce9e35aadc818bcb Mon Sep 17 00:00:00 2001 From: Liu Hao Date: Sat, 22 May 2021 10:01:45 +0800 Subject: [PATCH 2/2] include/process: Declare `quick_exit()` here too This duplicates the declaration in 7dda261ef062073eed4ed5b46effa3edd4a658fc.

[Mingw-w64-public] [PATCH 1/2] include/assert: Remove unreferenced declarations

2021-05-21 Thread Liu Hao
-- Best regards, Liu Hao From 2c15e34d8493699a5ec078b25de2ae1362918e53 Mon Sep 17 00:00:00 2001 From: Liu Hao Date: Sat, 22 May 2021 09:59:56 +0800 Subject: [PATCH 1/2] include/assert: Remove unreferenced declarations This de-duplicates them a bit. Signed-off-by: Liu Hao --- mingw-w64-header

Re: [Mingw-w64-public] [PATCH] crt/stdlib: Add `quick_exit()` and `at_quick_exit()` for UCRT

2021-05-21 Thread Christoph Reiter
On Sun, Apr 25, 2021 at 6:06 PM Liu Hao wrote: > Does this program compile and run with that commit? > > ``` > #define _GLIBCXX_HAVE_QUICK_EXIT 1 > #include > > int main() >{ > ::std::quick_exit(0); >} > ``` It compiles and runs fine, but gcc still fails to build with current master

Re: [Mingw-w64-public] [PATCH] crt: Add libopends60.a.

2021-05-21 Thread Liu Hao
在 2021-05-21 23:07, Mark Harmstone 写道: On 21/5/21 2:23 am, Liu Hao wrote: Did you forget the 32-bit DEF file? i686 symbols have specific decoration rules, therefore require distinct DEF files from those in 'lib-common'. It's not necessary - all the exports are cdecl rather than stdcall, so do

Re: [Mingw-w64-public] [PATCH] crt: Add libopends60.a.

2021-05-21 Thread Mark Harmstone
On 21/5/21 2:23 am, Liu Hao wrote: > Did you forget the 32-bit DEF file? i686 symbols have specific decoration > rules, therefore require distinct DEF files from those in 'lib-common'. It's not necessary - all the exports are cdecl rather than stdcall, so don't get @4 etc. added to the end. _