Re: [Mingw-w64-public] [PATCH] crt: Increase precision of gettimeofday() if possible.

2021-05-02 Thread Martin Storsjö
On Wed, 28 Apr 2021, Liu Hao wrote: 在 4/27/21 2:00 AM, Christian Franke 写道: Which complexity do you mean - the extra cost of the system call or the extra 15 lines of code? Just for the record - I wouldn't mind applying the patch or something like it. I agree with the arguments that it wo

Re: [Mingw-w64-public] [PATCH] crt: Increase precision of gettimeofday() if possible.

2021-05-02 Thread Liu Hao
在 2021-05-03 00:39, Dan Raymond 写道: I don't agree with this.  First: precision and accuracy are two entirely different things so it's important not to use them interchangeably.  It is true that the absolute value of the wall clock time is not likely to be very accurate.  If you are interested in

Re: [Mingw-w64-public] [PATCH] headers: Add missing names in shlwapi.h

2021-05-02 Thread Liu Hao
在 2021-05-03 01:53, Biswapriyo Nath 写道: From 3bde731614cf9ea87f75a98752b905785b984485 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Sun, 2 May 2021 23:21:56 +0530 Subject: [PATCH] headers: Add missing names in shlwapi.h Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/shlwa

[Mingw-w64-public] [PATCH] headers: Add missing names in shlwapi.h

2021-05-02 Thread Biswapriyo Nath
From 3bde731614cf9ea87f75a98752b905785b984485 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Sun, 2 May 2021 23:21:56 +0530 Subject: [PATCH] headers: Add missing names in shlwapi.h Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/shlwapi.h | 32 -

Re: [Mingw-w64-public] [PATCH] crt: Increase precision of gettimeofday() if possible.

2021-05-02 Thread Dan Raymond
1. `clock_gettime()` is not meant to be precise, and it shouldn't be, because the extra accuracy is useless. (It may make some sense for logging, as mentioned in another message; but in logs only the order of writes matters, while timestamps don't matter.) I don't agree with this.  First: pr

Re: [Mingw-w64-public] Add missing function declarations to mingw-w64-headers/include/shlwapi.h

2021-05-02 Thread Liu Hao
在 2021-05-02 17:58, DAVID MAY 写道: On 2/05/2021 1:28 pm, Liu Hao wrote: Please use `WINBOOL` instead of `BOOL` as the latter is a builtin type on Mac. There are more `BOOL`s in the original file, they should be replaced as well. See attached patch with changes you requested. Thanks for th

Re: [Mingw-w64-public] Add missing function declarations to mingw-w64-headers/include/shlwapi.h

2021-05-02 Thread DAVID MAY
On 2/05/2021 1:28 pm, Liu Hao wrote: > > Please use `WINBOOL` instead of `BOOL` as the latter is a builtin type > on Mac. > > There are more `BOOL`s in the original file, they should be replaced as > well. > See attached patch with changes you requested. -- David May --- doc/mingw64-shlwapi.h