On Thu, 8 Apr 2021, Jeremy Drake via Mingw-w64-public wrote:
Not only does gnulib key off of the definition of _IOERR to know whether
to use its UCRT definitions, but the constants are different between
MSVCRT and the (internal) constants in UCRT source.
It turns out that the constants _IOFBF _
Not only does gnulib key off of the definition of _IOERR to know whether
to use its UCRT definitions, but the constants are different between
MSVCRT and the (internal) constants in UCRT source.
It turns out that the constants _IOFBF _IOLBF and _IONBF are still
present in the UCRT headers (they are
On Thu, 8 Apr 2021, Jeremy Drake via Mingw-w64-public wrote:
On Thu, 8 Apr 2021, Jeremy Drake via Mingw-w64-public wrote:
It looks like gnulib would Do The Right Thing if _IOERR were not defined
for UCRT. Could you do that?
I've confirmed that the following patch allows gnulib in libunistri
On Thu, 8 Apr 2021, Jeremy Drake via Mingw-w64-public wrote:
> It looks like gnulib would Do The Right Thing if _IOERR were not defined
> for UCRT. Could you do that?
I've confirmed that the following patch allows gnulib in libunistring to
build.
diff --git a/mingw-w64-headers/crt/stdio.h b/min
On Thu, 8 Apr 2021, Jeremy Drake via Mingw-w64-public wrote:
> It looks like gnulib would Do The Right Thing if _IOERR were not defined
> for UCRT. Could you do that?
In fact, it looks as though the definitions of those constants are not the
same between msvcrt and ucrt. UCRT _IOERROR is 0x10,
On Thu, 8 Apr 2021, Liu Hao wrote:
> I don't think it is a regression, because there is `MSVC` in the comment on
> that line, and if MSVC was used to compile that file (with UCRT), the same
> error will occur. It's probably better to add `#elif defined _UCRT` above that
> line, and define a privat
On Thu, 8 Apr 2021, Martin Storsjö wrote:
> Hi,
>
> Nitpicky sidetrack - doesn't this fail to build for you unless you include
> errno.h too?
No, it built without so much as a warning with clang and gcc for me.
___
Mingw-w64-public mailing list
Mingw-w6
在 2021-04-08 09:59, Jeremy Drake via Mingw-w64-public 写道:
I've found a regression caused by this. Apparently gnulib knows about the
_flag field:
https://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/fseterr.c#n45
I don't think it is a regression, because there is `MSVC` in the comment on that
在 2021-04-08 13:53, Martin Storsjö 写道:
On Thu, 8 Apr 2021, Liu Hao wrote:
LGTM too, thanks!
Thanks. Pushed now.
--
Best regards,
Liu Hao
OpenPGP_signature
Description: OpenPGP digital signature
___
Mingw-w64-public mailing list
Mingw-w64-p
