Re: [Mingw-w64-public] UCRT access() function issue

Hi, On Wed, 7 Apr 2021, Jeremy Drake via Mingw-w64-public wrote: For a few months, I've been working around an issue building ncurses with clang targeting UCRT (https://github.com/msys2/CLANG-packages/issues/4), and recently the same issue had to be worked around for GCC targeting UCRT. I fina

Re: [Mingw-w64-public] [PATCH] include/stralign: Canonicalize macros for x86-64

On Thu, 8 Apr 2021, Liu Hao wrote: LGTM too, thanks! // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH v2] include/crt: Use GCC predefined macros instead of MSVC-ish ones

On Thu, 8 Apr 2021, Liu Hao wrote: LGTM, thanks! // Martin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] include/crt: Use GCC predefined macros instead of MSVC-ish ones

On Thu, 8 Apr 2021, Liu Hao wrote: 在 2021/4/8 上午3:50, Martin Storsjö 写道: I think the canonical ones to use, based on what we have in existing code today, would be: - __i386__ with two trailing underscores (we have 141 occurrances of that but 0 of __i386) - __x86_64__ (214 occurrances of th

[Mingw-w64-public] UCRT access() function issue

Hello, For a few months, I've been working around an issue building ncurses with clang targeting UCRT (https://github.com/msys2/CLANG-packages/issues/4), and recently the same issue had to be worked around for GCC targeting UCRT. I finally got around to debugging it, and found that the call at ht

[Mingw-w64-public] [PATCH] include/stralign: Canonicalize macros for x86-64

-- Best regards, Liu Hao From 0936c4ded2d1830a5324e3b90d046bf053af311e Mon Sep 17 00:00:00 2001 From: Liu Hao Date: Thu, 8 Apr 2021 10:11:37 +0800 Subject: [PATCH] include/stralign: Canonicalize macros for x86-64 We check for `__x86_64__` instead of `__amd64__` in other places. Signed-off-by:

Re: [Mingw-w64-public] [PATCH] include/crt: Use GCC predefined macros instead of MSVC-ish ones

在 2021/4/8 上午3:50, Martin Storsjö 写道: I think the canonical ones to use, based on what we have in existing code today, would be: - __i386__ with two trailing underscores (we have 141 occurrances of that but 0 of __i386) - __x86_64__ (214 occurrances of that but none for __amd64 outside of cof

[Mingw-w64-public] [PATCH v2] include/crt: Use GCC predefined macros instead of MSVC-ish ones

-- Best regards, Liu Hao From e2c5baf4066d5343325ff582b6d8474a55f369dc Mon Sep 17 00:00:00 2001 From: Liu Hao Date: Wed, 7 Apr 2021 23:24:47 +0800 Subject: [PATCH] include/crt: Use GCC predefined macros instead of MSVC-ish ones Reference: https://github.com/gcc-mirror/gcc/blob/2f3d9104610cb205

Re: [Mingw-w64-public] [PATCH] headers: Hide the contents of struct _iobuf in UCRT mode

On Fri, 26 Mar 2021, Liu Hao wrote: > 在 2021-03-26 20:19, Martin Storsjö 写道: > > This matches the public UCRT headers - the struct only contains one > > single placeholder member. > > > > Signed-off-by: Martin Storsjö > > --- > > mingw-w64-headers/crt/stdio.h | 4 > > 1 file changed, 4 ins

Re: [Mingw-w64-public] [PATCH] include/crt: Use GCC predefined macros instead of MSVC-ish ones

On Wed, 7 Apr 2021, Liu Hao wrote: Side notes: 0. Those in 'crt/vadefs.h' reside in an `#elif defined(_MSC_VER)` block, which is only visible when compiled with MSVC, so they are left unchanged. I think the canonical ones to use, based on what we have in existing code today, would be:

[Mingw-w64-public] [PATCH] include/crt: Use GCC predefined macros instead of MSVC-ish ones

Side notes: 0. Those in 'crt/vadefs.h' reside in an `#elif defined(_MSC_VER)` block, which is only visible when compiled with MSVC, so they are left unchanged. 1. These non-CRT headers are unchanged: * ddk/include/ddk/ioaccess.h * ddk/include/ddk/ndis.h * ddk/include/ddk/ntddk.h

Re: [Mingw-w64-public] [PATCH] include/float: Only hide non-reserved identifiers in strict, conformance mode

在 2021/4/7 下午1:55, Martin Storsjö 写道: A new patch for changing that sounds good to me. And this patch looks good to me. Thanks. I pushed this one. Perhaps I can propose the other one later. -- Best regards, Liu Hao OpenPGP_signature Description: OpenPGP digital signature ___