Re: [Mingw-w64-public] [PATCH] crt/libsrc: add netcfg-uuid.c for network config interfaces

2020-05-08 Thread Biswapriyo Nath
> Could we include netcfgx.h instead of duplicating it? Yes. Updated patch attached. From 8b323e52c31d4772b23adabb6184e0d170b03eb1 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Sat, 9 May 2020 09:11:36 +0530 Subject: [PATCH] crt/libsrc: add netcfg-uuid.c for network config interfaces Sign

Re: [Mingw-w64-public] [PATCH] crt/libsrc: add netcfg-uuid.c for network config interfaces

2020-05-08 Thread Jacek Caban
Hi Biswapriyo, On 08.05.2020 22:32, Biswapriyo Nath wrote: mingw-w64-crt/Makefile.am | 18 +++ mingw-w64-crt/libsrc/netcfg-uuid.c | 37 ++ 2 files changed, 46 insertions(+), 9 deletions(-) create mode 100644 mingw-w64-crt/libsrc/netcfg-uuid.

Re: [Mingw-w64-public] [PATCH] crt/libsrc: include devguid.h in devguid.c and remove all defines

2020-05-08 Thread Jacek Caban
On 07.05.2020 18:45, Biswapriyo Nath wrote: Main goal is to update the devguid.c in libsrc folder for libuuid.a. There are two options I guess: 1. Copy the new GUIDs from devguid.h to devguid.c. 2. Include devguid.h in devguid.c. Option 2 is done in the attached patch file. Because if a new GUI

[Mingw-w64-public] [PATCH] crt/libsrc: add netcfg-uuid.c for network config interfaces

2020-05-08 Thread Biswapriyo Nath
... From 47c42c14ab5905631e5e1553a9eb0ecdd847fd31 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Sat, 9 May 2020 23:00:28 +0530 Subject: [PATCH] crt/libsrc: add netcfg-uuid.c for network config interfaces Signed-off-by: Biswapriyo Nath --- mingw-w64-crt/Makefile.am | 18 +++--

Re: [Mingw-w64-public] [PATCH] headers: add nserror.h

2020-05-08 Thread Liu Hao
在 2020/5/8 21:44, Biswapriyo Nath 写道: > Required by mingw-w64-qt5. > > Thanks. Patch looks good. Pushed. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourc

Re: [Mingw-w64-public] [PATCH 1/2] dwrite.h: Fix build in C mode

2020-05-08 Thread Ruslan Garipov
On 5/8/2020 3:32 PM, Biswapriyo Nath wrote: > I will not discourage your effort and contribution. But if you want, this > can be fixed easily with IDL files. widl will take care the rest. And IDL > files are smaller to manage than their .h counterpart. To be honest, it makes no difference for me wh

[Mingw-w64-public] [PATCH] headers: add nserror.h

2020-05-08 Thread Biswapriyo Nath
Required by mingw-w64-qt5. From f07a5b781c7d0ef215e84b241af1f1b74f418ead Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Fri, 8 May 2020 19:10:52 +0530 Subject: [PATCH] headers: add nserror.h Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/nserror.h | 1235

Re: [Mingw-w64-public] [PATCH] crt: Build crt sources with -D__USE_MINGW_ANSI_STDIO=0

2020-05-08 Thread Liu Hao
在 2020/5/8 3:08, Martin Storsjö 写道: > This fixes lots of warnings like these: > > stdio/snprintf.c:9:13: warning: no previous prototype for function > '__ms_snprintf' [-Wmissing-prototypes] > stdio/vwscanf.c:15:10: warning: implicit declaration of function > '__ms_vfwscanf' is invalid in C99 [-W

Re: [Mingw-w64-public] [PATCH] crt: Don't make sections executable when not necessary

2020-05-08 Thread Liu Hao
在 2020/5/8 2:30, Martin Storsjö 写道: > With this in place, a VirtualProtect implementation in winstorecompat > that just straight redirects to VirtualProtectFromApp will work > fine even on UWP without any codeGeneration capability, as long as > there's no runtime pseudo relocs in code sections. And

Re: [Mingw-w64-public] [PATCH] crt: Remove the unused mingw-fseek.c

2020-05-08 Thread Liu Hao
在 2020/5/8 1:36, Martin Storsjö 写道: > The functions in this file, __mingw_fseek/__mingw_fseeko64/__mingw_fwrite > haven't ever been used within mingw-w64 throughout the SCM history, > but were originally intended to work around issues with seeking past > the end of files on Win9x. > > Signed-off-b

Re: [Mingw-w64-public] [PATCH 1/4] winstorecompat: Use __asm__() instead of asm() for setting symbol names

2020-05-08 Thread Liu Hao
在 2020/5/8 2:55, Martin Storsjö 写道: > The previous form caused compiler warnings like "warning: extension used > [-Wlanguage-extension-token]" when built with clang. > > Signed-off-by: Martin Storsjö > --- > This series of patches look good to me. Please go ahead and apply. -- Best regards,

Re: [Mingw-w64-public] [PATCH 2/2] headers: add netcfgn.idl

2020-05-08 Thread Liu Hao
在 2020/5/8 12:11, Biswapriyo Nath 写道: > ... > > Thanks. Pushed these two patches. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://list

Re: [Mingw-w64-public] [PATCH 1/2] dwrite.h: Fix build in C mode

2020-05-08 Thread Biswapriyo Nath
I will not discourage your effort and contribution. But if you want, this can be fixed easily with IDL files. widl will take care the rest. And IDL files are smaller to manage than their .h counterpart. ___ Mingw-w64-public mailing list Mingw-w64-public@

[Mingw-w64-public] [PATCH 1/2] dwrite.h: Fix build in C mode

2020-05-08 Thread Ruslan Garipov
IDWriteTextLayout interface declares some overloaded member functions (for example, IDWriteTextFormat::GetFontCollection and IDWriteTextLayout::GetFontCollection). This causes a C compiler to fail on a module including dwrite.h. This commit splits declaration of IDWriteTextLayout interface for

[Mingw-w64-public] [PATCH 2/2] dwrite_1.h: Fix build in C mode

2020-05-08 Thread Ruslan Garipov
Some classes in the file declare overloaded functions, and this causes a C compiler to fail on module including dwrite_1.h. This commit fixes that. No changes for compilation using C++ mode. Signed-off-by: ‡Ruslan Garipov --- mingw-w64-headers/include/dwrite_1.h | 651 ---