Re: [Mingw-w64-public] [PATCH] crt: Split out __report_gsfailure from gs_support.c

2020-04-22 Thread Steve Lhomme
Hi, I prefer this approach as it shouldn't break apps relying on the internal MSVC symbol, however wrong that sounds. __security_init_cookie is documented (and it's OK to call it in some cases) but __report_gsfailure doesn't seem to be. I suppose not having it in ucrt is better than not hav

[Mingw-w64-public] [PATCH] crt: Split out __report_gsfailure from gs_support.c

2020-04-22 Thread Martin Storsjö
Modern CRTs already provide this function, so move the existing implementation to the CRT specific import library for msvcrt and msvcr80 (as it's present since msvcr90). While the implementation in gs_support.c is incomplete and not actually of any use with MinGW compilers, user code could, potent

[Mingw-w64-public] [PATCH] crt: Remove the vestigial gs_support.c

2020-04-22 Thread Martin Storsjö
This was a partial (but incomplete!) support for the MSVC stack cookie handling (under the MSVC option /GS, similar to GCC and Clang/MinGW's -fstack-protector-strong). This contained the stack cookie itself and the init function, and the error reporting function, but not the checking function (__se

[Mingw-w64-public] [PATCH] headers: winerror.h add security error values

2020-04-22 Thread Biswapriyo Nath
... From 7292303d032c2c118de3f609ae2115e8b16de211 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Wed, 22 Apr 2020 21:25:27 +0530 Subject: [PATCH] headers: winerror.h add security error values Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/winerror.h | 17 + 1

[Mingw-w64-public] [PATCH] headers: update schannel.h

2020-04-22 Thread Biswapriyo Nath
... From 5af537ca20daf3f4fb0e1867e0321e8b7f66c01d Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Wed, 22 Apr 2020 20:36:18 +0530 Subject: [PATCH] headers: update schannel.h Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/schannel.h | 365 +-- 1 file ch

Re: [Mingw-w64-public] [PATCH] headers: provide the WinMain prototype to winstore apps

2020-04-22 Thread Liu Hao
在 2020/4/22 20:02, Steve Lhomme 写道: > A proper UWP app should create a IFrameworkViewSource class, instantiate it > and > call CoreApplication:Run() with it. > https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.core > > To create the instance the app still needs an entry point and

Re: [Mingw-w64-public] [PATCH] headers: add vss.idl

2020-04-22 Thread Liu Hao
在 2020/4/22 11:38, Biswapriyo Nath 写道: > Updated. > > > Thanks. Pushed. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourcef

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Steve Lhomme
On 2020-04-22 16:28, Jacek Caban wrote: On 22.04.2020 14:03, Martin Storsjö wrote: On Wed, 22 Apr 2020, Jacek Caban wrote: On 22.04.2020 12:47, Martin Storsjö wrote: The compiler doesn't generate .pdata sections if e.g. building with a toolchain that defaults to SJLJ exception handling - th

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Jacek Caban
On 22.04.2020 14:03, Martin Storsjö wrote: On Wed, 22 Apr 2020, Jacek Caban wrote: On 22.04.2020 12:47, Martin Storsjö wrote: The compiler doesn't generate .pdata sections if e.g. building with a toolchain that defaults to SJLJ exception handling - that's a common (not the most common, but

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Martin Storsjö
On Wed, 22 Apr 2020, Steve Lhomme wrote: On 2020-04-22 14:34, Martin Storsjö wrote: On Wed, 22 Apr 2020, Steve Lhomme wrote: On 2020-04-22 12:47, Martin Storsjö wrote: On Wed, 22 Apr 2020, Steve Lhomme wrote: I am not very familiar with all of this, so don't take my word for it. It seems t

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Steve Lhomme
On 2020-04-22 14:34, Martin Storsjö wrote: On Wed, 22 Apr 2020, Steve Lhomme wrote: On 2020-04-22 12:47, Martin Storsjö wrote: On Wed, 22 Apr 2020, Steve Lhomme wrote: I am not very familiar with all of this, so don't take my word for it. It seems the .pdata section to be a Windows only thin

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Martin Storsjö
On Wed, 22 Apr 2020, Steve Lhomme wrote: On 2020-04-22 12:47, Martin Storsjö wrote: On Wed, 22 Apr 2020, Steve Lhomme wrote: I am not very familiar with all of this, so don't take my word for it. It seems the .pdata section to be a Windows only thing https://docs.microsoft.com/en-us/windows/

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Steve Lhomme
On 2020-04-22 12:47, Martin Storsjö wrote: On Wed, 22 Apr 2020, Steve Lhomme wrote: I am not very familiar with all of this, so don't take my word for it. It seems the .pdata section to be a Windows only thing https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#the-pdata-section I

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Martin Storsjö
On Wed, 22 Apr 2020, Jacek Caban wrote: On 22.04.2020 12:47, Martin Storsjö wrote: The compiler doesn't generate .pdata sections if e.g. building with a toolchain that defaults to SJLJ exception handling - that's a common (not the most common, but still occurring) configuration. Like I alr

[Mingw-w64-public] [PATCH] headers: provide the WinMain prototype to winstore apps

2020-04-22 Thread Steve Lhomme
A proper UWP app should create a IFrameworkViewSource class, instantiate it and call CoreApplication:Run() with it. https://docs.microsoft.com/en-us/uwp/api/windows.applicationmodel.core To create the instance the app still needs an entry point and that's still WinMain: https://stackoverflow.com/a

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Jacek Caban
On 22.04.2020 13:28, Jacek Caban wrote: How reliably can we detect the condition when if compiler will generate .pdata sections? I meant s/when/when building crt/. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Jacek Caban
On 22.04.2020 12:47, Martin Storsjö wrote: The compiler doesn't generate .pdata sections if e.g. building with a toolchain that defaults to SJLJ exception handling - that's a common (not the most common, but still occurring) configuration. Like I already wrote once, this is a catch-all handl

Re: [Mingw-w64-public] [PATCH] crt: add a dummy RtlAddFunctionTable when linking with windowsapp

2020-04-22 Thread Martin Storsjö
On Wed, 22 Apr 2020, Steve Lhomme wrote: I am not very familiar with all of this, so don't take my word for it. It seems the .pdata section to be a Windows only thing https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#the-pdata-section I don't know if gcc/clang/ld/lld handles it or m

[Mingw-w64-public] [PATCH] headers: add SetUnhandledExceptionFilter to winstore builds

2020-04-22 Thread Steve Lhomme
https://docs.microsoft.com/en-us/windows/win32/api/errhandlingapi/nf-errhandlingapi-setunhandledexceptionfilter https://docs.microsoft.com/en-us/uwp/win32-and-com/win32-apis#apis-from-api-ms-win-core-errorhandling-l1-1-3dll UnhandledExceptionFilter is *not* supported. --- mingw-w64-headers/includ