Re: [Mingw-w64-public] [PATCH] Detect -lm in genlib

2020-04-05 Thread Liu Hao
在 2020/4/6 5:04, Stephen Kitt 写道: > genlib's configure checks for -lmangle before -lm; as a result, the > -lm checks include -lmangle which fails because the required library > path isn't specified. To avoid this, we check for -lm before checking > for -lmangle. > > Signed-off-by: Stephen Kitt >

Re: [Mingw-w64-public] [PATCH] Drop the empty exception declaration from CheckError

2020-04-05 Thread Liu Hao
在 2020/4/6 5:04, Stephen Kitt 写道: > The function is defined as follows: > > > so actually calling it with a failed HRESULT crashes the program. I > think the empty exception specification should simply be dropped. > > See https://bugs.debian.org/816427 > > Reported-by: Sam Morris > Signed-of

Re: [Mingw-w64-public] Proposal to add a code formatting rule

2020-04-05 Thread Biswapriyo Nath
As example, if someone has edtiorconfig feature/plugin in his/her text editor then the new patches will be formatted new rules, no need to change all files. As far as I know, most of the header files follow these rules: indent_style=space indent_size=2 trim_trailing_whitespace=true insert_final_ne

[Mingw-w64-public] [PATCH] Fix a few spelling errors

2020-04-05 Thread Stephen Kitt
These were flagged by Debian's Lintian QA tool. Signed-off-by: Stephen Kitt --- mingw-w64-libraries/libmangle/src/m_ms.c | 2 +- mingw-w64-tools/gendef/src/gendef.c | 2 +- mingw-w64-tools/genpeimg/src/img_pe.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ming

Re: [Mingw-w64-public] Proposal to add a code formatting rule

2020-04-05 Thread Liu Hao
在 2020/4/4 13:01, Biswapriyo Nath 写道: > The coding style is different in many files in mingw-w64 headers and crt. > Is it possible to add a rule to enforce a consistent coding style across > all the source file? For example, using clang-fromat, editorconfig etc. > lightweight tools? > > From my h

[Mingw-w64-public] [PATCH] Detect -lm in genlib

2020-04-05 Thread Stephen Kitt
genlib's configure checks for -lmangle before -lm; as a result, the -lm checks include -lmangle which fails because the required library path isn't specified. To avoid this, we check for -lm before checking for -lmangle. Signed-off-by: Stephen Kitt --- mingw-w64-tools/genlib/configure.ac | 16 ++

[Mingw-w64-public] [PATCH][winpthreads] Allow to use provided WINPTHREAD_API and small bugfix

2020-04-05 Thread Egor Pugin
Hi, This patch: 1) Allows to use provided WINPTHREAD_API. 2) Fixes timespec decl before first use (in pthread_delay_np decl). -- Egor Pugin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/li

[Mingw-w64-public] [PATCH] Drop the empty exception declaration from CheckError

2020-04-05 Thread Stephen Kitt
The function is defined as follows: namespace _com_util { inline void CheckError(HRESULT hr) throw() { if(FAILED(hr)) { _com_issue_error(hr); } } } but _com_issue_error is defined as: inline void _com_issue_error(HRESULT hr) { #if __EXCEPTIONS throw _c