Re: [Mingw-w64-public] [PATCH][winpthreads] Allow to use provided WINPTHREAD_API and small bugfix

2020-03-13 Thread Egor Pugin
clang --version clang version 11.0.0 (https://github.com/llvm/llvm-project 1bf5ffa164f19094ece5809a4cceeedb740b9281) Target: x86_64-pc-windows-msvc Thread model: posix InstalledDir: D:\dev\llvm\win64_ninja_release\bin "-target" "x86_64-unknown-windows" Yes, this is not "x86_64-msvc-windows" or wha

Re: [Mingw-w64-public] [PATCH][winpthreads] Allow to use provided WINPTHREAD_API and small bugfix

2020-03-13 Thread Martin Storsjö
On Sat, 14 Mar 2020, Egor Pugin wrote: The first hunk seems harmless. But why would you like to define `WINPTHREAD_API` yourself? Custom build system. Building winpthreads under native win32 with clang (not clang-cl) without msvc compat. Clang in such mode requires __attribute__ ((dllexport) a

Re: [Mingw-w64-public] [PATCH][winpthreads] Allow to use provided WINPTHREAD_API and small bugfix

2020-03-13 Thread Egor Pugin
Fix: with _TIMESPEC_DEFINED - 3 errors without _TIMESPEC_DEFINED - 1 error *during src/thread.c build. On Sat, 14 Mar 2020 at 00:57, Egor Pugin wrote: > > > The first hunk seems harmless. But why would you like to define > `WINPTHREAD_API` yourself? > > Custom build system. Building winpthreads u

Re: [Mingw-w64-public] [PATCH][winpthreads] Allow to use provided WINPTHREAD_API and small bugfix

2020-03-13 Thread Egor Pugin
> The first hunk seems harmless. But why would you like to define `WINPTHREAD_API` yourself? Custom build system. Building winpthreads under native win32 with clang (not clang-cl) without msvc compat. Clang in such mode requires __attribute__ ((dllexport) and __attribute__ ((dllimport), not __decl

Re: [Mingw-w64-public] [PATCH][winpthreads] Allow to use provided WINPTHREAD_API and small bugfix

2020-03-13 Thread Liu Hao
在 2020/3/13 0:34, Egor Pugin 写道: > Sure. > > The first hunk seems harmless. But why would you like to define `WINPTHREAD_API` yourself? The second hunk is unnecessary. The prototype of `pthread_delay_np()` contains `struct timespec` which is a valid type name there. The declaration doesn't requ