Re: [Mingw-w64-public] [PATCH] crt: Make __ms_snprintf and __ms_vsnprintf aliases for snprintf and vsnprintf

2020-02-24 Thread Liu Hao
在 2020/2/24 16:10, Martin Storsjö 写道: > Prior to dc3b2e2bfa9b5a4fcee6f0123047ecc5a6a35d1f, snprintf was > aliased to _snprintf and vsnprintf was aliased to _vsnprintf in > the import library. As _snprintf doesn't really behave as snprintf > should, the aliases were removed. > > Instead make them a

Re: [Mingw-w64-public] snprintf() vs. _snprintf()

2020-02-24 Thread Martin Storsjö
On Mon, 24 Feb 2020, Jacek Caban wrote: On 24.02.2020 12:46, Jacek Caban wrote: On 24.02.2020 12:28, Martin Storsjö wrote: On Mon, 24 Feb 2020, Jacek Caban wrote: Still, the problematic commit tries to solve some problems that are already solved when using mingw-w64 *printf implementation. S

Re: [Mingw-w64-public] snprintf() vs. _snprintf()

2020-02-24 Thread Jacek Caban
On 24.02.2020 12:46, Jacek Caban wrote: On 24.02.2020 12:28, Martin Storsjö wrote: On Mon, 24 Feb 2020, Jacek Caban wrote: Still, the problematic commit tries to solve some problems that are already solved when using mingw-w64 *printf implementation. Since non-underscored does not exist in ms

Re: [Mingw-w64-public] snprintf() vs. _snprintf()

2020-02-24 Thread Jacek Caban
On 24.02.2020 12:28, Martin Storsjö wrote: On Mon, 24 Feb 2020, Jacek Caban wrote: Still, the problematic commit tries to solve some problems that are already solved when using mingw-w64 *printf implementation. Since non-underscored does not exist in msvcrt.dll, it's our extension anyway. So

Re: [Mingw-w64-public] snprintf() vs. _snprintf()

2020-02-24 Thread Martin Storsjö
On Mon, 24 Feb 2020, Jacek Caban wrote: Still, the problematic commit tries to solve some problems that are already solved when using mingw-w64 *printf implementation. Since non-underscored does not exist in msvcrt.dll, it's our extension anyway. So how about making it always use __mingw_vsnpr

Re: [Mingw-w64-public] snprintf() vs. _snprintf()

2020-02-24 Thread Jacek Caban
Hi, I think that the best way forward is UCRT. When using UCRT, there is already no issue. We should probably revisit making that a default configuration. I don't agree with us trying to limit use to VC6 subset. Microsoft does not intentionally break applications and I'm pretty sure that r

[Mingw-w64-public] [PATCH] crt: Make __ms_snprintf and __ms_vsnprintf aliases for snprintf and vsnprintf

2020-02-24 Thread Martin Storsjö
Prior to dc3b2e2bfa9b5a4fcee6f0123047ecc5a6a35d1f, snprintf was aliased to _snprintf and vsnprintf was aliased to _vsnprintf in the import library. As _snprintf doesn't really behave as snprintf should, the aliases were removed. Instead make them aliases to the __ms_snprintf and __ms_vsnprintf fun