Re: [Mingw-w64-public] [WIP] [PATCH] Implement standard-conforming `frexp()` functions on x86 and x64

2019-07-18 Thread Liu Hao
在 2019/7/19 上午5:15, Martin Storsjö 写道: > > It's almost good now, but a few things stood out: > In my previous patch I mistook 'IEEE 765' for 'IEEE 754'. XD The typos have been rectified now. > - ucrtbase.def.in has got a comment about frexp similar to > api-ms-win-crt-math-l1-1-0.def.in; I'd a

Re: [Mingw-w64-public] [PATCH] Fix building runtime for Cygwin

2019-07-18 Thread JonY via Mingw-w64-public
On 7/18/19 11:21 AM, Alexey Pavlov wrote: > JonY, can you push it? > Forgot to mention that I have already pushed to master. signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net

Re: [Mingw-w64-public] [WIP] [PATCH] Implement standard-conforming `frexp()` functions on x86 and x64

2019-07-18 Thread Martin Storsjö
On Thu, 18 Jul 2019, Liu Hao wrote: 在 2019/7/18 15:23, Martin Storsjö 写道: No, that's probably not necessary, the delegation is probably fine. But we need to replace the msvcrt frexp function, not only provide frexpl, to get correct inf semantics, right? Yes. I removed the hunk for 'api-ms-

Re: [Mingw-w64-public] [PATCH] include: Update namedpipeapi header file

2019-07-18 Thread Liu Hao
在 2019/7/18 21:59, Biswapriyo Nath 写道: > Fixed #2. > > > Are there any reasons for keeping duplicates of `#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_APP)` ? Those in the middle can be removed I think, so we only ever need a large `#if ... #endif` at the top level. -- Best regards, LH_Mou

Re: [Mingw-w64-public] [WIP] [PATCH] Implement standard-conforming `frexp()` functions on x86 and x64

2019-07-18 Thread Liu Hao
在 2019/7/18 15:23, Martin Storsjö 写道: > > No, that's probably not necessary, the delegation is probably fine. But > we need to replace the msvcrt frexp function, not only provide frexpl, > to get correct inf semantics, right? > > Yes. I removed the hunk for 'api-ms-win-crt-math*' thing. I also

Re: [Mingw-w64-public] [PATCH] include: Update namedpipeapi header file

2019-07-18 Thread Biswapriyo Nath
Fixed #2. From 9b0d040a3ae2aba1125b315dd8bacdae30b70150 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Wed, 17 Jul 2019 18:01:14 +0530 Subject: [PATCH] include: Update namedpipeapi header file Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/namedpipeapi.h | 43 +++

Re: [Mingw-w64-public] [PATCH] include: Update namedpipeapi header file

2019-07-18 Thread Liu Hao
在 2019/7/18 17:56, Biswapriyo Nath 写道: > Fixed. > > > Again, does `WINAPI_PARTITION_GAMES` exist in other headers at all? Probably it should be removed as well. Those `#if` blocks can be merged thereafter. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature

Re: [Mingw-w64-public] [PATCH] Fix building runtime for Cygwin

2019-07-18 Thread Alexey Pavlov
JonY, can you push it? чт, 18 июл. 2019 г. в 02:55, JonY via Mingw-w64-public < mingw-w64-public@lists.sourceforge.net>: > On 7/17/19 8:24 PM, Alexey Pavlov wrote: > >>From 045b8d3925b22dbac648cf7db552b57df4f1f295 Mon Sep 17 00:00:00 2001 > > Patch looks OK. >

Re: [Mingw-w64-public] [PATCH] include: Update namedpipeapi header file

2019-07-18 Thread Biswapriyo Nath
Fixed. From 9b0d040a3ae2aba1125b315dd8bacdae30b70150 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Wed, 17 Jul 2019 18:01:14 +0530 Subject: [PATCH] include: Update namedpipeapi header file Signed-off-by: Biswapriyo Nath --- mingw-w64-headers/include/namedpipeapi.h | 43 ++

Re: [Mingw-w64-public] [PATCH] include: Update namedpipeapi header file

2019-07-18 Thread Martin Storsjö
On Thu, 18 Jul 2019, Liu Hao wrote: 在 2019/7/18 上午1:07, Biswapriyo Nath 写道: `WINAPI_PARTITION_SYSTEM` doesn't seem to be supported. Please remove it. Can you provide the reason? Should I add a patch for winapifamily.h? Because it does not exist in any other Windows headers of ours. I am n

Re: [Mingw-w64-public] [WIP] [PATCH] Implement standard-conforming `frexp()` functions on x86 and x64

2019-07-18 Thread Martin Storsjö
On Thu, 18 Jul 2019, Liu Hao wrote: 在 2019/7/18 上午4:43, Martin Storsjö 写道: I tested the code snippet you sent on irc. On both ARM and AArch64, with the UCRT (statically linked CRT from MSVC 2015, 2017 and 2019, or dynamically linked built with mingw-w64 libraries), I got "inf -1". (Also, with