Re: [Mingw-w64-public] Missing include in uuid.c

2019-07-02 Thread Jacek Caban
On 7/2/19 4:42 PM, Tom Ritter wrote: The attached patch fixes an error from the recent commit for netlistmgr.h Pushed. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/li

[Mingw-w64-public] Missing include in uuid.c

2019-07-02 Thread Tom Ritter
The attached patch fixes an error from the recent commit for netlistmgr.h -tom From 660c608cdde7a2398fc4f599a7b0c004f2746d87 Mon Sep 17 00:00:00 2001 From: Tom Ritter Date: Tue, 2 Jul 2019 08:23:18 -0500 Subject: [PATCH] Add include to uuid.c to resolve undefined symbols: _CLSID_NetworkListManag

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread LRN
On 02.07.2019 14:58, Jacek Caban wrote: > On 7/2/19 1:35 PM, LRN wrote: >> On 02.07.2019 13:42, Jacek Caban wrote: >>> On 02/07/2019 12:38, LRN wrote: On 02.07.2019 13:15, Jacek Caban wrote: > On 02/07/2019 12:12, Jacek Caban wrote: >> On 02/07/2019 11:57, Liu Hao wrote: >> >>>

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread LRN
On 02.07.2019 15:14, Liu Hao wrote: > 在 2019/7/2 下午8:00, Jonathan Wakely 写道: >> The C++ standard says: >> >> "The library may reuse the value of a thread::id of a terminated >> thread that can no longer be joined." >> >> So that's not a reason to use a handle. > > According to MSDN [1] a thread ID

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Liu Hao
在 2019/7/2 下午8:00, Jonathan Wakely 写道: > The C++ standard says: > > "The library may reuse the value of a thread::id of a terminated > thread that can no longer be joined." > > So that's not a reason to use a handle. According to MSDN [1] a thread ID is valid 'until the thread has been terminate

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jacek Caban
On 7/2/19 1:35 PM, LRN wrote: On 02.07.2019 13:42, Jacek Caban wrote: On 02/07/2019 12:38, LRN wrote: On 02.07.2019 13:15, Jacek Caban wrote: On 02/07/2019 12:12, Jacek Caban wrote: On 02/07/2019 11:57, Liu Hao wrote: 在 2019/7/2 下午5:19, Eric Botcazou 写道: It seems inappropriate to use handl

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread LRN
On 02.07.2019 13:42, Jacek Caban wrote: > > On 02/07/2019 12:38, LRN wrote: >> On 02.07.2019 13:15, Jacek Caban wrote: >>> On 02/07/2019 12:12, Jacek Caban wrote: On 02/07/2019 11:57, Liu Hao wrote: > 在 2019/7/2 下午5:19, Eric Botcazou 写道: >>> It seems inappropriate to use handles

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jacek Caban
On 02/07/2019 12:38, LRN wrote: On 02.07.2019 13:15, Jacek Caban wrote: On 02/07/2019 12:12, Jacek Caban wrote: On 02/07/2019 11:57, Liu Hao wrote: 在 2019/7/2 下午5:19, Eric Botcazou 写道: It seems inappropriate to use handles as thread identifiers (as handles imply resource ownership and are n

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread LRN
On 02.07.2019 13:15, Jacek Caban wrote: > > On 02/07/2019 12:12, Jacek Caban wrote: >> On 02/07/2019 11:57, Liu Hao wrote: >> >>> 在 2019/7/2 下午5:19, Eric Botcazou 写道: > It seems inappropriate to use handles as thread identifiers (as > handles > imply resource ownership and are not uni

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jacek Caban
On 02/07/2019 12:12, Jacek Caban wrote: On 02/07/2019 11:57, Liu Hao wrote: 在 2019/7/2 下午5:19, Eric Botcazou 写道: It seems inappropriate to use handles as thread identifiers (as handles imply resource ownership and are not unique identifiers); thread IDs (as `DWORD` or `unsigned long`) would

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jacek Caban
On 02/07/2019 11:57, Liu Hao wrote: 在 2019/7/2 下午5:19, Eric Botcazou 写道: It seems inappropriate to use handles as thread identifiers (as handles imply resource ownership and are not unique identifiers); thread IDs (as `DWORD` or `unsigned long`) would be a better alternative. This was consider

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Liu Hao
在 2019/7/2 下午5:19, Eric Botcazou 写道: >> It seems inappropriate to use handles as thread identifiers (as handles >> imply resource ownership and are not unique identifiers); thread IDs (as >> `DWORD` or `unsigned long`) would be a better alternative. > > This was considered but ultimately rejected,

Re: [Mingw-w64-public] [PATCH] crt: Correctly restore %edi on exit from __argtos().

2019-07-02 Thread Liu Hao
在 2019/6/30 下午3:57, Liu Hao 写道: > 在 2019/6/27 3:04, Zebediah Figura 写道: >> /* Make the call. */ >> call *20(%ebp) >> +addl $(iOffset + iBytes), %esp >> >> /* Restore stack. */ >> popl %edi >> > > This line should probably moved after `/* Restore stack. */`. > > > P