[Mingw-w64-public] [PATCH] crt: Call the right function for newmode from ucrtbase's __getmainargs

2019-05-17 Thread Martin Storsjö
This parameter should set the new mode, not the app type. This was a mistake from misreading the corresponding function in wine. Signed-off-by: Martin Storsjö --- mingw-w64-crt/crt/ucrtbase_compat.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mingw-w64-crt/crt/ucr

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Martin Storsjö
On Fri, 17 May 2019, Jacek Caban wrote: On 5/17/19 10:11 PM, Martin Storsjö wrote: On Fri, 17 May 2019, Jacek Caban wrote: I see it now. The problem seems to be wider than assert and caused by __set_app_type call in ucrtbase_main.c. If I remove them, it behaves correctly. Do you remember it's

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Jacek Caban
On 5/17/19 10:11 PM, Martin Storsjö wrote: On Fri, 17 May 2019, Jacek Caban wrote: I see it now. The problem seems to be wider than assert and caused by __set_app_type call in ucrtbase_main.c. If I remove them, it behaves correctly. Do you remember it's called there? Note that crtexe.c already

Re: [Mingw-w64-public] [PATCH] crt: Don't call __set_app_type from ucrtbase's __getmainargs

2019-05-17 Thread Jacek Caban
Signed-off-by: Jacek Caban ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] crt: Don't call __set_app_type from ucrtbase's __getmainargs

2019-05-17 Thread Martin Storsjö
The parameter newmode is always zero here, while __set_app_type already is called properly from crtexe.c. Signed-off-by: Martin Storsjö --- mingw-w64-crt/crt/ucrtbase_compat.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c b/mingw-w64-crt/crt/ucrtbase_c

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Martin Storsjö
On Fri, 17 May 2019, Jacek Caban wrote: I see it now. The problem seems to be wider than assert and caused by __set_app_type call in ucrtbase_main.c. If I remove them, it behaves correctly. Do you remember it's called there? Note that crtexe.c already sets app type correctly, but it's broken by

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Jacek Caban
On 5/17/19 10:02 PM, Jacek Caban wrote: The problem seems to be wider than assert and caused by __set_app_type call in ucrtbase_main.c. I obviously meant ucrtbase_compat.c. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourcefor

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Jacek Caban
On 5/17/19 9:21 PM, Martin Storsjö wrote: On Fri, 17 May 2019, Jacek Caban wrote: On 5/17/19 10:44 AM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: On 3/29/19 8:26 PM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Martin Storsjö
On Fri, 17 May 2019, Jacek Caban wrote: On 5/17/19 10:44 AM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: On 3/29/19 8:26 PM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am |  2 +-

Re: [Mingw-w64-public] Update OpenGL headers

2019-05-17 Thread Liu Hao
在 2019/5/18 0:16, Jacek Caban 写道: > > FWIW, I agree that we shouldn't have those headers in the tree. I don't > know if anyone already depends on that already, so I'm not sure what to > do... > > > As long as we have them in the tree, the update is fine with me. > Removal of things doesn't see

Re: [Mingw-w64-public] Update OpenGL headers

2019-05-17 Thread Jacek Caban
On 5/17/19 12:42 PM, LRN wrote: On 10.05.2019 16:28, LRN wrote: On 10.05.2019 15:53, NightStrike wrote: On Fri, May 10, 2019, 5:24 AM LRN wrote: TBH, i'm starting to think that we should radically cut the GL headers down and only ship GL.h and GLU.h, just like MS does (and also glaux.h, proba

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Jacek Caban
On 5/17/19 10:44 AM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: On 3/29/19 8:26 PM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am |  2 +- .../api-ms-win-crt-runtime-l1-1-0.def.in 

Re: [Mingw-w64-public] Update OpenGL headers

2019-05-17 Thread LRN
On 10.05.2019 16:28, LRN wrote: > On 10.05.2019 15:53, NightStrike wrote: >> On Fri, May 10, 2019, 5:24 AM LRN wrote: >> >>> TBH, i'm starting to think that we should radically cut the GL headers >>> down and >>> only ship GL.h and GLU.h, just like MS does (and also glaux.h, probably). >>> The >>>

Re: [Mingw-w64-public] [PATCH 1/2] crt: Use importlib for _assert.

2019-05-17 Thread Martin Storsjö
On Fri, 29 Mar 2019, Jacek Caban wrote: On 3/29/19 8:26 PM, Martin Storsjö wrote: On Fri, 29 Mar 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am |  2 +- .../api-ms-win-crt-runtime-l1-1-0.def.in  |  2 +- mingw-w64-crt/lib-common/msvcrt

Re: [Mingw-w64-public] snprintf() is broken in mingw-w64

2019-05-17 Thread sisyphus
Hi, Alternatively, you can compile the program with -D__USE_MINGW_ANSI_STDIO : C:\_32\C>type try.c /* try.c */ #include int main() { char buf[5] = ""; int ret = snprintf(buf, 3, "%d", 123456789); printf("buf=%s ret=%d\n", buf, ret); return 0; } C:\_32\C>gcc -o try.exe try