Re: [Mingw-w64-public] [PATCH] GCC: Introduce xaccess function in libiberty

2019-01-05 Thread Mateusz
W dniu 05.01.2019 o 20:59, Johannes Pfau pisze: > Am 05.01.19 um 18:56 schrieb Mateusz: >> ucrtbase.dll is affected too (msvcr100 works OK), so maybe it is better to >> add your access() function to msvcr110/120 and ucrtbase (as a replacement) >> instead of patching GCC. >> >> Regards, >> Mateusz

Re: [Mingw-w64-public] [PATCH] GCC: Introduce xaccess function in libiberty

2019-01-05 Thread Johannes Pfau
Am 05.01.19 um 18:56 schrieb Mateusz: ucrtbase.dll is affected too (msvcr100 works OK), so maybe it is better to add your access() function to msvcr110/120 and ucrtbase (as a replacement) instead of patching GCC. Regards, Mateusz Maybe it would make sense to add this in crt/io.h? There's alr

Re: [Mingw-w64-public] [PATCH] GCC: Introduce xaccess function in libiberty

2019-01-05 Thread Mateusz
W dniu 05.01.2019 o 15:32, Liu Hao pisze: > 在 2019/1/5 21:14, Johannes Pfau 写道: >> Liu Hao: >>> There are a few resolution to this at different levels. The most ideal >>> solution would be providing an `access()` function that behaves >>> expectedly in gnulib or libiberty, so this recipe can be por

Re: [Mingw-w64-public] [PATCH] GCC: Introduce xaccess function in libiberty

2019-01-05 Thread Liu Hao
在 2019/1/5 21:14, Johannes Pfau 写道: > Liu Hao: >> There are a few resolution to this at different levels. The most ideal >> solution would be providing an `access()` function that behaves >> expectedly in gnulib or libiberty, so this recipe can be ported >> elsewhere. Modifying GCC source should be

[Mingw-w64-public] [PATCH] GCC: Introduce xaccess function in libiberty

2019-01-05 Thread Johannes Pfau
Liu Hao: > There are a few resolution to this at different levels. The most ideal > solution would be providing an `access()` function that behaves > expectedly in gnulib or libiberty, so this recipe can be ported > elsewhere. Modifying GCC source should be considered the least preferred > and last