Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Liu Hao
在 2018/11/27 上午6:30, Jacek Caban 写道: > On 11/26/18 10:31 PM, Martin Storsjö wrote: >> >> In general the patch (the latest version) looks rather straightforward >> to me, and I'm fine with it if Jacek is. > > > With inline helpers kept for ucrt builds, I will be fine with the patch. > > Please

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Mateusz
W dniu 26.11.2018 o 23:30, Jacek Caban pisze: > On 11/26/18 10:31 PM, Martin Storsjö wrote: >> On Mon, 26 Nov 2018, Jacek Caban wrote: >> >>> Hi Mateusz, >>> >>> >>> The patch looks mostly good to me. >>> >>> >>> On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Jacek Caban
On 11/26/18 10:31 PM, Martin Storsjö wrote: On Mon, 26 Nov 2018, Jacek Caban wrote: Hi Mateusz, The patch looks mostly good to me. On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++ b/mingw-w64-headers/crt/stdio.h @@ -609,31 +609,20 @@ int vsnprintf (char *__stream

Re: [Mingw-w64-public] [PATCH] ntdllcrt: Use separated import library for ntdll.dll C runtime exports.

2018-11-26 Thread Martin Storsjö
On Mon, 26 Nov 2018, Jacek Caban wrote: ntdll exports a subset of crt functions and currently our importlib exposes them to linked application. This means that -lntdll is specified, an application will use ntdll.dll for things like strlen(). This is a very unexpected effect for majority of use

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Martin Storsjö
On Mon, 26 Nov 2018, Jacek Caban wrote: Hi Mateusz, The patch looks mostly good to me. On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++ b/mingw-w64-headers/crt/stdio.h @@ -609,31 +609,20 @@ int vsnprintf (char *__stream, size_t __n, const char *__format, __builti

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Mateusz
W dniu 26.11.2018 o 12:36, Jacek Caban pisze: > Hi Mateusz, > > > The patch looks mostly good to me. > > > On 23/11/2018 22:37, Mateusz wrote: >> --- a/mingw-w64-headers/crt/stdio.h >> +++ b/mingw-w64-headers/crt/stdio.h >> @@ -609,31 +609,20 @@ int vsnprintf (char *__stream, size_t __n, const

Re: [Mingw-w64-public] Description of files in a mingw-w64 distribution

2018-11-26 Thread Earnie via Mingw-w64-public
On 11/26/2018 1:34 PM, Edward Diener wrote: On 11/26/2018 10:06 AM, Earnie via Mingw-w64-public wrote: On 11/24/2018 5:27 PM, Edward Diener wrote: On 11/24/2018 5:18 PM, Earnie via Mingw-w64-public wrote: On 11/24/2018 3:17 PM, Edward Diener wrote: Is there anywhere a description of the files

Re: [Mingw-w64-public] Description of files in a mingw-w64 distribution

2018-11-26 Thread Edward Diener
On 11/26/2018 10:06 AM, Earnie via Mingw-w64-public wrote: On 11/24/2018 5:27 PM, Edward Diener wrote: On 11/24/2018 5:18 PM, Earnie via Mingw-w64-public wrote: On 11/24/2018 3:17 PM, Edward Diener wrote: Is there anywhere a description of the files in a mingw-w64 distribution, with perhaps an

[Mingw-w64-public] [PATCH] ntdllcrt: Use separated import library for ntdll.dll C runtime exports.

2018-11-26 Thread Jacek Caban
ntdll exports a subset of crt functions and currently our importlib exposes them to linked application. This means that -lntdll is specified, an application will use ntdll.dll for things like strlen(). This is a very unexpected effect for majority of use cases. Using NtReadFile shouldn't imply

Re: [Mingw-w64-public] Description of files in a mingw-w64 distribution

2018-11-26 Thread Earnie via Mingw-w64-public
On 11/24/2018 5:27 PM, Edward Diener wrote: On 11/24/2018 5:18 PM, Earnie via Mingw-w64-public wrote: On 11/24/2018 3:17 PM, Edward Diener wrote: Is there anywhere a description of the files in a mingw-w64 distribution, with perhaps an explanation of whether any given file is used at compile,

Re: [Mingw-w64-public] Problems with fseeko64, libstdc++ and ucrt builds

2018-11-26 Thread Jacek Caban
Hi Mateusz, The patch looks mostly good to me. On 23/11/2018 22:37, Mateusz wrote: --- a/mingw-w64-headers/crt/stdio.h +++ b/mingw-w64-headers/crt/stdio.h @@ -609,31 +609,20 @@ int vsnprintf (char *__stream, size_t __n, const char *__format, __builtin_va_li /* Shouldn't be any fseeko3