Re: [Mingw-w64-public] inttypes Format Specifiers

2018-10-30 Thread Liu Hao
在 2018/10/31 2:01, Jacek Caban 写道: > Wine has a test for that with a comment saying that it's supported since > Vista: > https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/msvcrt/tests/printf.c#l291 > > > I changed the test to accept only platforms properly handling %lld and > running it on T

Re: [Mingw-w64-public] inttypes Format Specifiers

2018-10-30 Thread Jacek Caban
On 30/10/2018 18:45, Mateusz wrote: W dniu 30.10.2018 o 17:04, Liu Hao pisze: 在 2018/10/30 23:48, Mateusz 写道: Liu Hao example is the explanation. printf("value = %" PRIx64 "\n", value); should print 64-bit int 'value' regardless stdio.h is included or not. Hmmm on my Windows 7 Professional

Re: [Mingw-w64-public] inttypes Format Specifiers

2018-10-30 Thread Mateusz
W dniu 30.10.2018 o 17:04, Liu Hao pisze: > 在 2018/10/30 23:48, Mateusz 写道: >> Liu Hao example is the explanation. >> printf("value = %" PRIx64 "\n", value); >> should print 64-bit int 'value' regardless stdio.h is included or not. >> >> > > Hmmm on my Windows 7 Professional [Version 6.1.7601 x64]

Re: [Mingw-w64-public] inttypes Format Specifiers

2018-10-30 Thread Liu Hao
在 2018/10/30 23:48, Mateusz 写道: > Liu Hao example is the explanation. > printf("value = %" PRIx64 "\n", value); > should print 64-bit int 'value' regardless stdio.h is included or not. > > Hmmm on my Windows 7 Professional [Version 6.1.7601 x64], the `printf()` function from MSVCRT actually reco

Re: [Mingw-w64-public] inttypes Format Specifiers

2018-10-30 Thread Mateusz
W dniu 30.10.2018 o 13:59, Jacek Caban pisze: > On 10/28/2018 10:28 PM, Mateusz wrote: >> W dniu 28.10.2018 o 16:07, Jacek Caban pisze: >>> >>> On 28/10/2018 09:39, Liu Hao wrote: 在 2018/10/27 19:52, Jacek Caban 写道: > I don't see what makes __USE_MINGW_ANSI_STDIO a correct solution. >

Re: [Mingw-w64-public] [patch] fix redefinition of _InterlockedAdd64 from wdm.h

2018-10-30 Thread Olivier Hainque
> On 30 Oct 2018, at 14:06, Liu Hao wrote: > > 在 2018/10/30 19:41, Olivier Hainque 写道: >> >> Patch and tentative rationale recalled below. >> >> Thanks in advance! > > Sorry for the late response. I forgot this patch. No problem at all. Thanks for getting back to me :) > As a pernament sol

Re: [Mingw-w64-public] [patch] fix redefinition of _InterlockedAdd64 from wdm.h

2018-10-30 Thread Liu Hao
在 2018/10/30 19:41, Olivier Hainque 写道: > > Patch and tentative rationale recalled below. > > Thanks in advance! Sorry for the late response. I forgot this patch. As a pernament solution I suggest removal of this duplicate definition, as no other `Interloced*64()` functions ever exist there. A

Re: [Mingw-w64-public] inttypes Format Specifiers

2018-10-30 Thread Jacek Caban
On 10/28/2018 10:28 PM, Mateusz wrote: > W dniu 28.10.2018 o 16:07, Jacek Caban pisze: >> >> On 28/10/2018 09:39, Liu Hao wrote: >>> 在 2018/10/27 19:52, Jacek Caban 写道: I don't see what makes __USE_MINGW_ANSI_STDIO a correct solution. Firefox builds use ucrt, which is sufficient for handl

Re: [Mingw-w64-public] [patch] fix redefinition of _InterlockedAdd64 from wdm.h

2018-10-30 Thread JonY via Mingw-w64-public
On 10/30/2018 11:41 AM, Olivier Hainque wrote: > Hello any opinion on the patch proposal at > https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/5116B7E0-7165-45FB-A87C-F68E9F25F45F%40adacore.com/#msg36444683 > ? > > Patch and tentative rationale recalled below. > > Thanks in adv

Re: [Mingw-w64-public] [patch] fix redefinition of _InterlockedAdd64 from wdm.h

2018-10-30 Thread Olivier Hainque
Hello any opinion on the patch proposal at https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/5116B7E0-7165-45FB-A87C-F68E9F25F45F%40adacore.com/#msg36444683 ? Patch and tentative rationale recalled below. Thanks in advance! Olivier --- a/mingw-w64-headers/ddk/include/ddk/wdm.h