[Mingw-w64-public] [PATCH v2] make winpthreads compatible with libcxx __attribute__((__require_constant_initialization__))

在 2018/10/25 20:38, Liu Hao 写道: > 在 2018/10/25 下午7:53, Peiyuan Song 写道: >> From: SquallATF >> -if (STATIC_RWL_INITIALIZER(*rwl)) *rwl = NULL; >> +if (STATIC_RWL_INITIALIZER(*rwl)) *rwl = 0; > > For consistency this should be `(pthread_rwlock_t)NULL;`. > > This patch looks good t

Re: [Mingw-w64-public] [PATCH] _mingw_mac.h: Enable WIDL_EXPLICIT_AGGREGATE_RETURNS workaround for ABI incompatibility on affected platforms

在 2018/10/25 下午9:00, Jacek Caban 写道: > Signed-off-by: Jacek Caban > --- > mingw-w64-headers/crt/_mingw_mac.h | 7 +++ > 1 file changed, 7 insertions(+) > > This patch looks good to me. Thanks. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature

[Mingw-w64-public] [PATCH] _mingw_mac.h: Enable WIDL_EXPLICIT_AGGREGATE_RETURNS workaround for ABI incompatibility on affected platforms

Signed-off-by: Jacek Caban --- mingw-w64-headers/crt/_mingw_mac.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/mingw-w64-headers/crt/_mingw_mac.h b/mingw-w64-headers/crt/_mingw_mac.h index bd83873e..c5d1a0d4 100644 --- a/mingw-w64-headers/crt/_mingw_mac.h +++ b/mingw-w64-headers/cr

Re: [Mingw-w64-public] [PATCH] _mingw_mac.h: Enable WIDL_EXPLICIT_AGGREGATE_RETURNS workaround for ABI incompatibility on affected platforms

On 10/25/2018 02:50 PM, Liu Hao wrote: > 在 2018/10/25 下午8:41, Jacek Caban 写道: >> This is known to be broken in GCC for a while: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52792 >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52792 >> >> And it's apparently the same on clang: >> https://bugzill

Re: [Mingw-w64-public] [PATCH] _mingw_mac.h: Enable WIDL_EXPLICIT_AGGREGATE_RETURNS workaround for ABI incompatibility on affected platforms

在 2018/10/25 下午8:41, Jacek Caban 写道: > This is known to be broken in GCC for a while: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52792 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52792 > > And it's apparently the same on clang: > https://bugzilla.mozilla.org/show_bug.cgi?id=1500490 > > ---

[Mingw-w64-public] [PATCH] _mingw_mac.h: Enable WIDL_EXPLICIT_AGGREGATE_RETURNS workaround for ABI incompatibility on affected platforms

This is known to be broken in GCC for a while: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52792 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52792 And it's apparently the same on clang: https://bugzilla.mozilla.org/show_bug.cgi?id=1500490 --- mingw-w64-headers/crt/_mingw_mac.h | 7 +++ 1 f

Re: [Mingw-w64-public] [PATCH v2] make winpthreads compatible with libcxx __attribute__((__require_constant_initialization__))

在 2018/10/25 下午7:53, Peiyuan Song 写道: > From: SquallATF > > libcxx defined `_LIBCPP_SAFE_STATIC` for static variable, if use winpthreads > need `PTHREAD_*_INITIALIZER` constant, but current version have > `reinterpret_cast` to convert integer initial value to pointer, > `__attribute__((__requi

[Mingw-w64-public] [PATCH v2] make winpthreads compatible with libcxx __attribute__((__require_constant_initialization__))

From: SquallATF libcxx defined `_LIBCPP_SAFE_STATIC` for static variable, if use winpthreads need `PTHREAD_*_INITIALIZER` constant, but current version have `reinterpret_cast` to convert integer initial value to pointer, `__attribute__((__require_constant_initialization__))` not allowed this d

Re: [Mingw-w64-public] [PATCH] make winpthreads compatible with libcxx __attribute__((__require_constant_initialization__))

Sorry, this is my first time use git send-email. I will try to rewrite patch use `intptr_t` directly. JonY 于2018年10月25日周四 下午5:51写道： > On 10/25/2018 07:36 AM, Liu Hao wrote: > > 在 2018/10/25 下午3:06, Peiyuan Song 写道: > >> From: SquallATF > >> > >> Signed-off-by: SquallATF > >> --- > >> .../winp

Re: [Mingw-w64-public] [PATCH] make winpthreads compatible with libcxx __attribute__((__require_constant_initialization__))

On 10/25/2018 07:36 AM, Liu Hao wrote: > 在 2018/10/25 下午3:06, Peiyuan Song 写道: >> From: SquallATF >> >> Signed-off-by: SquallATF >> --- >> .../winpthreads/include/pthread.h | 42 +- >> mingw-w64-libraries/winpthreads/src/cond.c| 56 +- >> mingw-w64-lib

Re: [Mingw-w64-public] [PATCH] make winpthreads compatible with libcxx __attribute__((__require_constant_initialization__))

在 2018/10/25 下午3:06, Peiyuan Song 写道: > From: SquallATF > > Signed-off-by: SquallATF > --- > .../winpthreads/include/pthread.h | 42 +- > mingw-w64-libraries/winpthreads/src/cond.c| 56 +- > mingw-w64-libraries/winpthreads/src/mutex.c | 27 -

[Mingw-w64-public] [PATCH] make winpthreads compatible with libcxx __attribute__((__require_constant_initialization__))

From: SquallATF Signed-off-by: SquallATF --- .../winpthreads/include/pthread.h | 42 +- mingw-w64-libraries/winpthreads/src/cond.c| 56 +- mingw-w64-libraries/winpthreads/src/mutex.c | 27 - mingw-w64-libraries/winpthreads/src/rwlock.c | 57