Re: [Mingw-w64-public] #define daylight causes conflicts

2018-08-28 Thread Liu Hao
在 2018-08-29 14:20, Martin Storsjö 写道: > However, this doesn’t work, since _daylight isn’t a variable when building > with the UCRT; it’s another define: > > _CRTIMP int *__cdecl __daylight(void); > #define _daylight (* __daylight()) > > We could, however, do the same as we do for timezone; prov

Re: [Mingw-w64-public] #define daylight causes conflicts

2018-08-28 Thread Martin Storsjö
> On Aug 29, 2018, at 05:27, Liu Hao wrote: > > 在 2018/8/29 4:36, Tom Ritter 写道: >> I hit this issue compiling ICU as part of Firefox, where they had a >> variable named 'daylight'. >> https://unicode-org.atlassian.net/browse/ICU-20100 was filed to change >> the variable name; but I wanted to bri

Re: [Mingw-w64-public] #define daylight causes conflicts

2018-08-28 Thread Liu Hao
在 2018/8/29 4:36, Tom Ritter 写道: I hit this issue compiling ICU as part of Firefox, where they had a variable named 'daylight'. https://unicode-org.atlassian.net/browse/ICU-20100 was filed to change the variable name; but I wanted to bring it up since these types of defines are inevitably cause

[Mingw-w64-public] #define daylight causes conflicts

2018-08-28 Thread Tom Ritter
In mingw-w64-headers/crt/time.h: #if __MSVCRT_VERSION__ >= 0x1400 #define __MINGW_ATTRIB_DEPRECATED_UCRT \ __MINGW_ATTRIB_DEPRECATED_MSG( \ "Only provided for source compatibility; this variable might " \ "not always be accurate when linking to ucrtbase.dll.") #define daylight

Re: [Mingw-w64-public] [PATCH] crt: Check whether the linker provides __CTOR_LIST__, don't check for __clang__

2018-08-28 Thread Martin Storsjö
> On Aug 28, 2018, at 05:58, Liu Hao wrote: > > 在 2018/8/28 2:50, Martin Storsjö 写道: >> Using the __clang__ ifdef isn't right; one could be using clang for >> compiling the mingw-w64 crt for use with binutils ld, which requires >> a slightly different setup of __CTOR_LIST__. >> >> Also, to ease

Re: [Mingw-w64-public] [PATCH] libmincore.a: Add new importlib.

2018-08-28 Thread Martin Storsjö
> On Aug 27, 2018, at 22:07, Jacek Caban wrote: > > On 08/27/2018 08:44 PM, Martin Storsjö wrote: >> On Mon, 27 Aug 2018, Jacek Caban wrote: >> >>> Please review the attached patch. >>> >>> Note that it adds .mri file in a different way than those that are >>> currently in the tree. I don't lik

[Mingw-w64-public] [PATCH v2] SID_NAME_USE: add SidTypeLogonSession

2018-08-28 Thread Corinna Vinschen
This is a Windows 10 addition. For reference, see https://docs.microsoft.com/en-us/windows/desktop/api/winnt/ne-winnt-_sid_name_use Signed-off-by: Corinna Vinschen --- mingw-w64-headers/ddk/include/ddk/ntifs.h | 3 ++- mingw-w64-headers/include/winnt.h | 2 +- 2 files changed, 3 inserti

Re: [Mingw-w64-public] [PATCH] SID_NAME_USE: add SidTypeLogonSession

2018-08-28 Thread Jacek Caban
Hi Corinna, On 08/28/2018 11:06 AM, Corinna Vinschen wrote: > This is a Windows 10 addition. For reference, see > https://docs.microsoft.com/en-us/windows/desktop/api/winnt/ne-winnt-_sid_name_use > > Signed-off-by: Corinna Vinschen > --- > mingw-w64-headers/ddk/include/ddk/ntifs.h | 3 ++- > mi

Re: [Mingw-w64-public] [PATCH] crt: Change comment char from * to ; in mincore.mri

2018-08-28 Thread Jacek Caban
On 08/28/2018 09:53 AM, Martin Storsjö wrote: > llvm-ar doesn't yet support * as comment char, only ;. > > Signed-off-by: Martin Storsjö > --- > A patch to add support for * as comment char in llvm-ar has been sent > for review though. It looks good to me. Sorry for not checking llvm build. Than

[Mingw-w64-public] [PATCH] SID_NAME_USE: add SidTypeLogonSession

2018-08-28 Thread Corinna Vinschen
This is a Windows 10 addition. For reference, see https://docs.microsoft.com/en-us/windows/desktop/api/winnt/ne-winnt-_sid_name_use Signed-off-by: Corinna Vinschen --- mingw-w64-headers/ddk/include/ddk/ntifs.h | 3 ++- mingw-w64-headers/include/winnt.h | 2 +- mingw-w64-tools/widl/inclu

[Mingw-w64-public] [PATCH] crt: Change comment char from * to ; in mincore.mri

2018-08-28 Thread Martin Storsjö
llvm-ar doesn't yet support * as comment char, only ;. Signed-off-by: Martin Storsjö --- A patch to add support for * as comment char in llvm-ar has been sent for review though. --- mingw-w64-crt/lib-common/mincore.mri | 206 +-- 1 file changed, 103 insertions(+),