Re: [Mingw-w64-public] [PATCH] [RFC] headers: Skip the mingw specific stdio functions if ucrt is used

2018-08-03 Thread Liu Hao
在 2018/8/4 10:12, Liu Hao 写道: > 在 2018/8/4 5:12, Martin Storsjö 写道: >> In these cases, the default ucrt functions already are C99 compatible, >> so even if the caller has requested to use the mingw version, by >> defining __USE_MINGW_ANSI_STDIO, the ucrt version should be fine. >> >> Or does there

Re: [Mingw-w64-public] [PATCH] [RFC] headers: Skip the mingw specific stdio functions if ucrt is used

2018-08-03 Thread Liu Hao
在 2018/8/4 5:12, Martin Storsjö 写道: > In these cases, the default ucrt functions already are C99 compatible, > so even if the caller has requested to use the mingw version, by > defining __USE_MINGW_ANSI_STDIO, the ucrt version should be fine. > > Or does there exit any case with non-C99, mingw sp

[Mingw-w64-public] [PATCH] [RFC] headers: Skip the mingw specific stdio functions if ucrt is used

2018-08-03 Thread Martin Storsjö
In these cases, the default ucrt functions already are C99 compatible, so even if the caller has requested to use the mingw version, by defining __USE_MINGW_ANSI_STDIO, the ucrt version should be fine. Or does there exit any case with non-C99, mingw specific features that a caller would expect to

Re: [Mingw-w64-public] [PATCHv2 1/4] crt: Add an implementation of __cxa_atexit and __cxa_thread_atexit

2018-08-03 Thread Liu Hao
在 2018/8/3 18:36, Martin Storsjö 写道: > Are you sure that you installed the latest set of headers as well? I > added this new typedef and a function declaration in one of the patches. > > // Martin .. you are right, On my system a header is installed into '/mingw64/include/process.h' unintention

Re: [Mingw-w64-public] [PATCHv2 1/4] crt: Add an implementation of __cxa_atexit and __cxa_thread_atexit

2018-08-03 Thread Martin Storsjö
On Fri, 3 Aug 2018, Liu Hao wrote: 在 2018/8/3 4:18, Martin Storsjö 写道: Renamed the typedef to dtor_fn These 4 patches look good to me. Thanks for the thorough review! Pushed. Compiling with GCC 8.2 now fails with this error: ``` E:/GitHub/MINGW-packages/mingw-w64-crt-git/src/mingw-w64/m

Re: [Mingw-w64-public] [PATCH] Add some missing features to shlwapi header

2018-08-03 Thread JonY via Mingw-w64-public
On 08/01/2018 04:52 AM, Alexey Pavlov wrote: > Patch OK. signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http:/

Re: [Mingw-w64-public] [PATCHv2 1/4] crt: Add an implementation of __cxa_atexit and __cxa_thread_atexit

2018-08-03 Thread Liu Hao
在 2018/8/3 4:18, Martin Storsjö 写道: > Renamed the typedef to dtor_fn > >> These 4 patches look good to me. > > Thanks for the thorough review! Pushed. > > Compiling with GCC 8.2 now fails with this error: ``` E:/GitHub/MINGW-packages/mingw-w64-crt-git/src/mingw-w64/mingw-w64-crt/misc/register_t