Re: [Mingw-w64-public] Oatcg for mingw-w64-crt - Fix fallthrough warnings

2018-03-12 Thread Liu Hao
在 03/12/2018 11:23 PM, jpmug...@suddenlink.net 写道: > Anyway, the fix adds a macro that I barrowed from Graphite2 and further > modified. > Graphite2 is LGPL's, so copying code from there is not an option. > > > I hope gets through. > > > > Interestingly enough, part of the issue with tool

Re: [Mingw-w64-public] [PATCH] crt: Add "volatile" to all inline assembly snippets under math

2018-03-12 Thread Martin Storsjö
On Mon, 12 Mar 2018, Martin Storsjö wrote: On Sun, 11 Mar 2018, David Grayson wrote: Martell, did you send a bug report to clang too? That seems like a serious bug for them to have. I didn't send one yet, but I will. It's curious as it seems to work fine for x86_64 though. I reported the

Re: [Mingw-w64-public] [PATCH] crt: x86: Add missing clobbers in the cossin inline assembly

2018-03-12 Thread Martin Storsjö
On Mon, 12 Mar 2018, Kai Tietz via Mingw-w64-public wrote: Thanks for fixing this. Please apply. Thanks, pushed. // Martin -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slas

Re: [Mingw-w64-public] [PATCH] crt: Add "volatile" to all inline assembly snippets under math

2018-03-12 Thread Martell Malone
No worries :) Just wanted to make sure you knew who you were talking to. On Mon 12 Mar 2018 at 13:55, David Grayson wrote: > Sorry to both of you. My brain just messed up there and I only > realized when it was too late. > > --David > > On Mon, Mar 12, 2018 at 1:37 PM, Martell Malone > wrote:

Re: [Mingw-w64-public] [PATCH] crt: Add "volatile" to all inline assembly snippets under math

2018-03-12 Thread David Grayson
Sorry to both of you. My brain just messed up there and I only realized when it was too late. --David On Mon, Mar 12, 2018 at 1:37 PM, Martell Malone wrote: > Just so you are aware that is Martin not Martell. > Not sure if that was just an autocorrect or a typo but Martin is the one > doing thi

Re: [Mingw-w64-public] [PATCH] crt: x86: Add missing clobbers in the cossin inline assembly

2018-03-12 Thread Kai Tietz via Mingw-w64-public
Thanks for fixing this. Please apply. Kai 2018-03-12 21:34 GMT+01:00 Martin Storsjö : > This fixes the function when built with clang. > > Signed-off-by: Martin Storsjö > --- > mingw-w64-crt/math/x86/cossin.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mingw-

Re: [Mingw-w64-public] [PATCH] crt: Add "volatile" to all inline assembly snippets under math

2018-03-12 Thread Martell Malone
Just so you are aware that is Martin not Martell. Not sure if that was just an autocorrect or a typo but Martin is the one doing this work here. On Mon 12 Mar 2018 at 12:20, Martin Storsjö wrote: > On Mon, 12 Mar 2018, Martin Storsjö wrote: > > > On Sun, 11 Mar 2018, David Grayson wrote: > > > >

[Mingw-w64-public] [PATCH] crt: x86: Add missing clobbers in the cossin inline assembly

2018-03-12 Thread Martin Storsjö
This fixes the function when built with clang. Signed-off-by: Martin Storsjö --- mingw-w64-crt/math/x86/cossin.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mingw-w64-crt/math/x86/cossin.c b/mingw-w64-crt/math/x86/cossin.c index 0095daa..cb33405 100644 --- a/mingw-w

Re: [Mingw-w64-public] [PATCH] crt: Add "volatile" to all inline assembly snippets under math

2018-03-12 Thread Martin Storsjö
On Mon, 12 Mar 2018, Martin Storsjö wrote: On Sun, 11 Mar 2018, David Grayson wrote: Martell, did you send a bug report to clang too? That seems like a serious bug for them to have. I didn't send one yet, but I will. It's curious as it seems to work fine for x86_64 though. Also, "asm vo

Re: [Mingw-w64-public] genlib 0 can not compile

2018-03-12 Thread jpmugaas
Yes. I now get this: Building genlib ... configure: loading site script /etc/config.site checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /usr/bin/mkdir -p checking for gawk... gawk checking

[Mingw-w64-public] Oatcg for mingw-w64-crt - Fix fallthrough warnings

2018-03-12 Thread jpmugaas
I have made a patch to fix fallthrough warnings that I was seeing with GNU GCC 7.3 and I suspect could also with Clang 3.0.1. Please see: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7 / . The thing is that these new warnings were developed because programers w

Re: [Mingw-w64-public] [PATCH] crt: Add "volatile" to all inline assembly snippets under math

2018-03-12 Thread Martin Storsjö
On Sun, 11 Mar 2018, David Grayson wrote: Martell, did you send a bug report to clang too? That seems like a serious bug for them to have. I didn't send one yet, but I will. It's curious as it seems to work fine for x86_64 though. Also, "asm volatile" statements cannot be removed, reorder

Re: [Mingw-w64-public] Deadlock in winpthreads' pthread_cond_signal()

2018-03-12 Thread Sitsofe Wheeler
On 10 March 2018 at 12:55, Liu Hao wrote: > 在 2018/3/10 20:46, Sitsofe Wheeler 写道: >> On 10 March 2018 at 12:38, Liu Hao wrote: >>> 在 2018/3/10 20:06, Sitsofe Wheeler 写道: Reattaching example program with .txt extension and just in case you can also download it from http://sucs.org/~sits