Re: [Mingw-w64-public] [PATCH] stdio/mingw_wvfscanf.c: Fix segmentation fault when a char or, string format (without malloc option) is used, like, 72d60c1a06490ec5937e6c620956b167bf0bf329.

2017-11-16 Thread Liu Hao
On 2017/11/15 9:54, Liu Hao wrote: > This patches addresses the issue in > . > > The C99 standard treats %s, %c, %ls and %lc identically in *scanf and w*scanf, > hence this patch is merely copy-pasting from > 72d60c1a06490ec5937e6c62

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

2017-11-16 Thread Martin Storsjö
On Thu, 16 Nov 2017, Martin Storsjö wrote: On Thu, 16 Nov 2017, Jacek Caban wrote: On 16.11.2017 14:59, Martin Storsjö wrote: On Thu, 16 Nov 2017, Jacek Caban wrote: Hi Martin, The patch looks generally good to me. I'm fine with committing it.

Re: [Mingw-w64-public] [PATCH] crt: Add an alias from _ftime to _ftime32 for ucrtbase

2017-11-16 Thread Martin Storsjö
On Tue, 14 Nov 2017, Martin Storsjö wrote: For 32 bit platforms, the "ftime" function ends up as a reference to _ftime. We could do this in the headers, but MSVC has got a similar linker alias, so this solution should also cover cases when a caller ends up with a reference to _ftime via some ot

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

2017-11-16 Thread Martin Storsjö
On Thu, 16 Nov 2017, Martin Storsjö wrote: On Thu, 16 Nov 2017, Jacek Caban wrote: On 16.11.2017 14:59, Martin Storsjö wrote: On Thu, 16 Nov 2017, Jacek Caban wrote: Hi Martin, The patch looks generally good to me. I'm fine with committing it.

Re: [Mingw-w64-public] Finding runtime version

2017-11-16 Thread JonY via Mingw-w64-public
On 11/16/2017 02:30 PM, niXman wrote: > JonY via Mingw-w64-public 2017-11-16 17:26: > >> master should be Major 6, v5.x should be bugfix level 4. > > done. > ok for commit? > Looks good. signature.asc Description: OpenPGP digital signature -

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

2017-11-16 Thread Martin Storsjö
On Thu, 16 Nov 2017, Jacek Caban wrote: On 16.11.2017 14:59, Martin Storsjö wrote: On Thu, 16 Nov 2017, Jacek Caban wrote: Hi Martin, The patch looks generally good to me. I'm fine with committing it. As a side note, I expect this patch to

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

2017-11-16 Thread Martin Storsjö
On Thu, 16 Nov 2017, Jacek Caban wrote: On 16.11.2017 14:40, Martin Storsjö wrote: On Thu, 16 Nov 2017, Jacek Caban wrote: Hi Martin, On 15.11.2017 21:06, Martin Storsjö wrote: diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c b/mingw-w64-crt/crt/ucrtbase_compat.c index c02c476..4f840ea 1006

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

2017-11-16 Thread Jacek Caban
On 16.11.2017 14:59, Martin Storsjö wrote: > On Thu, 16 Nov 2017, Jacek Caban wrote: > >> Hi Martin, >> >> The patch looks generally good to me. I'm fine with committing it. >> >> As a side note, I expect this patch to also fix winpthread (built with >> toolchain defaulting default msvcrt.dll) link

Re: [Mingw-w64-public] Finding runtime version

2017-11-16 Thread niXman
JonY via Mingw-w64-public 2017-11-16 17:26: master should be Major 6, v5.x should be bugfix level 4. done. ok for commit? -- Regards, niXman ___ Work for Bitcoins ___ Dual-target(32 & 64-bit) MinG

Re: [Mingw-w64-public] Finding runtime version

2017-11-16 Thread JonY via Mingw-w64-public
On 11/15/2017 01:32 PM, niXman wrote: > > Kai, JonY, > > ok for commit for master and v5x? > master should be Major 6, v5.x should be bugfix level 4. signature.asc Description: OpenPGP digital signature -- Check out t

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

2017-11-16 Thread Jacek Caban
On 16.11.2017 14:40, Martin Storsjö wrote: > On Thu, 16 Nov 2017, Jacek Caban wrote: > >> Hi Martin, >> >> On 15.11.2017 21:06, Martin Storsjö wrote: >>> diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c >>> b/mingw-w64-crt/crt/ucrtbase_compat.c >>> index c02c476..4f840ea 100644 >>> --- a/mingw-w64-

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

2017-11-16 Thread Martin Storsjö
On Thu, 16 Nov 2017, Jacek Caban wrote: Hi Martin, The patch looks generally good to me. I'm fine with committing it. As a side note, I expect this patch to also fix winpthread (built with toolchain defaulting default msvcrt.dll) linking problems that I saw when tried your patches. On 15.11.2

Re: [Mingw-w64-public] [PATCH] ucrtbase: Provide most common *printf functions as non-inline functions

2017-11-16 Thread Jacek Caban
Hi Martin, The patch looks generally good to me. I'm fine with committing it. As a side note, I expect this patch to also fix winpthread (built with toolchain defaulting default msvcrt.dll) linking problems that I saw when tried your patches. On 15.11.2017 23:11, Martin Storsjö wrote: > This all

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

2017-11-16 Thread Martin Storsjö
On Thu, 16 Nov 2017, Jacek Caban wrote: Hi Martin, On 15.11.2017 21:06, Martin Storsjö wrote: diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c b/mingw-w64-crt/crt/ucrtbase_compat.c index c02c476..4f840ea 100644 --- a/mingw-w64-crt/crt/ucrtbase_compat.c +++ b/mingw-w64-crt/crt/ucrtbase_compat.

Re: [Mingw-w64-public] [PATCH] crt: Provide compat wrappers for the unprefixed "timezone" and "tzname"

2017-11-16 Thread Jacek Caban
Hi Martin, On 15.11.2017 21:06, Martin Storsjö wrote: > diff --git a/mingw-w64-crt/crt/ucrtbase_compat.c > b/mingw-w64-crt/crt/ucrtbase_compat.c > index c02c476..4f840ea 100644 > --- a/mingw-w64-crt/crt/ucrtbase_compat.c > +++ b/mingw-w64-crt/crt/ucrtbase_compat.c > @@ -24,6 +24,7 @@ > #include