Patch is okay. Please go ahead ans commit.
Thanks
Kai
Am 07.11.2017 08:42 schrieb "Martin Storsjö" :
> Signed-off-by: Martin Storsjö
> ---
> mingw-w64-headers/crt/_mingw_mac.h | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/mingw-w64-headers/crt/_mingw_mac.h b/mingw-w64-headers/cr
Patch is okay. Please commit.
Thanks
Kai
Am 07.11.2017 08:42 schrieb "Martin Storsjö" :
> On Tue, 7 Nov 2017, Martell Malone wrote:
>
> ping. :)
>> I think this is being lost between all the different patches being
>> submitted atm.
>>
>
> The patch looks good to me although I'm not very familiar
Signed-off-by: Martin Storsjö
---
mingw-w64-headers/crt/_mingw_mac.h | 4
1 file changed, 4 insertions(+)
diff --git a/mingw-w64-headers/crt/_mingw_mac.h
b/mingw-w64-headers/crt/_mingw_mac.h
index eeb59c6..e60e8d7 100644
--- a/mingw-w64-headers/crt/_mingw_mac.h
+++ b/mingw-w64-headers/crt/
On Tue, 7 Nov 2017, Martell Malone wrote:
ping. :)
I think this is being lost between all the different patches being
submitted atm.
The patch looks good to me although I'm not very familiar with those
areas. Assuming you've tested it, it looks good to me.
// Martin
---
Move the format attribute to the right spot, use unique variables
in the asprintf function (previously there were two variables
named ret), use properly reserved identifiers throughout both
functions.
Signed-off-by: Martin Storsjö
---
Now with __format__ instead of format, in the attribute.
---
ping. :)
I think this is being lost between all the different patches being
submitted atm.
On Sun, Nov 5, 2017 at 3:07 AM, Martell Malone
wrote:
> different variations of -march can be passed to the compiler.
> this fixes mingw-w64 when __i686__ is not present.
>
> Please Review.
>
> diff --git
On 2017/11/7 14:23, Martin Storsjö wrote:
__attribute__ ((format (__MINGW_PRINTF_FORMAT, 2, 0)))
I think this should be `__attribute__((__format__ ... ))`, as in
`_snprintf`.
I just took a look at other functions in , and yes, there are a
number of such issues, with a few more (such as th
Move the format attribute to the right spot, use unique variables
in the asprintf function (previously there were two variables
named ret), use properly reserved identifiers throughout both
functions.
Signed-off-by: Martin Storsjö
---
mingw-w64-headers/crt/stdio.h | 30 --
On Tue, 7 Nov 2017, Liu Hao wrote:
On 2017/11/7 13:19, Martin Storsjö wrote:
Not really, it mostly comes from whichever wording was used in the place it
was copypasted from. Since these identifiers aren't visible outside of the
inline function, I don't see how it would matter. If you feel stro
On 2017/11/7 13:19, Martin Storsjö wrote:
Not really, it mostly comes from whichever wording was used in the place
it was copypasted from. Since these identifiers aren't visible outside
of the inline function, I don't see how it would matter. If you feel
strongly about it, there's a huge number
On Tue, 7 Nov 2017, Liu Hao wrote:
On 2017/11/7 6:19, Martin Storsjö wrote:
Signed-off-by: Martin Storsjö
---
mingw-w64-headers/crt/stdio.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mingw-w64-headers/crt/stdio.h b/mingw-w64-headers/crt/stdio.h
index 7365994
On 7 November 2017 at 01:09, JonY via Mingw-w64-public
wrote:
>
> On 11/04/2017 09:02 PM, Alon Bar-Lev wrote:
> > Hi,
> >
> > I see that the patch to add winpthreads was finally merged, this is great as
> > we can patch less the build system at Gentoo.
> >
> > Here are additional two patches:
> >
On 2017/11/7 6:19, Martin Storsjö wrote:
Signed-off-by: Martin Storsjö
---
mingw-w64-headers/crt/stdio.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mingw-w64-headers/crt/stdio.h b/mingw-w64-headers/crt/stdio.h
index 7365994..cea5559 100644
--- a/mingw-w64-head
On 11/04/2017 09:02 PM, Alon Bar-Lev wrote:
> Hi,
>
> I see that the patch to add winpthreads was finally merged, this is great as
> we can patch less the build system at Gentoo.
>
> Here are additional two patches:
> 1. Enable build of pseh only in supported architecture
> 2. Enable comma-separa
This avoids having libmingwex refer to the dllimported data symbol
from msvcrt.dll, easing linking to ucrtbase.dll which doesn't have
it exported as a data symbol.
Signed-off-by: Martin Storsjö
---
mingw-w64-headers/crt/ctype.h | 2 +-
mingw-w64-headers/crt/stdlib.h | 2 +-
2 files changed, 2 i
Signed-off-by: Martin Storsjö
---
mingw-w64-headers/crt/stdio.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mingw-w64-headers/crt/stdio.h b/mingw-w64-headers/crt/stdio.h
index 7365994..cea5559 100644
--- a/mingw-w64-headers/crt/stdio.h
+++ b/mingw-w64-headers/crt/s
This simplifies the compat wrapper quite significantly, and the
workarounds weren't sufficient in any case (the local __mb_cur_max
value only was updated if the current module set the locale).
Signed-off-by: Martin Storsjö
---
mingw-w64-crt/crt/ucrtbase_compat.c | 39
On Sun, 5 Nov 2017, Martell Malone wrote:
LGTM
On Sun, Nov 5, 2017 at 7:49 PM, Martin Storsjö wrote:
Since clang 3.4, __debugbreak is limited to -fms-extensions
and thus not available by default when targeting mingw.
Signed-off-by: Martin Storsjö
---
mingw-w64-headers/crt/_mingw.h.in | 7
18 matches
Mail list logo
