[Mingw-w64-public] [PATCH 2/2 v2] sal.h: Disable __in and __out macros when using libstdc++.

2017-05-29 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-headers/include/sal.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mingw-w64-headers/include/sal.h b/mingw-w64-headers/include/sal.h index 8542a175..ef2e3d67 100644 --- a/mingw-w64-headers/include/sal.h +++ b/mingw-w64-heade

Re: [Mingw-w64-public] [PATCH 2/2] sal.h: Disable __in and __out macros when using libstdc++.

2017-05-29 Thread Jacek Caban
Hi David, Good catch, thanks. I sent a fixed version. Jacek On 5/29/17 9:56 PM, David Grayson wrote: The boolean logic in the patch looks wrong to me. You're going to end up disabling __in and __out for all GCC and Clang programs regardless of what language they use because __GNUC__ will b

Re: [Mingw-w64-public] [PATCH 2/2] sal.h: Disable __in and __out macros when using libstdc++.

2017-05-29 Thread David Grayson
The boolean logic in the patch looks wrong to me. You're going to end up disabling __in and __out for all GCC and Clang programs regardless of what language they use because __GNUC__ will be defined. Seems like this would be better: #if defined(__cplusplus) && defined(__GNUC__) // Don't define _

[Mingw-w64-public] [PATCH 1/2] sal.h: Moved macros belonging to sal.h from drsiverspecs.h.

2017-05-29 Thread Jacek Caban
There were some discussions about recent libstdc++ breackage, but I didn't see any fix committed, so here is my proposal. The first patch is just about doing (read: breaking) things in the right place instead of a random unrelated header. Please review. Signed-off-by: Jacek Caban --- mingw-w

[Mingw-w64-public] [PATCH 2/2] sal.h: Disable __in and __out macros when using libstdc++.

2017-05-29 Thread Jacek Caban
I've seen a very good news that a fix to libstdc++ is on its way and that's great. However, we need to support already released versions as well. That's why I propose this patch. Ideally, we'd use __GLIBCXX__ macro, but it's not available without including any standard header and sal.h is not a

Re: [Mingw-w64-public] Is there a libbacktrace library for mingw-64/gcc

2017-05-29 Thread niXman
Edward Diener 2017-05-29 05:26: Following instructions I eventually get under MSYS2: -> libiconv --> download libiconv-1.14.tar.gz... done --> unpack libiconv-1.14.tar.gz... done --> patching... Not found level for patch libiconv/0001-compile-relocatable-in-gnulib.mingw.patch, error=2 This is

Re: [Mingw-w64-public] Is there a libbacktrace library for mingw-64/gcc

2017-05-29 Thread niXman
Edward Diener 2017-05-29 05:26: Following instructions I eventually get under MSYS2: -> libiconv --> download libiconv-1.14.tar.gz... done --> unpack libiconv-1.14.tar.gz... done --> patching... Not found level for patch libiconv/0001-compile-relocatable-in-gnulib.mingw.patch, error=2 You're

Re: [Mingw-w64-public] Is there a libbacktrace library for mingw-64/gcc

2017-05-29 Thread niXman
Edward Diener 2017-05-29 05:26: Following instructions I eventually get under MSYS2: -> libiconv --> download libiconv-1.14.tar.gz... done --> unpack libiconv-1.14.tar.gz... done --> patching... Not found level for patch libiconv/0001-compile-relocatable-in-gnulib.mingw.patch, error=2 It's V