Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread Liu Hao
On 2017/5/17 23:04, David Grayson wrote: > Now that I think about it again, given that driverspecs.h does not > define __in or __out, I am actually in favor of Mateusz's patch now, > because it will make mingw-w64 closer to the official Windows headers. ... no, because you no longer have `__in` or

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread Mateusz
W dniu 2017-05-17 o 16:35, Kai Tietz pisze: > 2017-05-17 16:25 GMT+02:00 David Grayson : >> On Wed, May 17, 2017 at 4:10 AM, Kai Tietz wrote: >>> The best solution would be something like to include >>> driverspecs.h in specstring.h only, if user intends to use ddk. >> >> Is that how the real DDK

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread David Grayson
On Wed, May 17, 2017 at 7:30 AM, Kai Tietz wrote: > This sed command is nice, but nothing to be recommended for our users. > Driver buiding is for sure the more rare case, and most users won't be > interested in that pretty much. For those which are, this might be a > way. > > Once again, why we

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread Kai Tietz
2017-05-17 16:25 GMT+02:00 David Grayson : > On Wed, May 17, 2017 at 4:10 AM, Kai Tietz wrote: >> The best solution would be something like to include >> driverspecs.h in specstring.h only, if user intends to use ddk. > > Is that how the real DDK works? When you don't have the DDK > installed, yo

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread Kai Tietz
2017-05-17 16:10 GMT+02:00 David Grayson : > Here's the sed command again, without bad line wrapping: > > https://gist.github.com/DavidEGrayson/ee9796a900eedda3d6b7c8f2324793a4 > > --David This sed command is nice, but nothing to be recommended for our users. Driver buiding is for sure the more ra

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread David Grayson
On Wed, May 17, 2017 at 4:10 AM, Kai Tietz wrote: > The best solution would be something like to include > driverspecs.h in specstring.h only, if user intends to use ddk. Is that how the real DDK works? When you don't have the DDK installed, you can still include specstrings.h but it somehow doe

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread David Grayson
Here's the sed command again, without bad line wrapping: https://gist.github.com/DavidEGrayson/ee9796a900eedda3d6b7c8f2324793a4 --David On Wed, May 17, 2017 at 7:08 AM, David Grayson wrote: > A GCC maintainer has spoken up and said they will accept a patch to > rename __in and __out to other th

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread David Grayson
A GCC maintainer has spoken up and said they will accept a patch to rename __in and __out to other things: https://gcc.gnu.org/ml/gcc-help/2017-05/msg00152.html As soon as I have a bit of free time, I will submit such a patch to them, though LH_Mouse might beat me to it. So in the long term, we

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread Mateusz
W dniu 2017-05-17 o 13:10, Kai Tietz pisze: > Hello, > > I dislike such a change. As if somebody wants to driverspec.h, op > will need these symbols defined. Otherwise build will badly fail. > So this brings us back to the reasoning of this ... adding to > specstrings.h the include of driverspec

Re: [Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread Kai Tietz
Hello, I dislike such a change. As if somebody wants to driverspec.h, op will need these symbols defined. Otherwise build will badly fail. So this brings us back to the reasoning of this ... adding to specstrings.h the include of driverspecs.h. IMHO this shouldn't be done always. The best solu

[Mingw-w64-public] [PATCH] comment out '__in' and '__out' from driverspecs.h for compatibility with libstdc++

2017-05-17 Thread Mateusz
We really should do something with '__in' and '__out' from driverspecs.h. Please review. mingw-w64-headers/include/driverspecs.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mingw-w64-headers/include/driverspecs.h b/mingw-w64-headers/include/driverspecs.h index 2f