On 2017/5/3 12:46, David Grayson wrote:
> I won't be offended if you revert it.
I reverted it and added a line of comment explaining what had happened.
> I'm not sure what your shell commands do, but as long as there is one GUID
> defined in one header file, and the selectany attribute is not used
I won't be offended if you revert it.
I'm not sure what your shell commands do, but as long as there is one GUID
defined in one header file, and the selectany attribute is not used
properly, you can get multiple definition errors, because that header file
could be used in multiple translation unit
On 2017/5/3 9:33, Liu Hao wrote:
> Kai, should we revert it? We have to deal with the multiple definition
> error thereafter.
>
A number of UUIDs/GUIDs are suffering from such multiple definitions,
which can be discovered using the following commands:
```bash
grep -EhrI '^DEFINE_(GUID|OLEGUID)' |
On 2017/5/3 6:23, Mateusz wrote:
> W dniu 2017-05-02 o 13:08, Liu Hao pisze:
>> On 2017/5/2 18:38, Kai Tietz wrote:
>>> I think, it is worth a try. In general it looks sensible.
>> As you wish.
>
> For GCC 7.1 and 6.3 the patch is OK.
>
> For GCC 5.4 is not -- error compiling ffmpeg:
> CC lib
W dniu 2017-05-02 o 13:08, Liu Hao pisze:
> On 2017/5/2 18:38, Kai Tietz wrote:
>> I think, it is worth a try. In general it looks sensible.
> As you wish.
For GCC 7.1 and 6.3 the patch is OK.
For GCC 5.4 is not -- error compiling ffmpeg:
CC libavdevice/dshow.o
In file included from
f:\msy
On 2017/5/2 18:38, Kai Tietz wrote:
> I think, it is worth a try. In general it looks sensible.
As you wish.
--
Best regards,
LH_Mouse
--
Check out the vibrant tech community on one of the world's most
engaging tech si
I think, it is worth a try. In general it looks sensible.
Kai
2017-05-02 11:56 GMT+02:00 Liu Hao :
> Kai, did you mean this patch was ok for master?
>
> --
> Best regards,
> LH_Mouse
>
>
> --
> Check out the vibrant tech
Kai, did you mean this patch was ok for master?
--
Best regards,
LH_Mouse
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
__
Ok, thanks for trying to get the reasoning, why we didn't marked it as
selectany. So I think it is time to add this selectany to our master,
and see if we get really any issues reported for it.
The only scenario I am concerned about is user-defined, library
defined. As prototypes are changing, an
