On 2017/4/5 21:51, Mateusz Mikuła wrote:
> Conversion from const pointer to normal pointer is definitely unsafe but
> that's probably what GCC just did.
> I'm unsure what you mean by "union-cast" but you can commit your fix.
Take a look at the prototype of the `strchr` function in the C standard
l
> Hmm, using here "wchar_t *" as cast looks wrong. Actually we should
> use anyway PUWSTR_C instead.
I noticed it a bit too late and sent another patch casting to PUWSTR_C.
> Nevertheless we can have here a const/none-const conversion (means
> const specifiers for C-runtime function isn't regarded
Hmm, using here "wchar_t *" as cast looks wrong. Actually we should
use anyway PUWSTR_C instead.
Nevertheless we can have here a const/none-const conversion (means
const specifiers for C-runtime function isn't regarded right?). I
would suggest to introduce a union-cast instead to avoid further
wa
On second though casting to "PUWSTR_C" which is could be more appealing.
Attaching improved patch.
-- Original Message --
Subject: Re: [Mingw-w64-public] [PATCH] stralign: cast ua_wcschr and
ua_wcsrchr returns to wchar_t *
Date: Wed, 5 Apr 2017 15:06:41 +0200
To: Mingw-w64-public
From
Hmm, somehow Sourcefore has lost track on this thread (you can see
patch on the mailing list website).
This time sending it as both attachment and text.
From f3febf9542a6664eedc384b0d2bf63411477e141 Mon Sep 17 00:00:00 2001
From: Mateusz Mikula
Date: Mon, 3 Apr 2017 13:36:36 +0200
Subject: [PAT
Hello Mateusz,
could you please re-attach, or simply inline patch to this mail?
Thanks in advance,
Kai
2017-04-05 14:08 GMT+02:00 Mateusz Mikuła :
> Ping, looks like it slipped unnoticed.
>
>
>
>
> -- Original Message --
> Subject: [PATCH] stralign: cast ua_wcschr and ua_wcsrchr returns
Ping, looks like it slipped unnoticed.
-- Original Message --
Subject: [PATCH] stralign: cast ua_wcschr and ua_wcsrchr returns to
wchar_t *
Date: Mon, 3 Apr 2017 14:01:00 +0200
To: Mingw-w64-public
From: Mateusz Mikuła
>
> I made another attempt to build libc++ with mingw-w64 and stumb
On 04/05/2017 04:37 AM, Liu Hao wrote:
> On 2017/4/5 3:59, Tamir Duberstein wrote:
>> Jacek, it doesn't look like this was pushed, or at least I don't see
>> the change in https://sourceforge.net/p/mingw-w64/mingw-w64/ci/v5.x/tree/.
>> Could you verify?
> It seems Jon didn't push that branch.
>
J
