Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

2017-04-02 Thread David Grayson
Oops, I did a bad job of testing LH_Mouse's patch because I was trying to judge whether a broken build of a program got worse. It turns out his patch made the build worse, causing undefined reference errors for functions like StringCbLengthA that get defined in strsafe.h when compiled as a part of

Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

2017-04-02 Thread David Grayson
I just tested LH_Mouse's patch and it seems to work fine, so I am OK with using it instead of mine. However, that patch seems like it could be wrong too, since when strsafe.h is used to compile the library, all the library functions will have __inline in their declarations even though we are compi

Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

2017-04-02 Thread Liu Hao
On 2017/4/3 0:54, David Grayson wrote: On April 2, 2017 2:55:35 AM GMT+02:00, David Grayson < davidegray...@gmail.com> wrote: In MSYS2 and in my own compilation of a mingw-w64 GCC 6.3.0 toolchain, strsafe.h was producing tons of warnings when included because it was declaring its functions as in

Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

2017-04-02 Thread David Grayson
OK, I'm disappointed in gmail then. Here is a version with a .txt extension so it should have the right MIME type and get through. --David On Sun, Apr 2, 2017 at 1:00 AM, Mateusza Mikuła wrote: > Looks like patch couldn't make it through. > > On April 2, 2017 2:55:35 AM GMT+02:00, David Grayso

Re: [Mingw-w64-public] [PATCH] strsafe.h: Change __inline to __CRT_INLINE

2017-04-02 Thread Mateusza Mikuła
Looks like patch couldn't make it through. On April 2, 2017 2:55:35 AM GMT+02:00, David Grayson wrote: >In MSYS2 and in my own compilation of a mingw-w64 GCC 6.3.0 toolchain, >strsafe.h was producing tons of warnings when included because it was >declaring its functions as inline but then not de