Re: [Mingw-w64-public] [PATCH v3] Make isatty Cygwin-compatible

2016-11-13 Thread Mihail Konev
On Sun, Nov 13, 2016 at 09:44:49PM +0100, Corinna Vinschen wrote: > On Nov 14 00:31, Mihail Konev wrote: > > I'm opposed to checking the pipes for *-msys-* additionally to > *-cygwin-* for no good reason. You're adding just another test to the > checking code and potentially introduce hard to tra

Re: [Mingw-w64-public] [PATCH v3] Make isatty Cygwin-compatible

2016-11-13 Thread Corinna Vinschen
On Nov 14 00:31, Mihail Konev wrote: > +/* Cygwin-compatible isatty. > + * > + * Cygwin pty is a specially-named named pipe. > + * Fetch absolute device namespace path to fd (if any), > + * and check it for the following pattern: > + * > + * > \Device\NamedPipe\(cygwin|msys)-[a-fA-F0-9]{16}-pty[

[Mingw-w64-public] [PATCH v3] Make isatty Cygwin-compatible

2016-11-13 Thread Mihail Konev
Before, isatty() was an alias for WinAPI _isatty(). This resulted in wrong result for mintty. Implement a pipe name check in a static isatty(). This makes io.h include NT and Windows APIs. The change isn't strictly standard, as it adds 'static' to the isatty() signature. Signed-off-by: Mihail Ko

Re: [Mingw-w64-public] [PATCH] Make isatty Cygwin-compatible

2016-11-13 Thread Adrien Nader
Hi, Below I'm only looking at the code by itself, not at the overall approach. On Sun, Nov 13, 2016, Mihail Konev wrote: > + pNtQueryObject = (proc_NtQueryObject*) > GetProcAddress(GetModuleHandle("ntdll.dll"), "NtQueryObject"); > + if (!pNtQueryObject) > +goto no_tty; Curly braces preven

[Mingw-w64-public] [PATCH v2] Make isatty Cygwin-compatible

2016-11-13 Thread Mihail Konev
Before, isatty() was an alias for WinAPI _isatty(). This resulted in wrong result for mintty. Implement a pipe name check in a static isatty(). This makes io.h include NT and Windows APIs. The change isn't strictly standard, as it adds 'static' to the isatty() signature. Signed-off-by: Mihail Ko

[Mingw-w64-public] [PATCH] Make isatty Cygwin-compatible

2016-11-13 Thread Mihail Konev
Before, isatty() was an alias for WinAPI _isatty(). This resulted in wrong result for mintty. Implement a pipe name check in a static isatty(). This makes io.h include wchar.h, errno.h, io.h, winternl.h, and windows.h. Signed-off-by: Mihail Konev Moved-from: https://github.com/Alexpux/mingw-w64/

Re: [Mingw-w64-public] [PATCH v5] Add include/iscygtty.c

2016-11-13 Thread Corinna Vinschen
On Nov 13 11:01, Corinna Vinschen wrote: > On Nov 12 23:10, Ray Donnelly wrote: > > MSYS2 is a software distribution with both (extremely) Cygwin-like and also > > native Windows software, all (usually) launched from mintty. > > MSYS2 is a slightly tweaked Cygwin DLL in the first place. > > There

Re: [Mingw-w64-public] [PATCH v5] Add include/iscygtty.c

2016-11-13 Thread Corinna Vinschen
On Nov 12 23:10, Ray Donnelly wrote: > MSYS2 is a software distribution with both (extremely) Cygwin-like and also > native Windows software, all (usually) launched from mintty. MSYS2 is a slightly tweaked Cygwin DLL in the first place. There are applications linked against it, thus using the POS

Re: [Mingw-w64-public] [PATH] math.h: The type of C99 INFINITY and NAN shall be float.

2016-11-13 Thread Nakai Yuta
hmm, it seems that sf doesnt't accept it. 差出人: David Grayson 送信日時: 2016年11月13日 08:30 宛先: mingw-w64-public@lists.sourceforge.net 件名: Re: [Mingw-w64-public] [PATH] math.h: The type of C99 INFINITY and NAN shall be float. Patch is not attached. --David

Re: [Mingw-w64-public] [PATH] math.h: The type of C99 INFINITY and NAN shall be float.

2016-11-13 Thread David Grayson
Patch is not attached. --David On Sat, Nov 12, 2016 at 7:33 PM, Nakai Yuta wrote: > C99 defines INFINITY and NAN macros as float. > patch is attached. > > > > -- > Developer Access Program for Intel Xeon Phi Processors