My next patch is very small, but it affects a bunch of code. Ponder it
a bit before approving. The goal is to fix all the warnings like this:
warning: '_unlock_file' redeclared without dllimport attribute:
previous dllimport ignored [-Wattributes]
This occurs because our headers use:
_C
Most people could probably check this patch in "as obvious." But I
don't really speak script, so someone better check.
BTW, don't bother trying to build --enable-warnings=4 (or higher). Even
with this patch, it's not going to build (not even close).
dw
diff --git a/mingw-w64-crt/configure b
It's late, so just 3 quick new ones tonight:
Ok, kai signed off on these too.
So, next are the IDL files. I (mistakenly) tried to regenerate my
changes by just running widl against the appropriate idl file.
Apparently the correct way is to use --with-widl on the configure line.
So I did th
---
Updated to check with fegetround to see which rounding mode to use,
fixed the way the mode is checked (by using == instead of &).
---
mingw-w64-crt/math/llrint.c | 11 ++-
mingw-w64-crt/math/llrintf.c | 11 ++-
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/mi
On 8/18/2016 4:23 AM, Martell Malone wrote:
> I would also like to point you to my selectany patch.
> You asked why that wasn't supported on clang on irc.
> https://github.com/martell/mingw-w64-clang/blob/master/patches/clang/0003-mingw-w64-enable-support-for-__declspec-selectany.patch
> This shoul
On Thu, 18 Aug 2016, Martin Storsjö wrote:
---
Updated to check with fegetround to see which rounding mode to use.
---
mingw-w64-crt/math/llrint.c | 11 ++-
mingw-w64-crt/math/llrintf.c | 11 ++-
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/mingw-w64-crt/math/ll
---
Updated to check with fegetround to see which rounding mode to use.
---
mingw-w64-crt/math/llrint.c | 11 ++-
mingw-w64-crt/math/llrintf.c | 11 ++-
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/mingw-w64-crt/math/llrint.c b/mingw-w64-crt/math/llrint.c
index
On Thu, 18 Aug 2016, Martin Storsjö wrote:
On Thu, 18 Aug 2016, Kai Tietz wrote:
Hello Martin,
2016-08-18 15:31 GMT+02:00 Martin Storsjö :
---
The (l)rint(f) functions call an inline assembly snippet to
do the rounding - that does seem to round in the right way, but I'm
not sure if that reli
On Thu, 18 Aug 2016, Kai Tietz wrote:
Hello Martin,
2016-08-18 15:31 GMT+02:00 Martin Storsjö :
---
The (l)rint(f) functions call an inline assembly snippet to
do the rounding - that does seem to round in the right way, but I'm
not sure if that relies on the fpscr being set in the right mode?
Hello Martin,
2016-08-18 15:31 GMT+02:00 Martin Storsjö :
> ---
> The (l)rint(f) functions call an inline assembly snippet to
> do the rounding - that does seem to round in the right way, but I'm
> not sure if that relies on the fpscr being set in the right mode?
> ---
> mingw-w64-crt/math/llrint
---
The (l)rint(f) functions call an inline assembly snippet to
do the rounding - that does seem to round in the right way, but I'm
not sure if that relies on the fpscr being set in the right mode?
---
mingw-w64-crt/math/llrint.c | 2 +-
mingw-w64-crt/math/llrintf.c | 2 +-
2 files changed, 2 ins
---
The indentation probably looks wonky in ths patch, but I'm trying
to match the style of the rest of the arm assembly below, which
uses tabs, equal to 4 spaces.
This probably also should be done to a lot of other math functions,
but I only ran into this as an issue with floor, in the libav test
On Thu, 18 Aug 2016, David Wohlferd wrote:
>
>> I assume I still need to wait for someone else to approve this before I
>> push?
>
> Kai signed off on these via IRC.
>
> It's late, so just 3 quick new ones tonight:
>
> e_pow.patch - Signed/unsigned compare
>
> mingw_pformat.patch - Don't use fea
I would also like to point you to my selectany patch.
You asked why that wasn't supported on clang on irc.
https://github.com/martell/mingw-w64-clang/blob/master/patches/clang/0003-mingw-w64-enable-support-for-__declspec-selectany.patch
This should be better then using -fms-{extensions,compat}
On
>
> mingw_pformat.patch - Don't use feature (__attribute__((gcc_struct))) that
> isn't supported on clang when compiling on clang.
I have the very same patch applied locally, can confirm this is a good
change.
The typo was a good catch.
On Thu, Aug 18, 2016 at 3:33 AM, David Wohlferd
wrote:
>
>
I assume I still need to wait for someone else to approve this before
I push?
Kai signed off on these via IRC.
It's late, so just 3 quick new ones tonight:
e_pow.patch - Signed/unsigned compare
mingw_pformat.patch - Don't use feature (__attribute__((gcc_struct)))
that isn't supported on c
16 matches
Mail list logo
