Could anyone please apply this ?
差出人: JonY
送信日時: 2015年10月30日 20:55
宛先: mingw-w64-public@lists.sourceforge.net
件名: Re: [Mingw-w64-public] [PATCH] sal.h: Fix redefinition of _Field_range_.
On 10/30/2015 07:15, David Grayson wrote:
> Yep, that looks like a
As of a few days ago, clang supports the builtins we use in intsafe.h.
However, clang still defines __GNUC__ as 4 and I don't know how long it's going
to be like that. So this patch adds special code to detect clang and detect if
clang supports the builtins we need, allowing the inline functio
'const PTIMEVAL timeout' is 'struct timeval *const timeout', whose `const` is
meaningless except in its definition (which is not seen here).
(Also be noted that Linux version of select() modifies the 'timeout' structure
so a `const` MUST NOT be placed there.)
And here is the 'timeval' structure
My first thought is that probably isn't serious enough to warrant a change. I
was porting libncftp to the latest TDM-GCC environment, as we plan to upgrade
from MinGW32. I spent enough time on it that I thought I'd note it on the
mailing list. Thank you for your interest.
I see this code in
If you want to get mingw-w64 fixed, I suggest posting a patch file to
this list so the developers can see what change you would want to make
and easily apply it. In case it helps, I usually clone the git
repository and prepare patches using "git diff", and you can look at
the archives of this list
> The types "const struct timeval *" and "struct timeval * const" are not the
> same.
Right, of course. But there seems to be a fundamental limitation in gcc when
it comes to recognizing that two types are "equal". It appears that it
doesn't make that check.
Consider this code, which avoids
On 10/30/2015 07:15, David Grayson wrote:
> Yep, that looks like a good change to me. Sorry for not catching that
> earlier.
>
> --David
Looks good to me too, please commit.
0xD4EBC740.asc
Description: application/pgp-keys
signature.asc
Description: OpenPGP digital signature
-
