[Mingw-w64-public] [PATCH] New Discovery Keys file

Please Review :) 0001-added-new-file-functiondiscoverykeys_devpkey.h-and-k.patch Description: Binary data -- Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partne

Re: [Mingw-w64-public] [PATCH] memory.h: Merged memory_s.h into memory.h.

Patch is ok. Thanks, Kai 2015-02-04 17:19 GMT+01:00 Jacek Caban : > --- > mingw-w64-headers/crt/memory.h | 1 + > mingw-w64-headers/crt/sec_api/memory_s.h | 26 -- > mingw-w64-headers/crt/sec_api/string_s.h | 5 - > mingw-w64-headers/crt/string.h

[Mingw-w64-public] [PATCH] memory.h: Merged memory_s.h into memory.h.

--- mingw-w64-headers/crt/memory.h | 1 + mingw-w64-headers/crt/sec_api/memory_s.h | 26 -- mingw-w64-headers/crt/sec_api/string_s.h | 5 - mingw-w64-headers/crt/string.h | 1 + 4 files changed, 2 insertions(+), 31 deletions(-) delete mode 100644

Re: [Mingw-w64-public] Small Header additions

Yes. I don't think it's a problem that one GUID would be different, it would be just a good example for future improvements, but your patch is fine as well. On 02/04/15 17:13, Martell Malone wrote: > Will I consider this reviewed? > Just need the go ahead > > On Wed, Feb 4, 2015 at 3:23 PM, Martel

Re: [Mingw-w64-public] Small Header additions

Will I consider this reviewed? Just need the go ahead On Wed, Feb 4, 2015 at 3:23 PM, Martell Malone wrote: > I know that it's not what we do in other cases, but something like that >> would avoid hardcoding this uuid in two places: >> >> DEFINE_GUID(KSCATEGORY_ >> ENCODER, STATIC_KSCATEGORY_ENC

Re: [Mingw-w64-public] Small Header additions

> > I know that it's not what we do in other cases, but something like that > would avoid hardcoding this uuid in two places: > > DEFINE_GUID(KSCATEGORY_ > ENCODER, STATIC_KSCATEGORY_ENCODER); > Yes I was going todo it that way but I saw that many of the others from that header were defined alread

Re: [Mingw-w64-public] Small Header additions

Hi Martell, Those patches look good to me now. I just have one suggestion. On 02/04/15 16:14, Martell Malone wrote: > > DEFINE_GUID(KSCATEGORY_DATADECOMPRESSOR,0x2721ae20,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0); > > DEFINE_GUID(KSCATEGORY_DATATRANSFORM,0x2eb07ea0,0x7e70,0x11d0,0xa5,0x

Re: [Mingw-w64-public] Small Header additions

> > The interface seems correct, why do you add this warning? Same for > IMPEG2PIDMap All the other interfaces in the file also have this warning so I didn't want to remove it. Attached updated patch :) Those two should be in wmcodecdsp.idl AFAICS. > Yes as discussed on IRC there are a few uuid'

Re: [Mingw-w64-public] [Patch] - Hardening libssp against malicious local processes

Hi Georg, On 02/03/15 11:53, Georg Koppen wrote: > Hi, > > I am putting a patch inline (not sure if attachments are allowed on this > mailing list) that does not make it possible for a local process anymore > to replace canaries which in turn might disable SSP. Comments and/or > review are much ap

Re: [Mingw-w64-public] Small Header additions

Hi Martell, On 02/04/15 12:10, Martell Malone wrote: > +#warning COM interfaces layout in this header has not been verified. > +#warning COM interfaces with incorrect layout may not work at all. > +__MINGW_BROKEN_INTERFACE(INTERFACE) The interface seems correct, why do you add this warning? Same

[Mingw-w64-public] Small Header additions

Small header changes for various missing uuid's and 2 classes Please Review 0001-Added-IEnumPIDMap-and-IMPEG2PIDMap-to-bdaiface.h.patch Description: Binary data 0001-Add-some-missing-uuid-s.patch Description: Binary data 0001-include-ksmedia-uuids-in-libuuid.patch Description: Binary data --