Re: [Mingw-w64-public] Failure to compile mingw-w64-crt/libsrc/uuid.c

2014-09-03 Thread Rainer Emrich
Am 03.09.2014 17:29, schrieb Kai Tietz: > Issue should be fixed now. Confirmed, checked a few minutes ago. Thank's! -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _

Re: [Mingw-w64-public] Failure to compile mingw-w64-crt/libsrc/uuid.c

2014-09-03 Thread Kai Tietz
Issue should be fixed now. Kai -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourcefor

Re: [Mingw-w64-public] Fix compile error in commctrl.h

2014-09-03 Thread Dongsheng Song
Thanks, pushed without _WIN32 guard. On Wed, Sep 3, 2014 at 6:18 PM, Kai Tietz wrote: > Sure, it has to. > > Kai > > 2014-09-03 12:06 GMT+02:00 Dongsheng Song : >> Did ARM target support these features or defined _WIN32 ? >> >> On Wed, Sep 3, 2014 at 3:27 PM, Kai Tietz wrote: >>> Hi, >>> >>> To

Re: [Mingw-w64-public] Failure to compile mingw-w64-crt/libsrc/uuid.c

2014-09-03 Thread Kai Tietz
Hi, thanks for reporting. First part of reported double-definition failures is fixed. The issue reported about LITEM and in commctrl.h header is already in progress. Dongsheng posted a patch for it. There is just one nit about it. It will be soon committed. Thanks, Kai --

[Mingw-w64-public] Failure to compile mingw-w64-crt/libsrc/uuid.c

2014-09-03 Thread Rainer Emrich
master of today gives: gcc -DHAVE_CONFIG_H -I. -I/opt/devel/gnu/src/gcc-mingw-w64/mingw-w64-runtime.git/mingw-w64-crt -m64 -I/home/rainer/software/install/x86_64-w64-mingw32/mingw-w64/trunk/include -pipe -std=gnu99 -D_WIN32_WINNT=0x0f00 -Wall -Wextra -Wformat -Wstrict-aliasing -Wshadow -Wpac

Re: [Mingw-w64-public] Fix compile error in commctrl.h

2014-09-03 Thread Kai Tietz
Sure, it has to. Kai 2014-09-03 12:06 GMT+02:00 Dongsheng Song : > Did ARM target support these features or defined _WIN32 ? > > On Wed, Sep 3, 2014 at 3:27 PM, Kai Tietz wrote: >> Hi, >> >> To move code up is ok. Patch is ok, but one nit. Why do you check >> here _WIN32 as guard. Do we have

Re: [Mingw-w64-public] Fix compile error in commctrl.h

2014-09-03 Thread Dongsheng Song
Did ARM target support these features or defined _WIN32 ? On Wed, Sep 3, 2014 at 3:27 PM, Kai Tietz wrote: > Hi, > > To move code up is ok. Patch is ok, but one nit. Why do you check > here _WIN32 as guard. Do we have targets where _WIN32 isn't defined? > > Cheers, > Kai > > 2014-09-03 5:33 GM

Re: [Mingw-w64-public] Fix compile error in commctrl.h

2014-09-03 Thread Kai Tietz
Hi, To move code up is ok. Patch is ok, but one nit. Why do you check here _WIN32 as guard. Do we have targets where _WIN32 isn't defined? Cheers, Kai 2014-09-03 5:33 GMT+02:00 Dongsheng Song : > Hi, > > This patch fix compile error in commctrl.h > > Ok for apply? > > Regards, > Dongsheng > >