Re: [Mingw-w64-public] Interlocked* patches follow-up

2013-07-16 Thread dw
Please review the new patch Well, we got your good news and your bad news. On the plus side, this patch fixes the problem I was seeing with -Os. On the downside, my "release" build script also uses -fwhole-program. This is giving me a link error: /undefined reference to `_imp__Interlock

Re: [Mingw-w64-public] Interlocked* patches follow-up

2013-07-16 Thread Jacek Caban
That indeed helps, thanks! Please review the new patch: http://repo.or.cz/w/mingw-w64/jacek.git/commitdiff/f7429586bb3289d54e4654f08849161e38ce67a8 Tested on GCC 4.8.1 and trunk. Jacek On 07/16/13 15:25, Kai Tietz wrote: > > The limitation is fixed for trunk, and gcc 4.8.x > I committed there a

Re: [Mingw-w64-public] Interlocked* patches follow-up

2013-07-16 Thread Kai Tietz
The limitation is fixed for trunk, and gcc 4.8.x I committed there a fix for that. It might be interesting if rgat change relaxes the other inline-issue too. Kai Am 16.07.2013 04:31 schrieb "Jacek Caban" : > This seems to be GCC limitation. I experimented a bit and it can't > inline function if

Re: [Mingw-w64-public] Interlocked* patches follow-up

2013-07-16 Thread Jacek Caban
This seems to be GCC limitation. I experimented a bit and it can't inline function if it's also declared as dllimport. That fact, in combination with always_inline, causes an error. We may work around that by not using always_inlines for those functions and being careful to not use dllimport in our

Re: [Mingw-w64-public] Interlocked* patches follow-up

2013-07-16 Thread Jacek Caban
On 07/15/13 22:34, dw wrote: >> Let's get rid of empty files. > Ok by me. > > Since my automake isn't up to creating .in files, I was going to wait > until I was sure I wasn't going to have any more before asking someone > to help. I'm aware of at least one more file that needs to have this > d