Re: [Mingw-w64-public] endpointvolume.h and KS* structures inconsistencies

2013-06-13 Thread JonY
On 6/13/2013 21:48, Jacek Caban wrote: > On 06/13/13 00:11, JonY wrote: >> I discovered it was including devicetopology.h and then including ks.h >> and ksmedia.h. These declarations are already in devicetopology.h but >> dummied out because it was checking for _KS_ #define before declaring >> thes

Re: [Mingw-w64-public] endpointvolume.h and KS* structures inconsistencies

2013-06-13 Thread Jacek Caban
On 06/13/13 00:11, JonY wrote: > I discovered it was including devicetopology.h and then including ks.h > and ksmedia.h. These declarations are already in devicetopology.h but > dummied out because it was checking for _KS_ #define before declaring > these. ks.h defines it and blocks the declaration

Re: [Mingw-w64-public] [Patch] __faststorefence, _ReadWriteBarrier et al

2013-06-13 Thread dw
I am concerned about making out of function-prototypes instead macros. A reasonable concern. I have struggled with this on occasion. It's certainly worth a second look (below). I admit that in most cases that won't cause any troubles, but by macros we pessimize some potential user-code ove

Re: [Mingw-w64-public] [Patch] __faststorefence, _ReadWriteBarrier et al

2013-06-13 Thread Kai Tietz
Hi, I am concerned about making out of function-prototypes instead macros. I admit that in most cases that won't cause any troubles, but by macros we pessimize some potential user-code overrides. Additional a macro has no implementation-address. So there are no pointer-references possible (well

[Mingw-w64-public] [Patch] __faststorefence, _ReadWriteBarrier et al

2013-06-13 Thread dw
This patch addresses the following issues: 1) The existing code for __faststorefence doesn't actually generate a fence. It just generates a barrier. This patch maps __faststorefence to _mm_sfence (instead of doing MS's trick with "lock or"). sfence appears to be faster than MS's "fast" appr

Re: [Mingw-w64-public] __faststorefence and mingw-w64 philosophy

2013-06-13 Thread dw
> I think we should ignore that somebody uses -mno-sse for x64. First > this would be clearly an ABI-breakage, due SSE is mandatory in > calling-convention. Agreed. TIL: x64 uses SSE features for passing parameters (for example using XMM0 for floating point). > >> There is a similar question fo