Re: [Mingw-w64-public] [PATCH] wassert replacement without forbidden MessageBoxW

2013-05-21 Thread Kai Tietz
2013/5/21 Rafaël Carré : > Le 21/05/2013 15:43, Kai Tietz a écrit : >> 2013/5/21 Rafaël Carré : >>> --- >>> mingw-w64-libraries/winstorecompat/Makefile.am| 1 + >>> mingw-w64-libraries/winstorecompat/Makefile.in| 10 - >>> mingw-w64-libraries/winstorecompat/src/_wassert.c | 50 >>> ++

Re: [Mingw-w64-public] [PATCH] wassert replacement without forbidden MessageBoxW

2013-05-21 Thread Rafaël Carré
Le 21/05/2013 15:43, Kai Tietz a écrit : > 2013/5/21 Rafaël Carré : >> --- >> mingw-w64-libraries/winstorecompat/Makefile.am| 1 + >> mingw-w64-libraries/winstorecompat/Makefile.in| 10 - >> mingw-w64-libraries/winstorecompat/src/_wassert.c | 50 >> +++ >> 3 files

Re: [Mingw-w64-public] [PATCH] wassert replacement without forbidden MessageBoxW

2013-05-21 Thread Kai Tietz
2013/5/21 Rafaël Carré : > --- > mingw-w64-libraries/winstorecompat/Makefile.am| 1 + > mingw-w64-libraries/winstorecompat/Makefile.in| 10 - > mingw-w64-libraries/winstorecompat/src/_wassert.c | 50 > +++ > 3 files changed, 59 insertions(+), 2 deletions(-) > cre

Re: [Mingw-w64-public] [PATCH] Clean up _assert / _wassert

2013-05-21 Thread Kai Tietz
For the records, patch revised on irc. New patch will be sent. Kai -- Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful

[Mingw-w64-public] [PATCH] wassert replacement without forbidden MessageBoxW

2013-05-21 Thread Rafaël Carré
--- mingw-w64-libraries/winstorecompat/Makefile.am| 1 + mingw-w64-libraries/winstorecompat/Makefile.in| 10 - mingw-w64-libraries/winstorecompat/src/_wassert.c | 50 +++ 3 files changed, 59 insertions(+), 2 deletions(-) create mode 100644 mingw-w64-libraries/wins

[Mingw-w64-public] [PATCH] Clean up _assert / _wassert

2013-05-21 Thread Rafaël Carré
Always import _assert from msvcrt Only use _wassert replacement for msvcrt.dll --- mingw-w64-crt/def-include/msvcrt-common.def.in | 2 ++ mingw-w64-crt/lib32/msvcr100.def.in| 3 +-- mingw-w64-crt/lib32/msvcr110.def.in| 1 - mingw-w64-crt/lib32/msvcr80.def.in

Re: [Mingw-w64-public] [PATCH] Fix bug in InterlockedOr

2013-05-21 Thread Kai Tietz
2013/5/21 dw : > >> the idea to put all intrinsics within one new header, I don't like >> either. > Sorry, my fault. I wasn't clear. This isn't what I was proposing. > > I'm suggesting intrnmac.h only contains the macro definitions. So we > would move this code from winnt.h (which is where it is

Re: [Mingw-w64-public] [PATCH] Fix bug in InterlockedOr

2013-05-21 Thread dw
> the idea to put all intrinsics within one new header, I don't like > either. Sorry, my fault. I wasn't clear. This isn't what I was proposing. I'm suggesting intrnmac.h only contains the macro definitions. So we would move this code from winnt.h (which is where it is now) to intrnmac.h:

Re: [Mingw-w64-public] [PATCH] Fix bug in InterlockedOr

2013-05-21 Thread Kai Tietz
2013/5/21 dw : > >> Could you please also prepare patch for crt's intrinsic-implementation >> files? > I've been pondering how to do this, both for the InterlockedOr functions > and the __stos* functions. Duplicating the same code in two places goes > against my nature. I figure the best answer w