Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread G M
Hi Ruben Thanks for that. I've posted a patch to Howard with a fix as you have suggested now, because the warnings fill my screen up and I am building often and in light of the other opinions it might be the only fix on offer for now. I think Howard is planning to commit it tomorrow his time. I'v

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread Ruben Van Boxem
2013/4/11 Corinna Vinschen > On Apr 11 15:46, Ruben Van Boxem wrote: > > 2013/4/11 Earnie Boyd > > > On Thu, Apr 11, 2013 at 6:08 AM, Corinna Vinschen wrote: > > > > That means, if you give a char to this function, on machines on which > > > > char is a *signed* type, you make a mistake. All ch

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread Corinna Vinschen
On Apr 11 15:46, Ruben Van Boxem wrote: > 2013/4/11 Earnie Boyd > > On Thu, Apr 11, 2013 at 6:08 AM, Corinna Vinschen wrote: > > > That means, if you give a char to this function, on machines on which > > > char is a *signed* type, you make a mistake. All char values > 127 > > > are negative int

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread Ruben Van Boxem
2013/4/11 Earnie Boyd > On Thu, Apr 11, 2013 at 6:08 AM, Corinna Vinschen wrote: > > On Apr 11 09:38, Ruben Van Boxem wrote: > >> 2013/4/11 G M > >> > >> > Hi Ruben > >> > > >> > Thanks for replying. :) > >> > > >> > That's because from the pasted code shows the file and the line and an > >> > ar

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread Earnie Boyd
On Thu, Apr 11, 2013 at 6:08 AM, Corinna Vinschen wrote: > On Apr 11 09:38, Ruben Van Boxem wrote: >> 2013/4/11 G M >> >> > Hi Ruben >> > >> > Thanks for replying. :) >> > >> > That's because from the pasted code shows the file and the line and an >> > array access: >> > >> > >> > c:/mingw/bin/../l

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread G M
Well it'd be great if that could happen and be compatible across g++/cl/clang++ libc++/libcxx/vc. If there's something to suggest to Howard here to make that happen for cctype or whatever for libcxx, let me know what that is. Otherwise it seems like several casts will be needed in locale.cpp regard

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread Ruben Van Boxem
2013/4/11 G M > I agree with both Ruben and Corrina. > > I can see libcxx is wrong because it's passing a char. I'll fix that and > submit a patch. > > But it would be better if libcxx had a better warning than warning about > indexing with a char, it's really about a type mismatch > But a wrong

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread G M
I agree with both Ruben and Corrina. I can see libcxx is wrong because it's passing a char. I'll fix that and submit a patch. But it would be better if libcxx had a better warning than warning about indexing with a char, it's really about a type mismatch But a wrong warning is better than no warn

Re: [Mingw-w64-public] Typos in d3dcompiler.h

2013-04-11 Thread Jacek Caban
Hi Jonathan, On 04/11/13 12:57, Jonathan Liu wrote: > Hi, > > I noticed some typos in d3dcompiler.h and corrected them. See attached > patch. This header is imported from Wine and patches should go upstream. Please send the patch to wine-patc...@winehq.org. Thanks, Jacek ---

[Mingw-w64-public] [patch] d3dcompiler.h missing typedefs

2013-04-11 Thread Jonathan Liu
Hi, Attached is a patch to add missing typedefs to d3dcompiler.h. Regards, Jonathan Index: mingw-w64-headers/direct-x/include/d3dcompiler.h === --- mingw-w64-headers/direct-x/include/d3dcompiler.h(revision 5769) +++ mingw-w64-he

[Mingw-w64-public] Typos in d3dcompiler.h

2013-04-11 Thread Jonathan Liu
Hi, I noticed some typos in d3dcompiler.h and corrected them. See attached patch. Regards, Jonathan Index: mingw-w64-headers/direct-x/include/d3dcompiler.h === --- mingw-w64-headers/direct-x/include/d3dcompiler.h(revision 5769

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread Corinna Vinschen
On Apr 11 09:38, Ruben Van Boxem wrote: > 2013/4/11 G M > > > Hi Ruben > > > > Thanks for replying. :) > > > > That's because from the pasted code shows the file and the line and an > > array access: > > > > > > c:/mingw/bin/../lib/clang/3.3/../../../x86_64-w64-mingw32/include\ctype.h:201:41: > >

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread Ruben Van Boxem
2013/4/11 G M > Hi Ruben > > Thanks for replying. :) > > That's because from the pasted code shows the file and the line and an > array access: > > > c:/mingw/bin/../lib/clang/3.3/../../../x86_64-w64-mingw32/include\ctype.h:201:41: > note: expanded from macro '__chvalidchk' > > #define __chvalidc

Re: [Mingw-w64-public] ctype warnings

2013-04-11 Thread G M
Hi Ruben Thanks for replying. :) That's because from the pasted code shows the file and the line and an array access: c:/mingw/bin/../lib/clang/3.3/../../../x86_64-w64-mingw32/include\ctype.h:201:41: note: expanded from macro '__chvalidchk' > #define __chvalidchk(a,b) (__PCTYPE_FUNC[(a)] & (b))