Re: [Mingw-w64-public] winpthreads patch for pthread_getspecific()/pthread_setspecific() function for restore WIN last error code

2012-07-16 Thread Antony Riakiotakis
We also experience an issue with boost::filesystem::exists in blender. If this fixes that it will be a blessing :). -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and thre

Re: [Mingw-w64-public] [patch] winbase.h: Use documented type in calls to Interlocked functions

2012-07-16 Thread Corinna Vinschen
On Jul 16 20:44, Ozkan Sezer wrote: > On 7/16/12, Corinna Vinschen wrote: > > [New and improved: This time with attachement!] > > > > On Jul 16 18:58, Corinna Vinschen wrote: > >> Hi, > >> > >> as discussed on IRC, I propose the below patch. It changes the > >> calls of the Interlocked functions

Re: [Mingw-w64-public] [patch] winbase.h: Use documented type in calls to Interlocked functions

2012-07-16 Thread Ozkan Sezer
On 7/16/12, Corinna Vinschen wrote: > [New and improved: This time with attachement!] > > On Jul 16 18:58, Corinna Vinschen wrote: >> Hi, >> >> as discussed on IRC, I propose the below patch. It changes the >> calls of the Interlocked functions from the C++ Interlocked inline >> functions defined

Re: [Mingw-w64-public] [patch] winbase.h: Use documented type in calls to Interlocked functions

2012-07-16 Thread Kai Tietz
Hello Corinna, patch looks ok for me. I assume Jacek has no objections, so please go ahead. Thanks, Kai -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat lands

Re: [Mingw-w64-public] [patch] winbase.h: Use documented type in calls to Interlocked functions

2012-07-16 Thread Corinna Vinschen
[New and improved: This time with attachement!] On Jul 16 18:58, Corinna Vinschen wrote: > Hi, > > as discussed on IRC, I propose the below patch. It changes the > calls of the Interlocked functions from the C++ Interlocked inline > functions defined at the end of winbase.h to use the system typ

[Mingw-w64-public] [patch] winbase.h: Use documented type in calls to Interlocked functions

2012-07-16 Thread Corinna Vinschen
Hi, as discussed on IRC, I propose the below patch. It changes the calls of the Interlocked functions from the C++ Interlocked inline functions defined at the end of winbase.h to use the system types just as these functions are defined. Ok to apply? Thanks, Corinna ---

Re: [Mingw-w64-public] [patch] _mingw.h: Introduce the __32LONG macro

2012-07-16 Thread Corinna Vinschen
On Jul 16 15:56, Kai Tietz wrote: > Well, > > I would like to have here one define for long, which is then later on > used consistently to replace use of 'long' type. I don't see much > advantage in adding here a signed and a unsigned variant to _mingw.h > header. We want to replace use of 'long

Re: [Mingw-w64-public] winpthreads patch for pthread_getspecific()/pthread_setspecific() function for restore WIN last error code

2012-07-16 Thread Kai Tietz
Well, I am fine by this patch, but I would love to get additional a testcase added for it. So patch is ok with a testcase. Thanks, Kai -- Live Security Virtual Conference Exclusive live event will cover all the ways tod

Re: [Mingw-w64-public] winpthreads patch for pthread_getspecific()/pthread_setspecific() function for restore WIN last error code

2012-07-16 Thread Ruben Van Boxem
2012/7/16 niXman > 2012/7/16 Ozkan Sezer: > > > This was discussed quite some time ago and the suggested changes > > look OK to me at first glance. As a reference, pthreads-win32 restores > > the last error for pthread_getspecific() (but not for > pthread_setspecific() > > as far as I can see.) >

Re: [Mingw-w64-public] winpthreads patch for pthread_getspecific()/pthread_setspecific() function for restore WIN last error code

2012-07-16 Thread niXman
2012/7/16 Ozkan Sezer: > This was discussed quite some time ago and the suggested changes > look OK to me at first glance. As a reference, pthreads-win32 restores > the last error for pthread_getspecific() (but not for pthread_setspecific() > as far as I can see.) Without the restoration of the l

Re: [Mingw-w64-public] [patch] _mingw.h: Introduce the __32LONG macro

2012-07-16 Thread Kai Tietz
Well, I would like to have here one define for long, which is then later on used consistently to replace use of 'long' type. I don't see much advantage in adding here a signed and a unsigned variant to _mingw.h header. We want to replace use of 'long' keyword. So by this, the keyword 'long' defi

Re: [Mingw-w64-public] winpthreads patch for pthread_getspecific()/pthread_setspecific() function for restore WIN last error code

2012-07-16 Thread Ozkan Sezer
On Sat, Jul 14, 2012 at 12:23 PM, niXman wrote: > Patch in attachment. > > -- > Regards, > niXman This was discussed quite some time ago and the suggested changes look OK to me at first glance. As a reference, pthreads-win32 restores the last error for pthread_getspecific() (but not for pthread_s

Re: [Mingw-w64-public] [patch] _mingw.h: Introduce the __32LONG macro

2012-07-16 Thread Ozkan Sezer
On Mon, Jul 16, 2012 at 4:43 PM, Corinna Vinschen wrote: > On Jul 13 09:54, Corinna Vinschen wrote: >> On Jul 13 10:24, Ozkan Sezer wrote: >> > On Fri, Jul 13, 2012 at 10:09 AM, Kai Tietz >> > wrote: >> > > The cause for that I was suggesting __32LONG is that name is more >> > > unlikely to be m

Re: [Mingw-w64-public] [patch] _mingw.h: Introduce the __32LONG macro

2012-07-16 Thread Corinna Vinschen
On Jul 13 09:54, Corinna Vinschen wrote: > On Jul 13 10:24, Ozkan Sezer wrote: > > On Fri, Jul 13, 2012 at 10:09 AM, Kai Tietz wrote: > > > The cause for that I was suggesting __32LONG is that name is more > > > unlikely to be mixed-up with a real type. > > > > > > > Yuck, nonetheless.. Maybe WI

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread Jacek Caban
On 07/16/12 14:26, Ozkan Sezer wrote: > On Mon, Jul 16, 2012 at 3:03 PM, JonY wrote: >> On 7/16/2012 19:10, JonY wrote: >>> On 7/16/2012 18:46, Ozkan Sezer wrote: On Mon, Jul 16, 2012 at 1:38 PM, JonY wrote: > On 7/16/2012 17:19, Jacek Caban wrote: >> Sorry about that, I treat my git

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread Ozkan Sezer
On Mon, Jul 16, 2012 at 3:03 PM, JonY wrote: > On 7/16/2012 19:10, JonY wrote: >> On 7/16/2012 18:46, Ozkan Sezer wrote: >>> On Mon, Jul 16, 2012 at 1:38 PM, JonY wrote: On 7/16/2012 17:19, Jacek Caban wrote: > Sorry about that, I treat my git repository as a temporary place for > pat

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread JonY
On 7/16/2012 19:10, JonY wrote: > On 7/16/2012 18:46, Ozkan Sezer wrote: >> On Mon, Jul 16, 2012 at 1:38 PM, JonY wrote: >>> On 7/16/2012 17:19, Jacek Caban wrote: Sorry about that, I treat my git repository as a temporary place for patch reviews, so they may disappear once I push new ver

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread JonY
On 7/16/2012 18:46, Ozkan Sezer wrote: > On Mon, Jul 16, 2012 at 1:38 PM, JonY wrote: >> On 7/16/2012 17:19, Jacek Caban wrote: >>> Sorry about that, I treat my git repository as a temporary place for >>> patch reviews, so they may disappear once I push new versions. Here is a >>> link to a patch a

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread Ozkan Sezer
On Mon, Jul 16, 2012 at 1:38 PM, JonY wrote: > On 7/16/2012 17:19, Jacek Caban wrote: >> Sorry about that, I treat my git repository as a temporary place for >> patch reviews, so they may disappear once I push new versions. Here is a >> link to a patch already committed to the trunk (which should

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread JonY
On 7/16/2012 17:19, Jacek Caban wrote: > Sorry about that, I treat my git repository as a temporary place for > patch reviews, so they may disappear once I push new versions. Here is a > link to a patch already committed to the trunk (which should be > persistent since it's already in mingw-w64): >

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread Jacek Caban
On 07/16/12 11:06, JonY wrote: > On 7/16/2012 16:33, Jacek Caban wrote: >> On 07/15/12 14:21, Nicolas Le Cam wrote: >>> 2012/7/4 Jacek Caban: On 07/03/12 20:10, Jacek Caban wrote: > On 06/29/12 03:35, Austin English wrote: >> On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam wrote: >

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread JonY
On 7/16/2012 16:33, Jacek Caban wrote: > On 07/15/12 14:21, Nicolas Le Cam wrote: >> 2012/7/4 Jacek Caban: >>> On 07/03/12 20:10, Jacek Caban wrote: On 06/29/12 03:35, Austin English wrote: > On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam wrote: >> 2012/6/29 Austin English : >>> F

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread Jacek Caban
On 07/16/12 11:02, Ozkan Sezer wrote: > On Mon, Jul 16, 2012 at 11:33 AM, Jacek Caban wrote: >> On 07/15/12 14:21, Nicolas Le Cam wrote: >>> 2012/7/4 Jacek Caban : On 07/03/12 20:10, Jacek Caban wrote: > On 06/29/12 03:35, Austin English wrote: >> On Thu, Jun 28, 2012 at 6:30 PM, Nico

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread Ozkan Sezer
On Mon, Jul 16, 2012 at 11:33 AM, Jacek Caban wrote: > On 07/15/12 14:21, Nicolas Le Cam wrote: >> 2012/7/4 Jacek Caban : >>> On 07/03/12 20:10, Jacek Caban wrote: On 06/29/12 03:35, Austin English wrote: > On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam > wrote: >> 2012/6/29 Au

Re: [Mingw-w64-public] include: fix mingw64 build

2012-07-16 Thread Jacek Caban
On 07/15/12 14:21, Nicolas Le Cam wrote: > 2012/7/4 Jacek Caban : >> On 07/03/12 20:10, Jacek Caban wrote: >>> On 06/29/12 03:35, Austin English wrote: On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam wrote: > 2012/6/29 Austin English : >> Fixes http://bugs.winehq.org/show_bug.cg