Re: [Mesa-dev] [PATCH 09/15] freedreno: implement pipe_screen::get_driver_query_group_info

2015-03-11 Thread Rob Clark
On Wed, Mar 11, 2015 at 4:19 AM, Samuel Pitoiset wrote: > > > On 03/11/2015 12:30 AM, Rob Clark wrote: >> >> On Mon, Mar 9, 2015 at 5:09 PM, Samuel Pitoiset >> wrote: >>> >>> This enables GL_AMD_performance_monitor for freedreno. >>> >>

Re: [Mesa-dev] [PATCH 09/15] freedreno: implement pipe_screen::get_driver_query_group_info

2015-03-11 Thread Rob Clark
On Wed, Mar 11, 2015 at 8:18 AM, Rob Clark wrote: > On Wed, Mar 11, 2015 at 4:19 AM, Samuel Pitoiset > wrote: >> >> >> On 03/11/2015 12:30 AM, Rob Clark wrote: >>> >>> On Mon, Mar 9, 2015 at 5:09 PM, Samuel Pitoiset >>> wrote: >>>

Re: [Mesa-dev] OpenGL ES 3.0 support

2015-03-23 Thread Rob Clark
On Mon, Mar 23, 2015 at 3:59 PM, Ilia Mirkin wrote: > On Mon, Mar 23, 2015 at 3:57 PM, Shervin Sharifi wrote: >> Hi, >> >> I'm new to Mesa and I'm trying to understand the status of OpenGL ES 3.0 >> support in Mesa. >> I'm mainly interested in using llvm-pipe backend (software rendering). > > h

Re: [Mesa-dev] [PATCH] st/mesa: remove copy-propagation pass

2015-03-25 Thread Rob Clark
mize->tgsi if it was that big of a problem. Reviewed-by: Rob Clark > > Marek > > On Wed, Mar 25, 2015 at 6:34 PM, Ilia Mirkin wrote: >> It's buggy and unnecessary in the presence of optimizing backends. The >> only backend that will suffer is nv30, but... meh. >&

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-26 Thread Rob Clark
On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote: > On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand wrote: >> On Thu, Mar 26, 2015 at 12:00 PM, Aditya Avinash >> wrote: >>> I mean, implementing fp64 on single precision systems. >> >> Ok, That makes more sense! Having lowering passes for vario

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-26 Thread Rob Clark
-R On Thu, Mar 26, 2015 at 8:54 PM, Aditya Avinash wrote: > Are you suggesting bringing OpenCL support for Adreno gpus and using > softfloat? > > On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote: >> >> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote: >> > On T

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-26 Thread Rob Clark
On Thu, Mar 26, 2015 at 8:59 PM, Ilia Mirkin wrote: > On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote: >> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mirkin wrote: >>> On Thu, Mar 26, 2015 at 3:02 PM, Jason Ekstrand >>> wrote: >>>> On Thu, Mar 26, 2015

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-26 Thread Rob Clark
On Thu, Mar 26, 2015 at 10:17 PM, Jan Vesely wrote: > On Thu, 2015-03-26 at 21:11 -0400, Rob Clark wrote: >> On Thu, Mar 26, 2015 at 8:59 PM, Ilia Mirkin wrote: >> > On Thu, Mar 26, 2015 at 8:50 PM, Rob Clark wrote: >> >> On Thu, Mar 26, 2015 at 3:10 PM, Ilia Mir

[Mesa-dev] [PATCH] nir: add option to lower slt/sge/seq/sne

2015-03-31 Thread Rob Clark
From: Rob Clark In freedreno these get implemented as the matching f* instruction plus a u2f to convert the result to float 1.0/0.0. But less lines of code to just let nir_opt_algebraic handle this for us, plus opens up some small window for other opt passes to improve (ie. if some shader ended

Re: [Mesa-dev] [PATCH] nir: add option to lower slt/sge/seq/sne

2015-03-31 Thread Rob Clark
On Tue, Mar 31, 2015 at 2:03 PM, Kenneth Graunke wrote: > On Tuesday, March 31, 2015 11:30:17 AM Rob Clark wrote: >> From: Rob Clark >> >> In freedreno these get implemented as the matching f* instruction plus a >> u2f to convert the result to float 1.0/0.0. But le

Re: [Mesa-dev] [PATCH] nir: add option to lower slt/sge/seq/sne

2015-03-31 Thread Rob Clark
On Tue, Mar 31, 2015 at 2:20 PM, Matt Turner wrote: > On Tue, Mar 31, 2015 at 11:11 AM, Rob Clark wrote: >> On Tue, Mar 31, 2015 at 2:03 PM, Kenneth Graunke >> wrote: >>> I'm pretty sure you want b2f here, not u2f...the slt/sge/seq/sne opcodes >>> are def

Re: [Mesa-dev] [PATCH] nir: add option to lower slt/sge/seq/sne

2015-03-31 Thread Rob Clark
On Tue, Mar 31, 2015 at 2:33 PM, Matt Turner wrote: > On Tue, Mar 31, 2015 at 11:30 AM, Rob Clark wrote: >> On Tue, Mar 31, 2015 at 2:20 PM, Matt Turner wrote: >>> Alternatively, Jason's implemented a pass to "resolve" booleans to >>> these values,

[Mesa-dev] [PATCH 2/4] nir: fix typo for f2b description

2015-03-31 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/glsl/nir/nir_opcodes.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py index 062cd62..b92fc7e 100644 --- a/src/glsl/nir/nir_opcodes.py +++ b/src/glsl/nir

[Mesa-dev] [PATCH 1/4] nir: add option to lower slt/sge/seq/sne

2015-03-31 Thread Rob Clark
From: Rob Clark In freedreno these get implemented as the matching f* instruction plus a u2f to convert the result to float 1.0/0.0. But less lines of code to just let nir_opt_algebraic handle this for us, plus opens up some small window for other opt passes to improve (ie. if some shader ended

[Mesa-dev] [PATCH 4/4] RFC: nir: add lowering for idiv/udiv/umod

2015-03-31 Thread Rob Clark
From: Rob Clark Based on the algo from NV50LegalizeSSA::handleDIV() and handleMOD(). See also trans_idiv() in freedreno/ir3/ir3_compiler.c (which was an adaptation of the nv50 code from Ilia). Just sending as an rfc right now, since I'm not quite at the point to be able to test it on actu

[Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

2015-03-31 Thread Rob Clark
From: Rob Clark Freedreno and vc4 want this behavior for the time being (until we have real flow control). Even after that, we probably want to turn this into some sort of driver tunable threshold, since for at least some hardware, reasonably large if/else is best flattend rather than having

Re: [Mesa-dev] [PATCH 1/4] nir: add option to lower slt/sge/seq/sne

2015-03-31 Thread Rob Clark
On Tue, Mar 31, 2015 at 8:54 PM, Kenneth Graunke wrote: > On Tuesday, March 31, 2015 06:57:30 PM Rob Clark wrote: >> From: Rob Clark >> >> In freedreno these get implemented as the matching f* instruction plus a >> u2f to convert the result to float 1.0/0.0. But le

Re: [Mesa-dev] [PATCH 4/4] RFC: nir: add lowering for idiv/udiv/umod

2015-03-31 Thread Rob Clark
On Tue, Mar 31, 2015 at 9:03 PM, Roland Scheidegger wrote: > Am 01.04.2015 um 00:57 schrieb Rob Clark: >> From: Rob Clark >> >> Based on the algo from NV50LegalizeSSA::handleDIV() and handleMOD(). >> See also trans_idiv() in freedreno/ir3/ir3_compiler.c (which was a

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

2015-04-01 Thread Rob Clark
On Tue, Mar 31, 2015 at 7:08 PM, Matt Turner wrote: > On Tue, Mar 31, 2015 at 3:57 PM, Rob Clark wrote: >> From: Rob Clark >> >> Freedreno and vc4 want this behavior for the time being (until we have >> real flow control). Even after that, we probably want to tur

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

2015-04-01 Thread Rob Clark
On Wed, Apr 1, 2015 at 6:56 PM, Jason Ekstrand wrote: > On Tue, Mar 31, 2015 at 3:57 PM, Rob Clark wrote: >> From: Rob Clark >> >> Freedreno and vc4 want this behavior for the time being (until we have >> real flow control). Even after that, we probably want to tur

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

2015-04-02 Thread Rob Clark
On Thu, Apr 2, 2015 at 1:24 PM, Jason Ekstrand wrote: > On Thu, Apr 2, 2015 at 1:20 AM, Kenneth Graunke wrote: >> On Wednesday, April 01, 2015 07:22:40 PM Connor Abbott wrote: >>> I think it might be better here if we had a callback that backends can >>> fill in that tells you when an instruction

[Mesa-dev] [PATCH 2/2] nir: fix typo for f2b/i2b/b2i expressions (v2)

2015-04-02 Thread Rob Clark
From: Rob Clark v2: discovered that i2b/b2i are also confused Signed-off-by: Rob Clark --- src/glsl/nir/nir_opcodes.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py index 062cd62..f96424f 100644 --- a/src

[Mesa-dev] [PATCH 1/2] nir: add option to lower slt/sge/seq/sne

2015-04-02 Thread Rob Clark
From: Rob Clark In freedreno these get implemented as the matching f* instruction plus a u2f to convert the result to float 1.0/0.0. But less lines of code to just let nir_opt_algebraic handle this for us, plus opens up some small window for other opt passes to improve (ie. if some shader ended

Re: [Mesa-dev] [PATCH 3/4] nir: support to flatten_all in peephole-select

2015-04-02 Thread Rob Clark
On Thu, Apr 2, 2015 at 3:19 PM, Connor Abbott wrote: > On Thu, Apr 2, 2015 at 1:32 PM, Rob Clark wrote: >> On Thu, Apr 2, 2015 at 1:24 PM, Jason Ekstrand wrote: >>> On Thu, Apr 2, 2015 at 1:20 AM, Kenneth Graunke >>> wrote: >>>> On Wednesday, April 0

Re: [Mesa-dev] [PATCH 4/4] RFC: nir: add lowering for idiv/udiv/umod

2015-04-03 Thread Rob Clark
On Wed, Apr 1, 2015 at 9:50 AM, Ilia Mirkin wrote: > On Wed, Apr 1, 2015 at 7:09 AM, Roland Scheidegger wrote: >> Am 01.04.2015 um 03:44 schrieb Rob Clark: >>> On Tue, Mar 31, 2015 at 9:03 PM, Roland Scheidegger >>> wrote: >>>> Am 01.04.2015 um 00:57 sc

[Mesa-dev] [PATCH] nir: add lowering for idiv/udiv/umod

2015-04-03 Thread Rob Clark
From: Rob Clark Based on the algo from NV50LegalizeSSA::handleDIV() and handleMOD(). See also trans_idiv() in freedreno/ir3/ir3_compiler.c (which was an adaptation of the nv50 code from Ilia Mirkin). Also, including a py script that implements the same algo with numpy, based on something

[Mesa-dev] [PATCH 2/2] xa: support for drivers which use NIR

2015-04-03 Thread Rob Clark
From: Rob Clark We need to pull in libnir.la and it's dependency libglsl_util.la. Also, _mesa_error_no_memory() must be defined. Fortunately with libnir.la (vs pulling in all of libglsl.la) we don't also need libstdc++. Signed-off-by: Rob Clark --- src/gallium/state_trackers/xa/xa

[Mesa-dev] [PATCH 1/2] build: add libnir.la

2015-04-03 Thread Rob Clark
From: Rob Clark If we want to use NIR from state trackers that don't already pull in the whole of glsl (ie. anything other than mesa state tracker), we need a separate more minimal libnir. Possibly NIR should be better split out from glsl, but for now, generate a second smaller libnir.l

[Mesa-dev] [PATCH] nir: split out lower_sub from lower_negate

2015-04-04 Thread Rob Clark
From: Rob Clark Originally you had to have one or the other. But actually I don't want either. (Or rather I want whatever is the minimum # of instructions.) TODO: not sure where the best place to insert a check that driver hasn't set *both* lower_negate and lower_sub? Signed-o

[Mesa-dev] [PATCH] gallium/ttn: fix for arrays vs regs

2015-04-06 Thread Rob Clark
From: Rob Clark Just because there is array access, doesn't mean everything is an array. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxi

[Mesa-dev] [RFC 1/2] nir: add intrinsics for load/store global

2015-04-07 Thread Rob Clark
From: Rob Clark Seemed like these were missing in action? This is how it works for other vars (uniform/shader_in/shader_out/etc), so seemed sensible. Signed-off-by: Rob Clark --- src/glsl/nir/nir_intrinsics.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/glsl

[Mesa-dev] [RFC 2/2] gallium/ttn: add support for temp arrays

2015-04-07 Thread Rob Clark
From: Rob Clark Since the rest of NIR really would rather have these as variables rather than registers, create a nir_variable per array. But rather than completely re-arrange ttn to be variable based rather than register based, keep the registers. In the cases where there is a matching var

[Mesa-dev] [RFC 0/2] nir and ttn support for indirect/arrays

2015-04-07 Thread Rob Clark
From: Rob Clark Introduce intrinsics to load/store global vars (since I'm not sure what the point is to have global as a var type if there is no way to access it, but maybe I'm missing something), and update ttn to generate global variables for arrays. So, for example: FRAG

Re: [Mesa-dev] [RFC 2/2] gallium/ttn: add support for temp arrays

2015-04-07 Thread Rob Clark
On Tue, Apr 7, 2015 at 12:32 PM, Jason Ekstrand wrote: > On Tue, Apr 7, 2015 at 8:52 AM, Rob Clark wrote: >> From: Rob Clark >> >> Since the rest of NIR really would rather have these as variables rather >> than registers, create a nir_variable per array. But r

[Mesa-dev] [PATCH] gallium/ttn: add support for temp arrays

2015-04-07 Thread Rob Clark
From: Rob Clark Since the rest of NIR really would rather have these as variables rather than registers, create a nir_variable per array. But rather than completely re-arrange ttn to be variable based rather than register based, keep the registers. In the cases where there is a matching var

[Mesa-dev] [PATCH] gallium/ttn: use single component address register

2015-04-08 Thread Rob Clark
From: Rob Clark Only needs to be a vec1, and this helps out the later opt stages. From the shader (after opt) for fs-temp-array-mat3-index-col-row-wr goes, before: vec1 ssa_408 = imul ssa_155, ssa_1 vec4 ssa_413 = vec4 ssa_408, ssa_412.y, ssa_412.z, ssa_412.w vec4

Re: [Mesa-dev] [PATCH] gallium/ttn: add support for temp arrays

2015-04-08 Thread Rob Clark
On Wed, Apr 8, 2015 at 11:14 AM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> Since the rest of NIR really would rather have these as variables rather >> than registers, create a nir_variable per array. But rather than >> completely

[Mesa-dev] [PATCH] nir: fix bit of cargo-culting in lower_idiv

2015-04-10 Thread Rob Clark
From: Rob Clark I guess I was looking too much at how lower_system_values worked when writing lower_idiv. Since ttn wasn't emitting load_var for sysvals and the only drivers using lower_idiv were using ttn, I think nothing was broken as a result. But might as well fix this before it beco

Re: [Mesa-dev] [PATCH 2/2] gallium/ttn: add TXQ support

2015-04-09 Thread Rob Clark
On Thu, Apr 9, 2015 at 3:43 PM, Rob Clark wrote: > From: Rob Clark > > Split out from ttn_tex() since it is kind of a weird instruction that > maps to two NIR opcodes, and it was cleaner this way. > as Ilia pointed out on IRC, query_levels should have no src args.. I've fix

[Mesa-dev] [PATCH 2/2] gallium/ttn: add TXQ support

2015-04-09 Thread Rob Clark
From: Rob Clark Split out from ttn_tex() since it is kind of a weird instruction that maps to two NIR opcodes, and it was cleaner this way. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 61 - 1 file changed, 53 insertions(+), 8

[Mesa-dev] [PATCH 1/3] gallium/ttn: minor cleanup

2015-04-08 Thread Rob Clark
From: Rob Clark Extract tgsi_dst->Index into a local.. split out from 'gallium/ttn: add support for temp arrays' for noise reduction.. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) dif

Re: [Mesa-dev] [PATCH 2/3] gallium/ttn: add support for temp arrays

2015-04-08 Thread Rob Clark
On Wed, Apr 8, 2015 at 6:34 PM, Rob Clark wrote: > From: Rob Clark > > Since the rest of NIR really would rather have these as variables rather > than registers, create a nir_variable per array. But rather than > completely re-arrange ttn to be variable based rather than registe

[Mesa-dev] [PATCH 1/2] gallium/ttn: split out helper to get texture info

2015-04-09 Thread Rob Clark
From: Rob Clark We'll need this as well for TXQ. Split this out first to reduce noise in the next patch. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 112 +--- 1 file changed, 59 insertions(+), 53 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH 3/3] gallium/ttn: use single component address register

2015-04-08 Thread Rob Clark
From: Rob Clark Only needs to be a vec1, and this helps out the later opt stages. From the shader (after opt) for fs-temp-array-mat3-index-col-row-wr goes, before: vec1 ssa_408 = imul ssa_155, ssa_1 vec4 ssa_413 = vec4 ssa_408, ssa_412.y, ssa_412.z, ssa_412.w vec4

[Mesa-dev] [PATCH 2/3] gallium/ttn: add support for temp arrays

2015-04-08 Thread Rob Clark
From: Rob Clark Since the rest of NIR really would rather have these as variables rather than registers, create a nir_variable per array. But rather than completely re-arrange ttn to be variable based rather than register based, keep the registers. In the cases where there is a matching var

[Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

2015-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 9d988b06..c9f9e03

[Mesa-dev] [PATCH 3/4] gallium/ttn: minor cleanup

2015-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index a2f15ed..610e5d9 100644 --- a/src

[Mesa-dev] [PATCH 4/4] gallium/ttn: add UBO support

2015-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 63 - 1 file changed, 54 insertions(+), 9 deletions(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 610e5d9..bdbbe16

[Mesa-dev] [PATCH 2/4] gallium/ttn: add support for TXL2

2015-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index c9f9e03..a2f15ed 100644 --- a/src/gallium/auxiliary/nir

Re: [Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

2015-04-13 Thread Rob Clark
On Mon, Apr 13, 2015 at 1:34 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/gallium/auxiliary/nir/tgsi_to_nir.c | 30 +- >> 1 file changed, 29 insertions(+), 1

[Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
From: Rob Clark Add compiler options so driver can request the units for address value, for the various _indirect intrinsics. This way, the front end can insert the appropriate multiply/shift operations to get the address into the units that the driver needs, avoiding need for driver to insert

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> Add compiler options so driver can request the units for address value, >> for the various _indirect intrinsics. This way, the front end can >> insert the appr

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 3:32 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 11:54 AM, Rob Clark wrote: >> On Tue, Apr 14, 2015 at 1:56 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> >>>> From: Rob Clark >>>> >>>> Add com

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand wrote: >> + /** >> +* Addressing mode for corresponding _indirect intrinsics: >> +*/ >> + nir_addressing_mode var_addressing_mode; >> + nir_addressing_mode input_addressing_mode; >> + nir_addressing_mode output

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 6:24 PM, Connor Abbott wrote: > On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: >> On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand wrote: >>>>>>>> + /** >>>>>>>> +

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-14 Thread Rob Clark
On Tue, Apr 14, 2015 at 7:08 PM, Rob Clark wrote: > On Tue, Apr 14, 2015 at 6:24 PM, Connor Abbott wrote: >> On Tue, Apr 14, 2015 at 5:16 PM, Rob Clark wrote: >>> On Tue, Apr 14, 2015 at 4:59 PM, Jason Ekstrand >>> wrote: >>>>>>>>> +

Re: [Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

2015-04-15 Thread Rob Clark
On Tue, Apr 14, 2015 at 1:04 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> Signed-off-by: Rob Clark > > 1-3 (with the fix to 1 that you posted in irc) are: > > Reviewed-by: Eric Anholt > > I don't like the mismatch on byte

Re: [Mesa-dev] [RFC] nir: compiler options for addressing modes

2015-04-15 Thread Rob Clark
On Wed, Apr 15, 2015 at 10:32 AM, Connor Abbott wrote: >> >> But more immediately, I hit a sort of snag: I cannot seem to narrow >> from 32b to 16b at the same time I move to address register. Which >> ends up meaning I need a mov from 32b to 16b followed by a 2nd mov to >> get it into address r

[Mesa-dev] [PATCH] nir/builder: add nir_builder_insert_after_instr()

2015-04-15 Thread Rob Clark
From: Rob Clark For lowering if/else, I need a way to insert at the end of the previous block. Signed-off-by: Rob Clark --- src/glsl/nir/nir_builder.h | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/glsl/nir/nir_builder.h b/src/glsl/nir

[Mesa-dev] [PATCH] gallium/ttn: add UBO support

2015-04-15 Thread Rob Clark
From: Rob Clark v2: move ishl into ttn (instead of driver backend) to keep the units consistent between immediate and indirect offsets Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 69 - 1 file changed, 60 insertions(+), 9 deletions

Re: [Mesa-dev] [PATCH 4/9] prog; add weak _mesa_error_no_memory() symbol and add it to libglsl_util

2015-04-15 Thread Rob Clark
vide their own definition of the symbol >>>> provide a common weak one, which anyone can override if needed. >>>> >>>> This resolved the build of the standalone pipe-drivers, as it provides a >>>> default symbol which was missing previously. &g

[Mesa-dev] [PATCH] gallium/ttn: fix TXF

2015-04-16 Thread Rob Clark
From: Rob Clark There is an level param stashed away in the .w component of the first src. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium

Re: [Mesa-dev] [PATCH 08/12] nir/types: Make glsl_get_length smarter

2015-04-17 Thread Rob Clark
On Fri, Apr 10, 2015 at 8:48 PM, Jason Ekstrand wrote: > Previously, this function returned the number of elements for structures > and arrays and 0 for everything else. In NIR, this is almost never what > you want because we also treat matricies as arrays so you have to > special-case constantly

Re: [Mesa-dev] [PATCH 08/12] nir/types: Make glsl_get_length smarter

2015-04-17 Thread Rob Clark
On Fri, Apr 17, 2015 at 9:03 AM, Rob Clark wrote: > On Fri, Apr 10, 2015 at 8:48 PM, Jason Ekstrand wrote: >> Previously, this function returned the number of elements for structures >> and arrays and 0 for everything else. In NIR, this is almost never what >> you want

Re: [Mesa-dev] [RFC 6/9] nir: Add an entirely C-based linked list implementation

2015-04-24 Thread Rob Clark
On Fri, Apr 24, 2015 at 7:32 PM, Jason Ekstrand wrote: > This commit adds a C-based linked list implementation for NIR. Unlike > exec_list in glsl/list.h, there is no C++ API. Also, this list is based on > wl_list (from the Wayland project) which is, in turn, based on the kernel > list. As such

Re: [Mesa-dev] intel skylake gpu support

2016-02-16 Thread Rob Clark
Try xf86-video-modesetting instead of xf86-video-intel.. BR, -R On Tue, Feb 16, 2016 at 2:24 AM, Jarkko Korpi wrote: > I have 3 questions for you. > > I noticed that opengl 4.0 support is missing just 1 extension > GL_ARB_gpu_shader_fp64. Is there any estimated schedule this to finnish? > > Then

Re: [Mesa-dev] intel skylake gpu support

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 11:09 AM, Ben Widawsky wrote: > On Tue, Feb 16, 2016 at 10:39:23AM -0500, Rob Clark wrote: >> Try xf86-video-modesetting instead of xf86-video-intel.. > > Might I inquire the thought behind this? It's my impression that unless one is > using glamor,

[Mesa-dev] [PATCH] st/mesa: add missing ETC2 entries to format_map

2016-02-16 Thread Rob Clark
From: Rob Clark Noticed by Ilia when I was trying to figure out why some app was failing to use ETC2. Signed-off-by: Rob Clark Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_format.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/mesa

[Mesa-dev] [PATCH 00/10] Clean up most of the new gcc6 warnings

2016-02-16 Thread Rob Clark
From: Rob Clark gcc6 landed in rawhide, and all of a sudden building mesa got very noisy. This patchset cleans up most of the warnings (especially the first one which shows up everywhere that #includes hash_table.h) There are two remaining: src/gallium/auxiliary/util/u_debug_stack.c: In

[Mesa-dev] [PATCH 09/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
_has_explicit_location && ~~~ qual->flags.q.explicit_location))) { ~~~~~~~~~ Signed-off-by: Rob Clark --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b

[Mesa-dev] [PATCH 03/10] gallium/auxiliary: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
fer/pb_bufmgr_mm.c:286:1: note: ...this ‘if’ clause, but it is not if(mm->heap) ^~ Signed-off-by: Rob Clark --- src/gallium/auxiliary/pipebuffer/pb_bufmgr_mm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/pipebuffer/pb_bufmgr_mm.c b/src/gallium/aux

[Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/util/hash_table.h:111:23: warning: ‘_mesa_fnv32_1a_offset_bias’ defined but not used [-Wunused-const-variable] static const uint32_t _mesa_fnv32_1a_offset_bias = 2166136261u; ^~ Signed-off-by: Rob Clark --- src/util/hash_table.h | 2 +- 1

[Mesa-dev] [PATCH 02/10] gallium/hud: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
}; ^~~ many more.. These are simply unused, just #if 0 them out for now, in case someone wants to use them in the future. Signed-off-by: Rob Clark --- src/gallium/auxiliary/hud/font.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium

[Mesa-dev] [PATCH 04/10] trace: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
in: commit 5494332128da0b2826e85df5eeaa878bb5c30a4e Author: Jakob Bornecrantz Date: Wed May 12 19:26:19 2010 +0100 trace: Remove rbug from trace Signed-off-by: Rob Clark --- src/gallium/drivers/trace/tr_context.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 07/10] i965: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
is intended to be unused (ie. just for adding on-demand debug prints) Signed-off-by: Rob Clark --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp b/src/mesa/drivers

[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
was a latent bug? Could be that was intended to override visit(ir_loop_jump *)? Signed-off-by: Rob Clark --- src/compiler/glsl/lower_discard_flow.cpp | 12 1 file changed, 12 deletions(-) diff --git a/src/compiler/glsl/lower_discard_flow.cpp b/src/compiler/glsl

[Mesa-dev] [PATCH 05/10] postprocess: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
pp_filter_t pp_filters[PP_FILTERS] = { ^~ Note, this one we may actually want to move into an .c file instead? Signed-off-by: Rob Clark --- src/gallium/auxiliary/postprocess/filters.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 10/10] mesa: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
}; ^~~~ These appear to be unused since: commit 8ec6534b266549cdc2798e2523bf6753924f6cde Author: Iago Toral Quiroga AuthorDate: Wed Oct 15 13:42:11 2014 +0200 mesa: Use _mesa_format_convert to implement texstore_rgba. Signed-off-by: Rob Clark --- src/mesa/main/texstore.c | 3 --- 1 file changed

[Mesa-dev] [PATCH 06/10] freedreno/ir3: fix new gcc6 errors

2016-02-16 Thread Rob Clark
8750299a420af76cebd3067f6f603eacde06ae06 Author: Jason Ekstrand Date: Tue Feb 9 14:51:28 2016 -0800 nir: Remove the const_offset from nir_tex_instr Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src

Re: [Mesa-dev] Where do we put a Vulkan driver?

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 1:39 PM, Jason Ekstrand wrote: > So, we just pushed a branch containing a Vulkan driver. Naturally, we > would like to incorporate that driver into the upstream mesa tree. While > we work on upstreaming the prerequisites in NIR and the i965 back-end > compiler, there is a

Re: [Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 2:37 PM, Ian Romanick wrote: > On 02/16/2016 10:57 AM, Rob Clark wrote: >> src/util/hash_table.h:111:23: warning: ‘_mesa_fnv32_1a_offset_bias’ defined >> but not used [-Wunused-const-variable] >> static const uint32_t _mesa_fnv32_1a_offs

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 2:32 PM, Ian Romanick wrote: > On 02/16/2016 10:58 AM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not us

Re: [Mesa-dev] [PATCH] st/mesa: add missing ETC2 entries to format_map

2016-02-16 Thread Rob Clark
atch > makes it work for drivers that *do* support it in HW, but more work > needed for the other drivers. Maybe we should just have the > PIPE_FORMAT_RGBA8 stuff right in there as fallback formats? [Would > need to do that for ETC1 as well.] > > On Tue, Feb 16, 2016 at 12:0

Re: [Mesa-dev] Gallium Vulkan state tracker?

2016-02-17 Thread Rob Clark
On Wed, Feb 17, 2016 at 10:04 AM, Jose Fonseca wrote: > On 17/02/16 10:24, Dave Airlie wrote: >> >> On 17 February 2016 at 18:31, Ernst Sjöstrand wrote: >>> >>> Hi! >>> >>> Sorry if this is a silly question but I was thinking that there would >>> be a Vulkan Gallium state tracker in development b

[Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
#define is funny looking, and changing the case would have been more churn. Signed-off-by: Rob Clark --- src/util/hash_table.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/hash_table.h b/src/util/hash_table.h index 85b013c..c69abfa 100644 --- a/src/util

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
On Tue, Feb 16, 2016 at 2:32 PM, Ian Romanick wrote: > On 02/16/2016 10:58 AM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not us

[Mesa-dev] [PATCH] glsl: fix standalone compiler

2016-02-17 Thread Rob Clark
From: Rob Clark Need to set some non-zero limits for MaxCombinedUniformComponents, otherwise we hit an "Too many shader uniform components" error in the linker. Signed-off-by: Rob Clark --- src/compiler/glsl/main.cpp | 12 1 file changed, 12 insertions(+) diff -

[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
that was intended to be overridden was 'visit(ir_loop_jump *ir)', not visit_entire(). Signed-off-by: Rob Clark --- src/compiler/glsl/lower_discard_flow.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/lower_discard_flow.cpp b/src/com

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
On Wed, Feb 17, 2016 at 4:40 PM, Patrick Baggett wrote: > On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> b

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
ran this through our CI, and I didn't see any regressions cause by it. > I think this is correct, so this patch is > > Reviewed-by: Ian Romanick > > On 02/17/2016 01:35 PM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning:

Re: [Mesa-dev] [PATCH] gallium: introduce load_pipe_screen()

2016-02-18 Thread Rob Clark
On Thu, Feb 18, 2016 at 11:48 AM, Emil Velikov wrote: > Hi Rob, > > On 10 February 2016 at 22:56, Rob Herring wrote: >> Introduce load_pipe_screen() public entry point for other code which >> dlopen()'s gralloc_dri.so for purposes of loading a pipe_screen. This way >> drm_gralloc can avoid static

Re: [Mesa-dev] [PATCH 0/4] OpenSWR driver addition

2016-02-18 Thread Rob Clark
On Thu, Feb 18, 2016 at 6:46 PM, Brian Paul wrote: > On 02/17/2016 06:53 PM, Tim Rowley wrote: >> >> This patch series adds the OpenSWR driver, a new software rasterizer >> project by Intel. The goal of this project is to create a high >> performance, highly scalable renderer targeted towards vis

Re: [Mesa-dev] abundance of branches in mesa.git

2016-02-20 Thread Rob Clark
fwiw, I think a *small* number of topic branches in certain cases makes sense.. I'm definitely in support of a TTL limit (ie. automatically nuke topic branches with no activity in N months, or similar..) BR, -R On Mon, Jun 22, 2015 at 2:23 PM, Marek Olšák wrote: > It's not so important now that

Re: [Mesa-dev] abundance of branches in mesa.git

2016-02-21 Thread Rob Clark
On Sat, Feb 20, 2016 at 4:41 PM, Jason Ekstrand wrote: > On Feb 20, 2016 1:19 PM, "Rob Clark" wrote: >> >> fwiw, I think a *small* number of topic branches in certain cases >> makes sense.. I'm definitely in support of a TTL limit (ie. >> automatically

Re: [Mesa-dev] [PATCH 1/9] st/mesa: rename st_readpixels to st_ReadPixels

2016-02-23 Thread Rob Clark
On Tue, Feb 23, 2016 at 6:45 PM, Brian Paul wrote: > To match the convention of other device driver functions. (since I guess I should try to review more, and I'm waiting for a build.. :-P) Reviewed-by: Rob Clark > --- > src/mesa/state_tracker/st_cb_readpixels.c | 4 ++-- >

Re: [Mesa-dev] [PATCH 2/9] st/mesa: remove useless break statement

2016-02-23 Thread Rob Clark
On Tue, Feb 23, 2016 at 6:45 PM, Brian Paul wrote: > Reviewed-by: Rob Clark > --- > src/mesa/state_tracker/st_manager.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_manager.c > b/src/mesa/state_tracker/st_manager.c > index 84b6536

Re: [Mesa-dev] [PATCH 3/9] mesa: use gl_buffer_index in a few places

2016-02-23 Thread Rob Clark
On Tue, Feb 23, 2016 at 6:45 PM, Brian Paul wrote: > Reviewed-by: Rob Clark > --- > src/mesa/main/buffers.c | 6 +++--- > src/mesa/main/buffers.h | 3 ++- > src/mesa/main/context.c | 2 +- > 3 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/m

Re: [Mesa-dev] [PATCH 4/9] mesa: move declaration of buffer var in handle_first_current()

2016-02-23 Thread Rob Clark
On Tue, Feb 23, 2016 at 6:45 PM, Brian Paul wrote: > Declare the var in the scopes where it's used. Reviewed-by: Rob Clark > --- > src/mesa/main/context.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/context.c b/src/mesa

Re: [Mesa-dev] [PATCH 5/9] mesa: make _mesa_read_buffer() static

2016-02-23 Thread Rob Clark
On Tue, Feb 23, 2016 at 6:45 PM, Brian Paul wrote: > Not called from any other file. Remove _mesa_ prefix and update comments. Reviewed-by: Rob Clark > --- > src/mesa/main/buffers.c | 13 +++-- > src/mesa/main/buffers.h | 4 > 2 files changed, 7 insertions(+

Re: [Mesa-dev] [PATCH 6/9] mesa: make _mesa_draw_buffer() static

2016-02-23 Thread Rob Clark
On Tue, Feb 23, 2016 at 6:45 PM, Brian Paul wrote: > Reviewed-by: Rob Clark > --- > src/mesa/main/buffers.c | 12 ++-- > src/mesa/main/buffers.h | 3 --- > 2 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/src/mesa/main/buffers.c b/src/mesa/m

<    5   6   7   8   9   10   11   12   13   14   >